Issue 126582 - When trying to access a read/only share on Sharepoint an error is shown
Summary: When trying to access a read/only share on Sharepoint an error is shown
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.1.1
Hardware: All Windows, all
: P5 (lowest) Blocker (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-11 09:32 UTC by Giuseppe Castagno (aka beppec56)
Modified: 2016-08-30 21:35 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
pescetti: 4.1.2_release_blocker+

Attachments
Path to fix the issue (1.29 KB, patch)
2015-10-11 09:56 UTC, Giuseppe Castagno (aka beppec56) 		giuseppe.castagno: review?
Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Giuseppe Castagno (aka beppec56) 2015-10-11 09:32:29 UTC 
When accessing a read-only share on Sharepoint the error:
"The operation on \\rerpoint\sites\TestSP\Documenti condivisi\Lorem_ipsum.doc was started with an invalid parameter." is shown.


To reproduce you need a Sharepoint server, then do as follow:

1) on Sharepoint 2013 make a share read only

2) try to open a file in it;

3) the error "The operation on \\rerpoint\sites\TestSP\Documenti condivisi\Lorem_ipsum.doc was started with an invalid parameter." is shown

Starting with version 4.1.2rc1, you can open the file as read/only and no error is show.

Found a Windows API error not detected by AOO.
As soon as I have a patch ready I'll attach it.
Comment 1 Giuseppe Castagno (aka beppec56) 2015-10-11 09:50:33 UTC 
A small correction to my Description , the sentence:

"Starting with version 4.1.2rc1, you can open the file as read/only and no error is show"

should instead read:

"Starting with version 4.1.2rc2, you can open the file as read/write and no error is show"
Comment 2 Giuseppe Castagno (aka beppec56) 2015-10-11 09:56:08 UTC 
Created attachment 85036 [details]
Path to fix the issue
Comment 3 Giuseppe Castagno (aka beppec56) 2015-10-11 09:58:26 UTC 
Comment on attachment 85036 [details]
Path to fix the issue

This patch correct the issue described, unfortunately it was only discovered this week.

Took a few day to build AOO with the attached fix and test it.
It would be nice if it finds the way into 4.1.2.
Thanks
Comment 4 Andrea Pescetti 2015-10-11 11:54:01 UTC 
This is not included in OpenOffice 4.1.2-RC2. It can be considered for OpenOffice 4.1.2 only if we decide that 4.1.2-RC2 still needs fixes. Marking as "4.1.2 release blocker: ?" to express this.
Comment 5 Andrea Pescetti 2015-10-17 19:58:01 UTC 
Committed to trunk with revision 1709212. Thank you Giuseppe!

Note: this is not committed to AOO410 yet. Decision on merging remains pending.
Comment 6 Andrea Pescetti 2015-10-19 12:22:39 UTC 
This is now merged to AOO410 with revision 1709402.
Comment 7 Giuseppe Castagno (aka beppec56) 2015-10-26 09:15:51 UTC 
Checked on target Sharepoint 2013, found fixed on AOO 4.1.2-rc3
Comment 8 Giuseppe Castagno (aka beppec56) 2015-10-26 09:18:10 UTC 
Forgot the platform: Windows 7 32bit.
Comment 9 Andrea Pescetti 2015-10-26 14:47:10 UTC 
Marking VERIFIED as per comments by Giuseppe.
Comment 10 Kay 2016-08-30 21:35:52 UTC 
Closing.