Issue 126701 - Patch for adding bit shift functions to calc
Summary: Patch for adding bit shift functions to calc
Status: RESOLVED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P2 Normal (vote)
Target Milestone: 4.2.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-26 13:52 UTC by Pathangi Jatinshravan
Modified: 2016-02-14 17:06 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: 4.2.0-dev
Developer Difficulty: ---

Attachments
Patch to add bit shift functions. (9.14 KB, patch)
2015-11-26 13:52 UTC, Pathangi Jatinshravan 		no flags Details | Diff
Patch addressing some review comments (8.97 KB, patch)
2015-12-04 12:39 UTC, Pathangi Jatinshravan 		no flags Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Pathangi Jatinshravan 2015-11-26 13:52:34 UTC 
Created attachment 85173 [details]
Patch to add bit shift functions.

This patch adds bit shift operations (left shift and right shift) to Calc.
Comment 1 Pathangi Jatinshravan 2015-12-04 12:39:11 UTC 
Created attachment 85193 [details]
Patch addressing some review comments

Dropped check for value less than 2^48, and removed unnecessary casting from double to sal_uInt64.
Comment 2 damjan 2015-12-06 18:18:29 UTC 
Patch committed in revision 1718196. Thank you very much for your contribution!
Comment 3 oooforum (fr) 2016-02-14 16:03:45 UTC 
It will be fine to provide documentation about this add-on.
Adding these functions in help file F1.
Comment 4 orcmid 2016-02-14 17:06:35 UTC 
(In reply to oooforum from comment #3)
> It will be fine to provide documentation about this add-on.
> Adding these functions in help file F1.

Is this a request or an offer?