Issue 126840 - Windows/MSVC build often fails in main/icu
Summary: Windows/MSVC build often fails in main/icu
Status: RESOLVED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: external prerequisites (show other issues)
Version: 4.2.0-dev
Hardware: All Windows, all
: P5 (lowest) Normal (vote)
Target Milestone: 4.2.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-11 22:57 UTC by damjan
Modified: 2016-09-18 19:10 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.2.0-dev
Developer Difficulty: ---
pats: 4.1.3_release_blocker+


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description damjan 2016-02-11 22:57:47 UTC
About 50% of the time, building AOO on Windows with MSVC (not MingW) fails in icu with this error:


Generating Code...
        link.exe @C:\cygwin32\tmp\nm2E74.tmp
   Creating library .\..\..\lib\icule.lib and object .\..\..\lib\icule.exp
        if exist ..\..\bin\icule40.dll.manifest mt.exe -manifest ..\..\bin\icule40.dll.manifest -outputresource:..\..\bin\icule40.dll;2
        copy ".\LEFontInstance.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LEGlyphFilter.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LEGlyphStorage.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LEInsertionList.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LELanguages.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LEScripts.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LESwaps.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LETypes.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\LayoutEngine.h" ..\..\include\layout
        1 file(s) copied.
        copy ".\loengine.h" ..\..\include\layout
        1 file(s) copied.
        cd "..\allinone"
        cd "C:\OpenOfficeDev\Trunk\main\icu\wntmsci12.pro\misc\build\icu\source\allinone\..\layoutex"
        C:\PROGRA~2\MICROS~1.0\VC\bin\nmake.exe /                   /F layoutex.mak EXCEPTIONSWITCH="-EHa -Zc:wchar_t-"

Microsoft (R) Program Maintenance Utility Version 9.00.30729.01
Copyright (C) Microsoft Corporation.  All rights reserved.

        if not exist ".\Release/" mkdir ".\Release"
        rc.exe /l 0x409 /fo".\Release\layoutex.res" /i "..\common" /d "NDEBUG" .\layoutex.rc
Microsoft (R) Windows (R) Resource Compiler Version 6.1.7600.16385
Copyright (C) Microsoft Corporation.  All rights reserved.

NMAKE : fatal error U1073: don't know how to make '".\..\..\lib\icuin.lib"'
Stop.
NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~1.0\VC\bin\nmake.exe' : return code '0x2'
Stop.
dmake:  Error code 2, while making './wntmsci12.pro/misc/build/so_built_so_icu'

1 module(s):
        icu
need(s) to be rebuilt

Reason(s):

ERROR: error 65280 occurred while making /cygdrive/c/OpenOfficeDev/Trunk/main/icu

When you have fixed the errors in that module you can resume the build by running:

        build --all:icu
Comment 1 damjan 2016-02-11 23:09:23 UTC
Path committed in revision 1729921, resolving fixed.

#i126840# - Windows/MSVC build often fails in main/icu 

The build script (used only on MSVC, not MingW or other OSes) for icu
generates nmake makefiles for the build using icu's
source/allinone/allinone.sln, in which layoutex doesn't list a dependency
on i18n, despite linking to icuin.lib from i18n, which sporadically causes
the icu build to fail. This is really an upstream bug, however upstream
doesn't build using allinone.sln so we are affected more.

This patch declares the missing dependecy, and makes icu build reliably.

Patch by: me
Tested by: pats
Comment 2 Ariel Constenla-Haile 2016-09-18 18:39:31 UTC
This should be cherrypicked in branch AOO413
Comment 3 SVN Robot 2016-09-18 19:10:07 UTC
"arielch" committed SVN revision 1761355 into branches/AOO413:
i126840 - Cherrypick Revision 1729921 from trunk