Issue 127723 - Use cairo graphics also on OS/2 to show presentations
Summary: Use cairo graphics also on OS/2 to show presentations
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.2.0-dev
Hardware: All OS/2
: P5 (lowest) Normal (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 126518
  Show dependency tree
 
Reported: 2018-03-02 10:46 UTC by Yuri Dario
Modified: 2018-03-07 14:53 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Yuri Dario 2018-03-02 10:46:46 UTC
The OS/2 canvas code does not make use of cairo graphics library, so GPI is used to draw on the screen. Enabling cairo will allow use of antialiasing for drawing primitives and text rendering.
Comment 1 SVN Robot 2018-03-02 15:50:42 UTC
"ydario" committed SVN revision 1825732 into trunk:
#i127723# add cairo graphics support also on OS/2.
Comment 2 Yuri Dario 2018-03-03 15:56:21 UTC
Found that bullets rendering is broken. cairo is called to draw bullets using StarSymbol font, but this is no longer available. Probably a StarOffice font. Installing the free StarSymbol font by Agfa fixes rendering but this is not the solution used on other platforms. VCL uses OpenSymbol for  bullets, so somewhere there is a mapping between the two names.
Comment 3 Yuri Dario 2018-03-07 07:43:40 UTC
Debugging VCLcanvas shows that it draws bullets using StarSymbol too. So it is the VCL output device that maps it to StarSymbol.
This means cairo canvas should map the font name itself. I wonder how it works on other platforms.
Comment 4 SVN Robot 2018-03-07 14:46:15 UTC
"ydario" committed SVN revision 1826117 into trunk:
#i127723# Fix StarSymbol to OpenSymbol mapping when using cairo on OS/2.
Comment 5 Yuri Dario 2018-03-07 14:53:43 UTC
I did not dig deep into VCL code handling OpenSymbol, but it seems to be that it is flagged as symbol font and thus it is the font used when drawing symbols. Since our cairo implementation is not using font selection from VCL (as done in other platforms) it is simpler to just rename the font before selecting it with cairo toy API.