Issue 128375 - AOO Impress: tilde (~) in button's label
Summary: AOO Impress: tilde (~) in button's label
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 4.1.7
Hardware: PC Windows, all
: P5 (lowest) Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-04 10:48 UTC by Czesław Wolański
Modified: 2022-06-13 05:30 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.12
Developer Difficulty: Easy


Attachments
Screenshots illustrating this issue (308.83 KB, image/jpeg)
2020-05-04 10:48 UTC, Czesław Wolański
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Czesław Wolański 2020-05-04 10:48:24 UTC
Created attachment 86939 [details]
Screenshots illustrating this issue

Configuration:
- Windows 7, 64-bit, Home Premium, PL
- AOO417m1(Build:9800) - Rev. 46059c9192
  2019-09-03 12:04


Steps to demonstrate:

1. launch AOO Impress
2. press 'Create' button in 'Presentation Wizard' dialog
   to create new presentation
3. In Sidebar open 'Slide Transition' deck
4. In 'Modify transition' section,
   in 'Sound' drop-down list select item 'Other Sound'

   You might notice that in the invoked dialog
   button's label reads "~Play".


Note:
This issue occurs in:
- all language versions I checked (EN, DE, FR, PL, RU)
- AOO 4.2.0-dev (EN)
  AOO420m2(Build:9821) - Rev. e02a33f4e7
  2020-05-02 11:28 - CYGWIN_NT-10.0 x86_64 - Snapshot Test Build

Relevant screenshots are in attached file "TildeInLabel"
Comment 1 oooforum (fr) 2020-05-04 14:42:12 UTC
Seems to be an error in sd/source/ui/animations.po

This tilde should be removed.
After, this error in other languages must take this through Pootle.

Easy hack and you can submit a pull request on Github
Comment 2 oooforum (fr) 2020-05-04 14:44:21 UTC
I'm wrong
I think that sfx2/source/dialog.po is _the_ file
Comment 3 Czesław Wolański 2022-06-11 18:03:53 UTC
I am not a developer, but looking at the source files under /sd ("SlideTransitionPane.cxx", "CustomAnimationDialog.cxx" and
"filedlg.cxx") I would say that the string in question is
in "sd/source/ui/app.po"
cf. source code, file "strings.src"
http://openoffice-vm1-he-de.apache.org/xref/trunk/main/sd/source/ui/app/strings.src?r=16e7aaae#571

My own test:
file   \OpenOffice 4\program\resource\sden-US.res
contains two strings ""~Play". The first one is relevant.
I changed it to "xPlay" and that's what AOO displays now.

My original report did not point out that:
(1) the "tilde" problem occurs when the dialogs of the operating system
are used. In case of OpenOffice dialogs the "tilde" works as expected.
(2) the dialog for sound files can be invoked from 
the Slide Transition deck and the Custom Animation deck
(3) the "Stop" label may be affected too. On Windows 7 and 11
the "Play" button doesn't work for me; it works only
with the OpenOffice dialogs ON. I checked then LibreOffice
- as the "Play" button works, I could see the botched "Stop" label
("Sto~p").



Perhaps a developer could fancy this problem...
Comment 4 Peter 2022-06-13 05:30:30 UTC
Czelaw 
There are other strings which have a ~ sign
another example:
String STR_EFFECTDLG_ACTION
{
	Text [ en-US ] = "Act~ion" ;
};
	CheckBox CB_UNDO_DELETE_DISABLE
	{
		HelpID = "sd:CheckBox:RID_UNDO_DELETE_WARNING:CB_UNDO_DELETE_DISABLE" ;
		Pos = MAP_APPFONT ( 39, (4 * 12) + 9 ) ;
		Size = MAP_APPFONT ( 175, 12 ) ;
		Text [ en-US ] = "~Do not show this warning again" ;
	};

String STR_EDIT_OBJ
{
	Text [ en-US ] = "~Edit" ;
};

I guess we should remove the ~ Signs.
I have created a pull request on github removing all ~ in the file:
https://github.com/apache/openoffice/pull/153