Issue 128403 - Mixing of perl backticks and system() in main/set_soenv.in
Summary: Mixing of perl backticks and system() in main/set_soenv.in
Status: RESOLVED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: solenv (show other issues)
Version: 4.2.0-dev
Hardware: All All
: P5 (lowest) Normal (vote)
Target Milestone: 4.2.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-06 21:56 UTC by vorobyov.mikhail
Modified: 2020-11-24 23:26 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description vorobyov.mikhail 2020-09-06 21:56:23 UTC 
Shouldn't only one of those be used here?

--- a/main/set_soenv.in
+++ b/main/set_soenv.in
@@ -2224,8 +2224,8 @@ print OUT "#!/bin/sh\n";
 if ( $MINGW eq "yes" )
 {  print OUT 'PATH="/usr/bin:$PATH" : export PATH'."\n"; }
 close( OUT ) || print "Can't close $bootfile: $!";
-system(`cat bootstrap.1 >> bootstrap`);
-system(`chmod +x bootstrap`);
+system('cat bootstrap.1 >> bootstrap');
+system('chmod +x bootstrap');
 #
 #--------------------------------------------------------
 # Moving the bootstrap file to the build home directory.
Comment 1 oooforum (fr) 2020-11-24 19:29:21 UTC 
Sorry, I don't understand what you means.
Could be more explicite?

Set temporarily as "not an issue".
Comment 2 Matthias Seidel 2020-11-24 20:25:13 UTC 
Fixed in trunk with:
https://github.com/apache/openoffice/commit/6dee92fc114c8598a192b75a4a8146b6fcd238cd

Cherry-picked for AOO42X with:
https://github.com/apache/openoffice/commit/11e298eca1e00752c6a010762580ba3dffbe873b

Thank you for finding this!
Comment 3 Marcus 2020-11-24 23:26:25 UTC 
I've set "4.2.0" as target milestone.