Issue 17764 - Any change tracking in a texttable is lost if the table is altered
Summary: Any change tracking in a texttable is lost if the table is altered
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC2
Hardware: PC Linux, all
: P2 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
Keywords: oooqa
: 3460 8446 9665 25944 33564 41485 45889 77822 (view as issue list)
Depends on:
Reported: 2003-08-01 16:17 UTC by dsherwin
Modified: 2013-08-07 14:41 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Note You need to log in before you can comment on or make changes to this issue.
Description dsherwin 2003-08-01 16:17:43 UTC
If change tracking is enabled and the document has a text table, if there is a
change to the text in the table and table is modified, i.e. by spliting a cell
or by adding cells, all tracking is losed in the table.
Comment 1 andreas.martens 2003-08-04 14:26:17 UTC
This is a known design/implementation problem. We want to solve it for
OOo 2.0.
Comment 2 dsherwin 2003-08-07 10:29:11 UTC
Removing instances of lcl_DelRedline in sw/source/docnode/ndtbl.cxx
seems to fix this issue for most cases. The only case that this did
not fix was merging cells.
Comment 3 stefan.baltzer 2003-08-08 11:04:09 UTC
SBA: Note that there is an (internal) issue about this too (bt4903294).
Comment 4 dsherwin 2003-08-12 14:34:39 UTC
dsherwin->SBA: Can you mark the internal bugtracker issue (bt4903294)
as duplicate of this issue, as this affects both OOo and SO?
Comment 5 openoffice 2003-09-18 17:35:41 UTC
Comment 6 dsherwin 2003-09-19 17:48:15 UTC
Turning off lcl_DelRedlines in sw/source/core/docnode/ndtbl.cxx
overcomes most of the issues.
I have tried approx 100 operations on the table with plenty of
undo/redo  and no redlines were lost.
The only case left is the merging of cells.
Comment 7 eric.savary 2003-09-26 17:33:20 UTC
According to the roadmap 
( this issue was retargeted to 
OOo Later.
Comment 8 guido.pinkernell 2004-02-08 19:57:46 UTC
Could be connected with Issue 21670?
Comment 9 michael.ruess 2004-08-31 13:25:21 UTC
*** Issue 33564 has been marked as a duplicate of this issue. ***
Comment 10 openoffice 2004-11-10 17:34:31 UTC
dvo: OK... The reason this was not fixed in the past is that properly solving
table redlines problems would require a significant re-design of the redlining
code, which no one has undertaken so far.

The problem is... this gets requested over and over again, and deep down we all
know the users are actually right...

One possibility is to simply disable the code which removes the redlines  (as
dsherwin has already tried out). That is easy to do but unfortunately rather
risky, in that the original developer warned us from doing this without the
bespoke redline redesign. What we would like to do is to include this into a
development or beta version and get it into the public, and possibly roll back
the changes if they prove trouble-some. I'm quite optimistic however,
particularly since Darragh appears not to have run into any problems.

I have introduces a new define DEL_TABLE_REDLINES into
sw/source/core/docnode/ndtbl.cxx, and wrapped all changes for this issue into
suitable ifdefs. Enabling the define will fully restore the previous behaviour.

dvo->mru: Please test. Have fun. :-) No, really!
Comment 11 openoffice 2004-11-10 17:36:02 UTC
*** Issue 25944 has been marked as a duplicate of this issue. ***
Comment 12 openoffice 2004-11-15 12:58:12 UTC
dvo: Reopen for QA.
Comment 13 openoffice 2004-11-15 13:00:45 UTC
dvo->mru: Please test.
Comment 14 michael.ruess 2004-11-18 07:31:58 UTC
Should have state "fixed".
Comment 15 michael.ruess 2004-11-19 14:33:23 UTC
Comment 16 michael.ruess 2004-11-19 14:34:30 UTC
MRU->DVO: due to the Assertions which rise when working with Redlines in tables,
me and AMA decided to move the fix to a different CWS.
Comment 17 openoffice 2004-11-29 12:26:34 UTC
dvo: Fixed in swtableredline. Will send to QA after more thorough testing.
Comment 18 michael.ruess 2005-01-28 07:29:46 UTC
*** Issue 41485 has been marked as a duplicate of this issue. ***
Comment 19 dsherwin 2005-02-16 15:34:47 UTC
CC'ing Aidan on this issue
Comment 20 openoffice 2005-03-14 19:30:41 UTC
dvo: Found & fixed several problems when merging cells with redlines.


| abc       |
| defghi    |

When one of 'abc' or 'def' is redlined and the cells are merged, the redlining
would do funny stuff. Also, when there was a bookmark, OOo would crash after
cell merge + undo.
Comment 21 eric.savary 2005-03-21 18:05:49 UTC
ES->DVO: I tortured the Writer with redlining in tables, deleting insertin,
merging, splitting, with bookmarks, frames to characters, undo and redo -> no
redlining loss, no crash! Great job!

Verified in CWS swtableredline 
Comment 22 eric.savary 2005-03-28 23:38:07 UTC
Comment 23 eric.savary 2005-03-28 23:41:12 UTC
Comment 24 eric.savary 2005-03-28 23:48:44 UTC
Comment 25 eric.savary 2005-03-29 00:06:23 UTC
Comment 26 michael.ruess 2005-03-29 06:33:40 UTC
*** Issue 45889 has been marked as a duplicate of this issue. ***
Comment 27 eric.savary 2005-03-31 16:34:08 UTC
Ok in SRC680m90
Comment 28 stefan.baltzer 2005-11-03 15:01:50 UTC
*** Issue 8446 has been marked as a duplicate of this issue. ***
Comment 29 andreas.martens 2006-03-21 09:22:16 UTC
*** Issue 9665 has been marked as a duplicate of this issue. ***
Comment 30 michael.ruess 2007-05-30 08:54:39 UTC
*** Issue 77822 has been marked as a duplicate of this issue. ***
Comment 31 michael.ruess 2009-04-29 07:48:16 UTC
*** Issue 3460 has been marked as a duplicate of this issue. ***