Issue 17995 - up standard autofilter fields from 3 to 4
Summary: up standard autofilter fields from 3 to 4
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: All All
: P3 Trivial with 7 votes (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
: 22974 34378 60235 83588 (view as issue list)
Depends on:
Blocks: 101374
  Show dependency tree
 
Reported: 2003-08-07 23:28 UTC by philmperry
Modified: 2013-08-07 15:14 UTC (History)
10 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Default appearance of Standard filter dialog (8.30 KB, image/png)
2008-09-04 14:18 UTC, frank.loehmann
no flags Details
Expanded Standard filter dialog showing all options (13.03 KB, image/png)
2008-09-04 14:19 UTC, frank.loehmann
no flags Details
Updated version with corrected buttons (13.19 KB, image/png)
2008-09-04 14:24 UTC, frank.loehmann
no flags Details
Updated version tith corrected buttons (8.49 KB, image/png)
2008-09-04 14:26 UTC, frank.loehmann
no flags Details
This patch described as follows: In standard filter dialog box, adds a row for filter condition, and increases filter conditions to 8 groups. The number of connection listbox add to 4 when the slider is not in 0 position. By scrollbar, the filter conditi (34.05 KB, text/plain)
2009-01-05 07:06 UTC, gaojingmei
no flags Details
This patch described as follows: In standard filter dialog box, adds a row for filter condition, and increases filter conditions to 8 groups. The number of connection listbox add to 4 when the slider is not in 0 position. By scrollbar, the filter conditi (34.05 KB, text/plain)
2009-01-05 07:10 UTC, gaojingmei
no flags Details
This patch described as follows: In standard filter dialog box, adds a row for filter condition, and increases filter conditions to 8 groups. The number of connection listbox add to 4 when the slider is not in 0 position. By scrollbar, the filter conditi (34.05 KB, text/plain)
2009-01-05 07:10 UTC, gaojingmei
no flags Details
The updated patch of i17995 (33.17 KB, text/plain)
2009-01-07 06:35 UTC, gaojingmei
no flags Details
A patch about issue 17995. (32.32 KB, text/plain)
2009-01-07 08:38 UTC, gaozm
no flags Details
The updated patch of i17995 (33.72 KB, text/plain)
2009-01-12 05:12 UTC, gaojingmei
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description philmperry 2003-08-07 23:28:42 UTC
The spreadsheet database autofilter "standard" can handle up to three fields.
Apparently the latest versions of Excel can handle four fields. Please consider
upping the field count from three to four. Even better, allow a more-or-less
unlimited number of filter fields (use a dialog with a scrolling list of fields
and operators).
Comment 1 frank 2003-08-08 08:33:07 UTC
Hi Bettina,

1 4 u

Frank
Comment 2 frank 2003-11-28 13:46:56 UTC
*** Issue 22974 has been marked as a duplicate of this issue. ***
Comment 3 krtek 2004-07-13 15:19:00 UTC
It'll be a verey useful thing to be able to choose an unlimited number of
filters field ...
Comment 4 frank 2004-09-20 09:31:29 UTC
*** Issue 34378 has been marked as a duplicate of this issue. ***
Comment 5 hwoarang 2006-02-25 01:28:46 UTC
*** Issue 60235 has been marked as a duplicate of this issue. ***
Comment 6 frank 2007-11-13 15:22:10 UTC
*** Issue 83588 has been marked as a duplicate of this issue. ***
Comment 7 gaozm 2008-08-26 09:38:08 UTC
I would like to fix this issue.
Comment 8 gaozm 2008-08-26 09:40:26 UTC
Hi, all
    I would like to fix this issue.
Comment 9 niklas.nebel 2008-08-26 09:44:30 UTC
Before implementing this, please check with User Experience if they agree on the
change.
Comment 10 Uwe Altmann 2008-08-30 11:58:35 UTC
Maybe the filter function in Thunderbird may be a guide. It is a clean GUI with
unlimited number of filters.
Depending on amount of work it is maybe the best idea to have this final
solution - when next Exel version does have five filters we don't have to add
one more then ;-)
Comment 11 discoleo 2008-08-30 17:50:57 UTC
Extending the filter offers only a limited functionality. A far more flexible
way to extend the functionality is described in issue 66588.
http://www.openoffice.org/issues/show_bug.cgi?id=66588

Having the ability to perform SQL-statements natively in Calc (without external
data sources) is a way more flexible feature without any artificial limitations.

The existing filter has 3 major limitations:
1.) limited categories (currently 3)
2.) limited string functionality
3.) no possibility to save and load filter settings

Also, comparisons between 2 fields cannot be done and need to be pre-computed.

Extending the filter to cover 4 fields is at most a minor enhancement.

IF it is still desired to extend it, then a more comprehensive solution that
permits an unlimited amount of rows is warranted:

             [FIELD]  [CONDITION]  [VALUE] [-]
 [OPERATOR]  [FIELD]  [CONDITION]  [VALUE] [-]
[ADD CONDITION] [DELETE CONDITION] [UNDO]

Where:
 [-] Deletes the corresponding filter condition
 [ADD CONDITION] Adds another row to the filter
 [DELETE CONDITION] Similar to [-], deletes the
   condition that has the focus
 [UNDO] Undo last action (e.g. restores a deleted
   condition)

IF less than 2 conditions remain, then 2 rows will be displayed, with one or
both rows empty (as appropriate).
Comment 12 gaozm 2008-09-01 03:49:53 UTC
Thank you for your comments.:)
Comment 13 christoph 2008-09-02 22:06:42 UTC
Added comments from UX point of view on ux-discuss mailing list:
http://ux.openoffice.org/servlets/ReadMsg?list=discuss&msgNo=2316
Comment 14 frank.loehmann 2008-09-04 14:18:06 UTC
Created attachment 56234 [details]
Default appearance of Standard filter dialog
Comment 15 frank.loehmann 2008-09-04 14:19:07 UTC
Created attachment 56235 [details]
Expanded Standard filter dialog showing all options
Comment 16 frank.loehmann 2008-09-04 14:24:43 UTC
Created attachment 56236 [details]
Updated version with corrected buttons
Comment 17 frank.loehmann 2008-09-04 14:26:16 UTC
Created attachment 56237 [details]
Updated version tith corrected buttons
Comment 18 discoleo 2008-12-17 18:04:52 UTC
Slightly reworking my previous comment:

IF it is still desired to extend it, then a more comprehensive solution that
permits an unlimited amount of rows is warranted:

             [FIELD]  [CONDITION]  [VALUE] [-]
 [OPERATOR]  [FIELD]  [CONDITION]  [VALUE] [-]
 [OPERATOR]  [FIELD]  [CONDITION]  [VALUE] [-]
 [MORE OPTIONS] [DELETE CONDITION] [UNDO] [HELP]

Where:
 A new row of conditions is automatically added
   once ALL rows are filled with conditions.
   [CHANGED from my previous post.]

 [-] Deletes the corresponding filter condition.
     If there are less than 3 conditions, the
     remaining rows up to 3 are displayed empty.

 [DELETE CONDITION] Similar to [-], deletes the
   condition that has the focus

 [UNDO] Undo last action (e.g. restores a deleted
   condition)

 [MORE OPTIONS] Display the advanced options

 [HELP] Display the Help

Comment 19 discoleo 2008-12-17 18:07:11 UTC
And forgot the OK/Cancel buttons :-)

[MORE OPTIONS] [DELETE] [UNDO] [OK] [CANCEL] [HELP]
Comment 20 gaojingmei 2009-01-05 07:06:11 UTC
Created attachment 59129 [details]
This patch described as follows: In standard filter dialog box, adds a row for filter condition, and increases filter conditions to 8 groups. The number of connection listbox add to 4 when the slider is not in 0 position. By scrollbar, the filter conditi
Comment 21 gaojingmei 2009-01-05 07:10:09 UTC
Created attachment 59130 [details]
This patch described as follows: In standard filter dialog box, adds a row for filter condition, and increases filter conditions to 8 groups. The number of connection listbox add to 4 when the slider is not in 0 position. By scrollbar, the filter conditi
Comment 22 gaojingmei 2009-01-05 07:10:42 UTC
Created attachment 59131 [details]
This patch described as follows: In standard filter dialog box, adds a row for filter condition, and increases filter conditions to 8 groups. The number of connection listbox add to 4 when the slider is not in 0 position. By scrollbar, the filter conditi
Comment 23 gaojingmei 2009-01-05 07:21:24 UTC
Because of the bad network, datafilter.patch is submitted three times, the 
three attachments about datafilter.patch are the same. 
Comment 24 yonggang.mao 2009-01-05 07:41:29 UTC
Hi Niklas,
I have reviewed this patch file,I think it can work well,I hope you can review 
it.thanks!
Comment 25 niklas.nebel 2009-01-06 17:06:27 UTC
Some points:

- When filling the dialog from existing conditions (ScFilterDlg::Init), why is
the last value left out?

- The Tab order of the list boxes is wrong.

- It must be possible to use the dialog with the keyboard, also to scroll to the
other entries. In the Function Wizard and the Solver dialog we use cursor keys
in the edit fields, but the list boxes in the filter dialog use the cursor keys
already. You could add a TabStop flag to the scroll bar, but that wouldn't be
very comfortable. Maybe you have a different idea.

Otherwise this seems to work.
Comment 26 gaojingmei 2009-01-07 06:35:10 UTC
Created attachment 59196 [details]
The updated patch of i17995
Comment 27 gaozm 2009-01-07 08:38:29 UTC
Created attachment 59197 [details]
A patch about issue 17995.
Comment 28 niklas.nebel 2009-01-09 18:48:02 UTC
I looked at gaojingmei's last patch and noticed 2 things:

- In the "Find & Replace" dialog, "Less Options" has been renamed to "Fewer
Options" (issue 84980), so we should also use "Fewer Options".

- The tab order of the list boxes is correct now, but the order of the other
controls is a bit strange.
Comment 29 gaojingmei 2009-01-12 05:12:37 UTC
Created attachment 59313 [details]
The updated patch of i17995
Comment 30 niklas.nebel 2009-01-13 11:26:03 UTC
The new patch looks good and I think we can integrate it when we have a CWS for
3.2 (feature freeze for 3.1 is over).
Comment 31 niklas.nebel 2009-03-17 16:45:43 UTC
taking the issue
Comment 32 niklas.nebel 2009-03-17 16:47:52 UTC
I added this to CWS "calc49". I changed the dialog layout a bit to match Frank's
suggestion in the screenshot. The "Condition" list boxes should be made larger
only when issue 35579 is integrated. The wide list boxes with the short content
would look a bit strange.
Comment 33 niklas.nebel 2009-04-03 08:56:24 UTC
reassigning to QA for verification
Comment 34 oc 2009-05-11 08:18:20 UTC
verified in internal version cws_calc49.
Updated autotest c_updt2.bas to handle this enhancement
Comment 35 amy2008 2009-06-01 08:02:37 UTC
Verified in DEV300m49 on WinXP 
Closing