Issue 21010 - Crash during undo
Summary: Crash during undo
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1
Hardware: Other Other OS
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: oooqa
Depends on:
Blocks:
 
Reported: 2003-10-10 11:41 UTC by frank.meies
Modified: 2013-08-07 14:41 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
New bugdoc (1.46 MB, application/msword)
2004-05-13 07:17 UTC, frank.meies 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description frank.meies 2003-10-10 11:41:32 UTC 
Load bugdoc of i20288. Go to the beginning of the section of on the first page.
Press backspace, undo -> assertion and crash.
Comment 1 frank.meies 2003-10-10 12:05:18 UTC 
FME->TZ: Target OOo 1.1.1?
Comment 2 utomo99 2004-01-31 02:53:04 UTC 
NO answer from October. 

------- Additional comments from fme Fri Oct 10 03:05:18 -0800 2003 -------

FME->TZ: Target OOo 1.1.1?
Comment 3 openoffice 2004-02-04 18:45:21 UTC 
.
Comment 4 frank.meies 2004-05-13 07:17:30 UTC 
Created attachment 15219 [details]
New bugdoc
Comment 5 frank.meies 2004-05-13 07:18:41 UTC 
FME->DVO: The current old bugdoc caused some other problems. I attached a new one.
Comment 6 openoffice 2004-06-21 10:56:01 UTC 
dvo: I'm having a hard time fixing this; I can detect the problem situation, but
properly handling it is more difficult. I may fix this in two steps then:
Prevent crash by disabling the undo in this special case, and then provide a fix
to make the undo work properly.
Comment 7 openoffice 2004-10-13 15:19:06 UTC 
dvo: Fixed.

The problem occurs when deleting across adjacent sections, i.e.:

[a]
[b
c]

( square brackets denote section begin/end, lines denote paragraphs )
To reproduce the problem: place cursor before 'b', backspace, undo -> crash.

The (rather convoluted) undo code contains special treatment for hierarchical
sections (i.e., [[a] b c]) but doesn't work for adjacent ones. A new flag
(bSpecialSectNd) now takes care of this situation, this solving the problem and
making the undo code just a tad more convoluted.
Comment 8 openoffice 2004-12-20 18:10:45 UTC 
dvo: reopen for QA.
Comment 9 openoffice 2004-12-20 18:12:29 UTC 
dvo->mru: Please test. The bug was fixed in some older CWS, but apparently I
failed to appriately add the issue to said CWS. Please test on any current release.
Comment 10 openoffice 2004-12-20 18:12:46 UTC 
.
Comment 11 michael.ruess 2004-12-21 10:20:54 UTC 
Yes, can confirm. No crash anymore (680m66) when undoing deletion in section.