Issue 26488 - disable sizing controls for Title and Legend as long as those functions are not available
Summary: disable sizing controls for Title and Legend as long as those functions are n...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL:
Keywords:
: 36426 71855 (view as issue list)
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2004-03-15 13:00 UTC by kla
Modified: 2013-02-24 21:19 UTC (History)
6 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch_080220 (820 bytes, text/plain)
2008-02-20 06:13 UTC, weiz
no flags Details
patch_080221 (556 bytes, text/plain)
2008-02-21 02:56 UTC, weiz
no flags Details
patch_080225 (571 bytes, text/plain)
2008-02-25 01:48 UTC, weiz
no flags Details
patch_080227 (1.66 KB, text/plain)
2008-02-29 08:27 UTC, weiz
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description kla 2004-03-15 13:00:44 UTC
Its possible to change the Size of Title and Legend into the Position and Size
Dialog.
It must be prevent.
Comment 1 kla 2004-03-15 13:02:31 UTC
Set Keyword
Comment 2 IngridvdM 2004-03-15 13:56:06 UTC
.
Comment 3 IngridvdM 2004-03-24 12:51:31 UTC
The elements in the dialog should be disabled as they have no effect.
Comment 4 slkfc 2004-04-29 04:01:20 UTC
I would prefer to have the chart engine updated such that the Title and Legend  
can be resized instead of disabling the elements in the dialog
Comment 5 IngridvdM 2004-05-03 16:51:31 UTC
Yes you are right - thanks. I have added your wishes as feature tasks #i28670#
and #i28671#. Just for the meantime this is a bug and should be fixed.
Comment 6 kla 2004-08-11 09:59:14 UTC
according to http://www.openoffice.org/servlets/ReadMsg?list=releases&msgNo=7690
this issue will be set to OOoLater
Comment 7 kla 2004-11-04 11:18:35 UTC
*** Issue 36426 has been marked as a duplicate of this issue. ***
Comment 8 IngridvdM 2005-09-06 13:41:10 UTC
set target for new chart issues
Comment 9 IngridvdM 2006-03-21 20:15:58 UTC
changed summary to start with 'new chart: ' to avoid confusion with regular
chart issues
Comment 10 bjoern.milcke 2006-06-23 10:02:30 UTC
Changed target to 2.x
Comment 11 frank 2006-08-01 14:26:37 UTC
Side effect for enabled sizing of the legend :

Set keep ratio and change the width setting. Close the dialog and the legend
changes position but not the size.
Comment 12 IngridvdM 2006-10-25 14:26:47 UTC
This is no regression of the chart reimplementation compared to the old chart ->
changed target.
Comment 13 IngridvdM 2006-11-23 10:58:37 UTC
*** Issue 71855 has been marked as a duplicate of this issue. ***
Comment 14 weiz 2008-02-20 06:11:38 UTC
->iha: The patch of this issue is finished, please let me know if you have any 
suggestion.
Comment 15 weiz 2008-02-20 06:13:45 UTC
Created attachment 51595 [details]
patch_080220
Comment 16 IngridvdM 2008-02-20 15:20:45 UTC
->weiz: Thanks! The size controls are disabled for titles and legend now. Only
one thing maybe:
When opening the dialog for titles the two controls 'Fit width to text' and 'Fit
height to text' are still enabled. But they make no sense when sizing is not
possible. So could disable them also including their heading? Thanks in advance.
Ingrid
Comment 17 weiz 2008-02-21 02:55:20 UTC
->iha: The new patch is used for disable the two controls 'Fit width to text' 
and 'Fitheight to text', and also their heading.

Weizhao
Comment 18 weiz 2008-02-21 02:56:14 UTC
Created attachment 51618 [details]
patch_080221
Comment 19 IngridvdM 2008-02-22 11:58:04 UTC
With the previous svx patch the three controls are now enabled when the dialog
is opened for the diagram for example. That is a regression.
Comment 20 weiz 2008-02-25 01:48:22 UTC
->iha: Sorry for the incorrect patch, it caused by my carelessness, I thought 
the 'bSizeProtect' is the flag that the protect controls are enabled or 
disabled. The 'bSizeProtect' is changed to 'mbProtectDisabled' in the new patch
(080225).
Please let me know if you have any other suggestions. Thank you.
Comment 21 weiz 2008-02-25 01:48:56 UTC
Created attachment 51695 [details]
patch_080225
Comment 22 IngridvdM 2008-02-25 10:50:58 UTC
->weiz: When you open the position and size dialog for a simple rectangle shape
in draw the three controls are now enabled but should not.
These controls are not allowed to be enabled  for not-text-shapes, as they make
no sense then.
Comment 23 weiz 2008-02-29 08:24:33 UTC
->iha: The new patch for svx module is finished, it is OK in my test cases, 
hope I did not miss anything. :-)
Comment 24 weiz 2008-02-29 08:24:38 UTC
->iha: The new patch for svx module is finished, it is OK in my test cases, 
hope I did not miss anything. :-)
Comment 25 weiz 2008-02-29 08:27:14 UTC
Created attachment 51807 [details]
patch_080227
Comment 26 IngridvdM 2008-02-29 10:52:04 UTC
->weiz: Thanks! The patch looks fine now, even more correct in common case of
draw texts with size protection now :-)
I commited the patch to CWS chart23.
Comment 27 IngridvdM 2008-02-29 10:53:21 UTC
set type to patch
Comment 28 IngridvdM 2008-02-29 10:54:16 UTC
Fixed in CWS chart23.
Comment 29 IngridvdM 2008-03-13 15:37:22 UTC
->Thomas, please verify in CWS chart23.
Comment 30 kla 2008-04-01 11:07:28 UTC
Works fine in CWS chart23 -> verified
Comment 31 kla 2008-07-04 14:45:46 UTC
seen ok in current master -> closed