Issue 2836 - Spell Checker recommends words that are deemed "incorrect" by the exception dictionary.
Summary: Spell Checker recommends words that are deemed "incorrect" by the exception d...
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: 641
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-01-15 13:22 UTC by royalozma
Modified: 2013-08-07 14:43 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description royalozma 2002-01-15 13:22:29 UTC
The spell checker shows words that are supposedly marked incorrect in the user's
list of dictionary exceptions. [Eg: user dictionary with the (-) sign]

 * I add in the word "fairy" as a misspelled word [in the (-) type dictionary]
   and use "faery" as its correct spelling.
 * Then I put in the word "faery" into the correct spellings [the "normal"
   dictionary without (-)]
 * Type in the word "fairy", the redline appears under it.
    > Because "fairy" is in the exception dictionary.
 * Then I typed in "faery", no redline there.
    > Because "faery" is in the "normal" dictionary.
 * But when I typed in "faory" and wait for the redline then right click (to
   recommended spelling corrections). The word "fairy" appears as an correction
   recommendation, although I have made it as an incorrect
   spelling.

Also, the spell checker does not recommend words from the user dictionaries,
unless the redline "incorrect" word is in the exception (-) dictionary.
Comment 1 khendricks 2002-01-17 02:37:07 UTC
Hi,

Is this the OpenOffice.org SpellChecker or the StarOffice 
Spellchecker you are reporting on.

If this report is against the OOo spellchecker, this is not a bug 
that can be fixed by MySpell.  The user dictionaries support (where 
you can add and subtract words) is not part of the MySpell spell 
checker and so can not have an impact on suggestions.  They are 
separate systems.  

As a workaround until something is done by Hamburg to address this 
issue, if you have very specific spelling needs, (and it sounds like 
you do) I would be happy to show you how to generate your own custom 
MySpell compatible dictionary and then you can add and subtract your 
own words and have those changes then be reflected in the 
spellchecking suggestions, spelling, etc.

It is simple to do, so if you are interested, please e-mail me 
offline and I will walk you through how it is done.

kevin.hendricks@sympatico.ca

Hope this helps,

Kevin
   
Comment 2 thomas.lange 2002-01-17 11:24:51 UTC
Since I happen to check the results against the user-dictionaries in 
the dispatcher it is my task.

I'm just not yet sure about how serious this bug is to be considered.
And what/where the best way to solve it may be.

The problem is that at least in general it is not quite possible to 
ensure that the proposals itself will be considered correct.
It may be checked halfway easily for the words that happen to be in 
the user-dictionary (what I'm going to fix). 

But if the implementation itself suggests words that are not 
recognized by it we are at a loss.
I surely do not want to spell check each suggestion itself (which 
would be up to 20 times more effort than now...

Thus I'm just a _bit_ unsure if the suggestions should even be 
checked against the negative user-dictionaries. Because it is a 
somewhat similar case to the above one...

*think, think, ...*
^_-

I think I'll fix it for the words in the negative user-dictionaries 
(user-dictionaries _should_ be rather small). But for the mentioned 
reasons I'm not going to check if a suggestions itself is valid in 
general.

TL->FL, All: Any other comments or suggestions?

Comment 3 royalozma 2002-01-17 14:54:03 UTC
Note! I have mistakenly pasted this text into another issue (eg:
2838), also I have to find a way to beat those lousy time-outs.



INTRODUCTION

One time, I have tried using the exception dictionary feature to make
StarOffice to Orthographically verify (Spell Check) text in a language
that StarOffice does not support. I had limited success with that     
stunt. That language is Esperanto, and it is only implicitly supported
in OpenOffice.org via its ISO 10646 feature.

I refer and expect that the Orthographical Verifier (Spell Checker) to
remove words from the exception dictionary from the recommendations. I
have to double check the exception dictionary everytime when I have to
make a vocabulary adjustment, regardless if the language is English,  
Esperanto or another language.



MY NOTES ABOUT THE SYSTEM:

Here is my analysis of the Orthographical Verifier (aka Spell
Checker):

Subsystem that detects incorrections:
 * Check if the word exists in the user's exception dictionaries.
    > If so, mark the word incorrect, otherwise go to next step.
 * Check if the word exists in the user's additional words.
    > If so, mark the word correct, otherwise go to next step.
 * Check if the word exists in MySpell.
    > If so, mark the word correct, otherwise mark the word incorrect.

Subsystem that handles recommendations:
 * Check if the incorrect exists in the user's exception dictionaries.
    > If so, recommend the user's recommendation for the user's
      exception.
 * Upload user dictionaries to MySpell.
    > I know that this feature is unimplemented.
    > Technical issues such as dictionary caches will not discussed
      here.
 * Call MySpell for recommendations for the incorrect spelling. 
 * Filter out all user's exceptions from MySpell's recommendations.
    > OpenOffice.org lacks this step!
    > If the "MySpell" does not support uploaded dictionaries,
      OpenOffice.org's recommender should filter out user exceptions
      from the Myspell's recommendations.

I hope that you can understand what I am expecting with the
OpenOffice.org's recommendation subsystem.



Someone has mentioned that I can create my very own MySpell
dictionaries. Where can I get these tools. Can I use them without     
having the entire OpenOffice.org build on my system? I want to create 
my own customized English and Esperanto(*) vocabularies for use with  
OpenOffice.org

(*) Until OpenOffice.org supports this language, I have to maskerade
this language as another but supported language.
Comment 4 thomas.lange 2002-01-29 09:52:35 UTC
Nothing new...
(text needed in order to acceopt issue)
Comment 5 royalozma 2002-01-29 13:48:35 UTC
I have managed to work around much this issue using Kevin's MySpell
tools, and create my own personal dictionaries for use with
OpenOffice.org

* - * - * - * - *

Can you tell me what is the badly needed text that is required for the
issue to be totally accepted.
Comment 6 thomas.lange 2003-02-14 15:50:17 UTC
Fixed in CWS apps01.

Files changed:
linguistic:
  spelldta.hxx  1.1.1.1.50.1
  spelldta.cxx  1.1.1.1.50.1
  spelldsp.cxx  1.10.40.1

TL->MRU: please check the basic functionality of user-dictionaries in 
respect to spellchecking.
Comment 7 thomas.lange 2003-02-19 09:04:44 UTC
.
Comment 8 thomas.lange 2003-02-19 09:05:08 UTC
.
Comment 9 thomas.lange 2003-02-19 09:05:35 UTC
.
Comment 10 michael.ruess 2003-02-20 10:58:05 UTC
Verified the fix with internal build CWS_apps01.
Fix will be available with OpenOffice 1.1 Beta.
Comment 11 michael.ruess 2003-02-22 12:06:28 UTC
Checked integration with internal Milestone srx644m4s3.
Comment 12 michael.ruess 2003-02-25 12:18:45 UTC
Reopened issue. Due to a bad side effect, the fix will be taken back
from OO 1.1 Beta and newly intregrated in OO 1.1 Beta 2.
Comment 13 michael.ruess 2003-02-25 12:19:16 UTC
Reassigned to TL for fixing.
Comment 14 thomas.lange 2003-03-07 13:34:29 UTC
Fixed in CWS os6.

Files changed:
linguistic:
  spelldsp.cxx 1.10.42.1
Comment 15 thomas.lange 2003-03-17 15:14:08 UTC
.
Comment 16 thomas.lange 2003-03-17 15:16:04 UTC
TL->MRU: Please check.
Comment 17 michael.ruess 2003-04-01 09:21:50 UTC
Checked in CWS os6. 
Comment 18 michael.ruess 2003-04-01 09:22:35 UTC
Fix will be included in OO 1.1 Beta2.
Comment 19 michael.ruess 2003-05-14 08:43:53 UTC
Closed.