Issue 35009 - XSLT filter shall run with Java 5
Summary: XSLT filter shall run with Java 5
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: external filters (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 1.1.5
Assignee: jogi
QA Contact: issues@xml
URL:
Keywords:
Depends on: 36351 38324
Blocks:
  Show dependency tree
 
Reported: 2004-10-05 13:54 UTC by svante.schubert
Modified: 2005-06-30 12:49 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description svante.schubert 2004-10-05 13:54:44 UTC
The XSLT filter, part of the optional 'sample XSLT filter' setup component, have
to be adapted to run with Java 5.
Comment 1 svante.schubert 2004-10-06 14:36:57 UTC
Correct SO7 PP4 flag?
Comment 2 jogi 2004-10-06 14:47:54 UTC
JS: Target is 1.1.4; 1.1.3 has been just released :-)
Comment 3 svante.schubert 2004-10-07 01:41:35 UTC
Status XSLT filter using Java 5:
-Docbook import & export smoke test passed
-SpreadsheetML import passed
-XHTML import (Exception during compiling stylesheet)
Fix: To change as little as possible to the environment of the office, mapped
the current state of XHTML filter into the exisiting file structure
Test: No further exception, but massive data loss due to XSLTC issue (works fine
with Xalan). Issue triggered by calling a template within a variable.
Added multiple workarounds for this issue, but in case of recursion we are quite
lost (e.g. tables). Nearly no table output with XSLTC
Tried to address XALAN, but no second XSLT processor in Java, they removed XALAN.
Possible solutions: Massive work impact on workaround or wait for Java 5 patch
or shipping with Xalan. Works fine with Xalan2.0 even under Java5, but not with
the build in XSLTC processor.

-WordML import (Exception during compiling stylesheet)
Fix: To change as little as possible to the environment of the office, mapped
the current state of Wordml import filter into the exisiting file structure. 
Fixing namespace problems, which even blocked Xalan 2.0. Nevertheless without
effect. Works fine with Xalan2.0 even under Java5, but not with the build in
XSLTC processor.
Possible solutions: Massive work impact on workaround or wait for Java 5 patch
or shipping with Xalan. 

Fixes of this task has been checked in, further progress have to be coordinated
with management and should be addressed as follow up tasks.

Comment 4 svante.schubert 2004-10-07 01:43:46 UTC
reopen, obviously I have to move it first to QA and change status afterwards...
Comment 5 svante.schubert 2004-10-07 01:44:33 UTC
To QA
Comment 6 svante.schubert 2004-10-07 01:45:52 UTC
Fixed
Comment 7 svante.schubert 2004-10-07 02:44:05 UTC
Tested under WindowsXP
Comment 8 svante.schubert 2004-10-07 19:04:22 UTC
Wrote an Java 5 issue concerning the wordml filter:
Synopsis: Compilation of StarOffice wordml XSLT filter via XSLTC throws exception
http://bt2ws.central.sun.com/CrPrint?id=6175602

Furthermore, wrote the developer directly, by some chance I might get
information for a workaround for the wordml stylesheet tomorrow.
Comment 9 jogi 2004-10-08 08:57:41 UTC
Too many problems around. I don't think that this solution is okay for a PP.
Comment 10 jogi 2004-10-08 08:58:11 UTC
Re-Assigning to sus.
Comment 11 svante.schubert 2004-10-08 10:31:10 UTC
In the release meeting it will be discussed if XALAN 2.0 will be bundled with
the Office. Aside of adding the JARS, we should change the java.ini, not only by
mentioning these new JARS, but loading them before the usual Java path. This
would have certainly no advantage against Java 5, where it would be sufficient
to add these to the class path as no othe XALAN has been integrated, but the
internal Java 1.4 version of Xalan would be outmanoevered only by the adding the
following line to java.ini:
-Xbootclasspath/p:<xalan-jars-path>

Many issues have been fixed in Xalan 2.0 so the filter output will be a lot
better than before.
Comment 12 thorsten.ziehm 2004-10-15 09:30:26 UTC
Due to pressure of time, it was decided to shift this task to OOo 1.1.5.
In OOo1.1.4 we have to live with the restriction and Java 5. To work around this
problem OOo 1.1.4 should use still Java 1.4.2.
Comment 13 svante.schubert 2004-10-18 13:55:31 UTC
This task is blocked / depends on a task of Martin Hollmichel to clarify the
possible integration of Xalan into SO7.
Comment 14 svante.schubert 2004-10-29 15:01:16 UTC
In need of the integration of Xalan to fix this issue.
Comment 15 svante.schubert 2004-11-26 15:18:11 UTC
- Added Xalan module to srx645
- Added dependency in filter module to Xalan module
- Added Xalan jars to manifest of XSLTFilter.jar (will be used and loaded by
XSLT filter only)
- Added Xalan jars to scp-so
- wrote mail to RE (release engineer) for adding module to SRX645
Comment 16 svante.schubert 2004-12-02 13:35:23 UTC
Classloading does not work as in SO8. Java.ini / javarc have to be adapted for
classpath.
Depending task added.
Comment 17 svante.schubert 2005-04-19 16:11:20 UTC
Will work after 38324 is fixed -> set to fixed
Comment 18 lo 2005-05-13 11:09:20 UTC
reopen and self transfer because of xalan memory leak

re-open issue and reassign to lo@openoffice.org
Comment 19 lo 2005-05-13 11:09:35 UTC
reassign to lo@openoffice.org
Comment 20 lo 2005-05-13 11:09:40 UTC
reset resolution to FIXED
Comment 21 lo 2005-05-13 11:35:50 UTC
implemented and tested caching machanism for transformations in
XSLTransformer.java, reassigning to svante

re-open issue and reassign to sus@openoffice.org
Comment 22 lo 2005-05-13 11:35:55 UTC
reassign to sus@openoffice.org
Comment 23 lo 2005-05-13 11:36:00 UTC
reset resolution to FIXED
Comment 24 svante.schubert 2005-05-31 16:27:05 UTC
Ready for QA

re-open issue and reassign to jsi@openoffice.org
Comment 25 svante.schubert 2005-05-31 16:27:15 UTC
reassign to jsi@openoffice.org
Comment 26 svante.schubert 2005-05-31 16:27:21 UTC
reset resolution to FIXED
Comment 27 jogi 2005-06-08 14:13:29 UTC
Tested and error free is the DocBook Load/Save test with Java 5. (Update 03) and
Java 1.4.2.
Comment 28 jogi 2005-06-30 12:49:53 UTC
Works fine on all platforms with _03.