Issue 35363 - Undo text editing let crash office
Summary: Undo text editing let crash office
Status: CLOSED DUPLICATE of issue 32921
Alias: None
Product: Draw
Classification: Application
Component: editing (show other issues)
Version: 680m56
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-12 12:54 UTC by lars.langhans
Modified: 2004-11-05 07:37 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description lars.langhans 2004-10-12 12:54:38 UTC 
Create a new draw (Menu->New->Draw), insert some text and press C-z (undo) more
than once, crash report will open and ask for sending...

Broken = Yes, because it works in SO7.
Comment 1 clippka 2004-10-12 16:47:15 UTC 
Michael, you asked for xml only issues. This one happens because on export the
style name for transparency gradients gets encoded as it is a XML_TYPE_STYLENAME
type. The transparent gradient itself is correctly loaded and its encoded name
with display name is added AddStyleDisplayName() to the importer. But the
attribute at the property style is directly set at the API. It should be decoded
with GetStyleDisplayName() first, but I'm not sure when this should happen. Also
it looks like you added the MID_FLAG_NO_PROPERTY_IMPORT to this and other
properties. Why is that?
Please take over.
Comment 2 clippka 2004-10-12 16:50:37 UTC 
Sorry, wrong issue. Please all ignore my last comment
Comment 3 clippka 2004-10-12 17:20:59 UTC 
The crash happens only if a text shape is used.
- Create text shape
- add text

now without leaving the text edit mode, press ctrl+z twice.
The first undo action also deletes the text object, the second undo
action crash because it still used the deleted SdrObject.

Armin, please have a look a this, I'm not sure what changed in
text and undo handling in svx that caused this behaviour.
Comment 4 Armin Le Grand 2004-10-26 14:43:40 UTC 
AW: Nothing has changed in SVX undo handling. But what happens is: The Undo of
the Insert Text Frame removes the object and does a ModelChange. The ModelChange
triggers a EndTextEdit, which itself adds an UNDO action for text edit. The 2nd
undo then undoes a text edit on a deleted text object.
I compared with SRC645 (SO7) and there, when the EditEngine is active, the
Undo-Stack of the EditEngine is there, so tehre is no Undo action for instert
text frame, but only for text editing. So it seems more that for some reason the
own Undo-Stack for text editing is no longer used ?!? Investigating...
Comment 5 Armin Le Grand 2004-10-26 16:08:00 UTC 
AW: investigation with Framework team shows that setting the UndoStack using the
code in View::BegTextEdit and View::EndTextEdit in sd is just luck. Checking
with AF shows that the shell hierarchy has changed in his current version,
avoiding this crash. So i will send this onew to AF as double (and fixed, then)
and write another one concerning changing both mentioned methods and to call a
EndTextEdit when the shell containing the OutlinerView loses the focus.
Comment 6 Armin Le Grand 2004-10-26 16:15:39 UTC 
AW->AF: This one is double to a fixed one in Your CWS. There is a follow-up task
(#i36150#) created for remaining issues.
Comment 7 groucho266 2004-11-04 16:40:20 UTC 
Fixed by issue 32921: the shells were pushed in the wrong order onto the shell
stack.

*** This issue has been marked as a duplicate of 32921 ***
Comment 8 wolframgarten 2004-11-05 07:37:11 UTC 
Closed.