Apache OpenOffice (AOO) Bugzilla – Issue 36518
Gnome and KDE icons for OOo
Last modified: 2006-02-16 12:38:22 UTC
Now when the icons are stored in images.zip, it would be fine to have the possibility to have KDE icons in the KDE session, and Gnome icons in the Gnome session ;) There are efforts to standardize the location and lookup of the icons (http://freedesktop.org/Standards/icon-theme-spec), and even the names of them (http://freedesktop.org/pipermail/xdg/2004-October/005084.html) which could probably bypass the use of images.zip in Gnome and KDE some day. I am afraid it is a long-term task, so we need a temporary solution. Please have a look at the patches I am going to attach. They introduce --with-gnome-icons= and --with-kde-icons= configure switch; the parameters are zips with the respective icon sets, e.g. from http://ooo.ximian.com/packages/SRC680/ (incomplete development versions!). The rest of the patches makes use of images_\(gnome\|kde\).zip. It is intentional that _gnome or _kde versions are expected just in the system-wide configuration directory (<OOo>/share/config), not in user's configuration (~/.OpenOffice.org1.9/user/config); I do not think it makes sense that user sets her own 3 icon sets.
Created attachment 18843 [details] Configuration switches for Gnome and KDE icon sets.
Created attachment 18844 [details] Copy the Gnome and KDE icon sets to the installation set.
Created attachment 18845 [details] Install Gnome and KDE icon sets.
Created attachment 18846 [details] Make use of the Gnome and KDE icon sets in vcl.
Created attachment 18847 [details] Make use of the Gnome and KDE icon sets in xmlhelp.
cp->ka: please have a look, you are the master of images.zip ;-)
.
verifying the patches
Created attachment 18890 [details] Update of the patches for m60 (instsetoo_native).
Created attachment 18891 [details] Update of the patches for m60 (config_office).
The rest seems to apply fine against m60...
I verified the patches and didn't find any errors so far. So, I'm fine with applying those patches to an appropriate CWS. Kendy, could you manage handling the appropriate CWS, please.
reassigned to Kendy for further handling of CWS.
This should prolly wait until we have up-streamed cws 'industrial01'
I guess a "ping" is appropriate.. AFAIK there already was such a cws industrial01 that has already been integrated.. Just to make sure you don't forget about this one :-)
Right - so we have much of the artwork integrated; and Kendy will (I hope) be working on getting the various infrastructural theming pieces we need up-stream soon.
So, I have an updated version of the icon theming. I'll post the patches here (in the order they have to be applied) for a review. It would be great to get this into 2.0---as long as the Industrial set is already in the OOo CVS, and I'd like to commit the Crystal icons there as well (when I assure that the designers have signed JCA, etc.) ka: Could you have a look, please? The following patches obsolete icons-vcl-according-to-desktop.diff and icons-xmlhelp-according-to-desktop.diff. Thank you very much in advance. (I'm off until Monday, so please be patient if I do not answer quickly enough...)
Created attachment 27202 [details] Cleanup of some cut'n'paste from CWS oooicons.
Created attachment 27203 [details] Implement the icon switching in framework.
Created attachment 27204 [details] Implement the icon switching in svtools.
Created attachment 27205 [details] Implement the icon switching in vcl.
Created attachment 27206 [details] Implement the icon switching in xmlhelp.
Created attachment 27207 [details] GUI for the icon switching (please check also my German there ;-) ).
Created attachment 27208 [details] Saving of the state (officecfg).
Created attachment 27209 [details] Saving of the state (svtools).
I took a first look at your patches and consider them to be ok. Nevertheless ,I'm in doubt if we should apply such a huge patch for OOo 2.0. There seems to be some risk to introduce side effects not obvious (even after review) at the moment. I suggest that you create a CWS first and add your patches appropriately. QA could then take a closer look at the CWS.
So, I've committed all the needed patches to 'iconswitching1' CWS. I'll have to do few more things there (mostly configure-related), and try a complete rebuild.
I forgot: Who to fill as the 'QA representative' in EIS, please?
I've successfully built the iconswitching1 CWS => FIXED.
I have succesfully built m121 on both Linux Intel and Mac OS X using crystal theme. using two patches I cannot attach yet, because we're not sure about license of some icons. I can modify "on the fly" the icons set between automatic, industrial, high contrast and crystal, using both kdeplugin and gtkplugin. Verified on both Linux Intel and Mac OS X (10.4 aka Tiger) My changes are the same as the one present in iconswitching1 Thank you very much for your work, kendy !
Created attachment 28263 [details] one screenshot using crystal+kdeplugin
Created attachment 28264 [details] screenshot using gtkplugin+crystal icons on Mac OSX (m121)
Resetting: - Issue type to FEATURE, for it brings a lot of new stuff into OOo (especially UI changes) - Status to NEW because of missing approved spec (http://specs.openoffice.org/ui_in_general/icons/icon-theme-switching.sxw) CWS should be reassigned to owner but I have no writes to do it. re-open issue and reassign to mmeeks@openoffice.org
reassign to mmeeks@openoffice.org
reset resolution to FIXED
reopen
Punting to 2.0.1 as per Kai's worries wrt. the invasiveness - and the ongoing patheticly debilitating nature of the specification process.
added myself to CC
Fixed in CWS iconswitching1. The package for testing is here: http://www.go-oo.org/tstooo/iconswitching1-m135/
md: re-targeted to 2.0.2 according to CWS
Just for the record, here's an updated package: http://www.go-oo.org/tstooo/iconswitching1-m141/ (There were some changes in m140 that could make problems during integration.)
TM->mmeeks: please verify this issue. Verification is needed for approving the cws.
Thorsten, please take over this issue and take necessary steps to verify it. Thx. re-open issue and reassign to tm@openoffice.org
reassign to tm@openoffice.org
checked and verified in cws iconswitching1. Child-tasks have been verified by every single application qa-team.
Now that the CWS is in the 'VERIFIED' state, you do not need the verification from mmeeks, right? But if you do, I can provide it instead of him for this CWS ;-) And in fact I did that already - everything was fine from my point of view => VERIFIED.
closed