Apache OpenOffice (AOO) Bugzilla – Issue 37136
Bold text not imported properly
Last modified: 2006-11-10 17:41:13 UTC
In the attached PowerPoint presentation, slide 3, bold text is imported as regular weight text. See the first two lines of the 3-bullet group, and the left portion of the third line of that group.
Created attachment 19258 [details] Example PPT presentation - see slide 3 for misimported bold text
Created attachment 19259 [details] Slide 3 as it appears in PowerPoint
Created attachment 19260 [details] Slide 3 as it appears in Impress
Reproducible. Another powerpoint import problem. Reassigned to Sven.
accepted
Sven, have you had a chance to look at this yet?
Not yet, but I hope to be able to fix this issue soon.
ayaniger -> sj: I've seen that if a string is in a bold font, and it has mixed Hebrew/English text, the English is imported as bold, and the Hebrew is not. If there's still work to be done on this issue, perhaps I can help. (In any case, I want to become more familiar with the Impress code, particularly the PPT import code.) Could you tell me where to look to find where the font weight is set, so I can check why there's a difference between Hebrew and English?
The code which is responsible for bold characters can be found in svx/source/svdraw/svdfppt.cxx I think the problem will be in PPTParaSheet::Read or in PPTStyleTextPropReader::PPTStyleTextPropReader In general a single unknown property leads to problems to parse further outstanding properties.
ayaniger->sj: I created two simple presentations, each with a 4-char bold text object, one in Hebrew, one in English. The English text was displayed as bold, but the Hebrew wasn't. But from what I see, the import of the Hebrew document's properties is OK. I added trace statemnts in PPTParaSheet::Read and in PPTStyleTextPropReader::PPTStyleTextPropReader, and I didn't see any differences relating to bold char properties. In both cases, when the following call stack was executed: SdrPowerPointImport::ReadObjText ImplSdPPTImport::ApplyTextObj SdrPowerPointImport::ApplyTextObj PPTPortionObj::ApplyTo PPTPortionObj::GetAttrib, I get to the case of PPT_CharAttr_Bold in the switch statement, once for each document. Doesn't this indicate that the Hebrew is in fact recognized as bold? If so, where might I look next to find the problem?
sj->ayaniger: While investigating the problem I found the solution, the PPT import does not set the SvxPostureItem and SvxWeightItem for Asian and Complex languages . This issue has been fixed now in svdfppt.cxx -r1.142.28.1 cws[impress109].
sj->cgu: this issue is ready to be verified in cws[impress109]
CGU: Verified in cws impress109
*** Issue 15928 has been marked as a duplicate of this issue. ***
CGU: Integrated in OOE680m1
The fix seems to be incomplete, as it has created a new problem. In the first slide of the sample document, the lower text gets cut off during the slideshow. It displays properly if text is not bold. See screenshots.
Created attachment 40452 [details] Text in normal view
Created attachment 40453 [details] Text in slide show (cut off)
Created attachment 40454 [details] Pared-down version of the first sample doc. Used to create screenshots
CGU: integrated in src680m193
I can reproduce the second behaviour but this is a new bug. I write a new issue for the new bug.
I close the issue.
I wrote 2 following issues for this. issue 71432 and issue 71433