fs->cj: We once talked about this, and you asked for an issue so you can place
it in your queue :).

Strictly, we have two issues here: The missing focus indication (which is an
accessibility and usability problem), and the shape's mark handles not being
hidden when the document view is not focused. Not sure if you want to deal with
the latter in a separate issue.

re-targeted to OOo 3.0

Retargeted to 2.x

set target to 3.0

Moved to target OOo 3.x

MT->CJ: Please define 
a) How to get a better perceptible focus
b) If or if not to hide the handles in the drawing page when that page doesn't
have the focus

OOo 3.2

Frank please take over. Thank you :-)

Please take over. Thank you!

a) enlarge the frame size of selected slide about one pixel if an object get
selected
b) object loose handles when a slide get selected

@clu: Please be more specific (maybe with the help of a spec?)

regarding a): there seems to be an error here,  probably the selection of slides
in in the slide sorter bar should become less notable when an object in the edit
view is selected, not more.

@af: regarding a): sorry, my foult :(

a) enlarge the frame size of selected slide(s*) about two** pixel after they get
selected -> if f.e. an object (shape) get selected, the frame size switch back
to normal style
b) object loose handles when a slide get selected

* multiselection -> all selected slides get the larger frame
** after drawing it, two pixel more looks much more 'eye catching' than only one

p.s. hc -> larger frame also visuable in hc mode (no further solution needed)


attached picture: 

slide 1 is the new larger selection (two pixel thicker than current frame)

as comparison:
slide 2 is the normal (current) selection
slide 3 is the 'mouse over'(current) selection


@af: p.p.s. hope this helps .. else it must wait until i am back from vacation

Created attachment 64094 [details]
attached picture

Did not follow this issue so far, but now came back to it after Andre asked me
to have a look into implementing it. Well, I have a few problems:

For one, in a current build (DEV300.m54), the border around the selected
slide(s) is already pretty thick, and looks much darker and thicker than the one
in the attached screen short. So, I am not sure whether this is my desktop theme
only, or if this has been fixed meanwhile? In the first case, we need a better
specification, since if the border is dependent on the theme, then "just make it
bigger" is not a good specification of what to do.

Second, the suggestion does not care for the very original problem: no visual
feedback whether the page pane is *focused*. That is, if I understand it right,
then it says we should just make the border around the selected slides thicker
(see above) and de-select all objects in the document window. However, this
still means that the user cannot distinguish a focused page pane from a
non-focused page pane. In particular, if no object is selected in the document
window, then the user doesn't know whether pressing the "Delete" key will do
nothing (when the focus is in the document) or remove the selected slide(s).

Third, I am not sure at all that un-selecting the objects in the document view,
when a slide gets selected, is a good idea. Not to mention "a slide gets
selected" is not a sufficient description (how, for instance, does focusing the
page pane via F6, or de-selecting a slide while the page pane still has the
focus, play together here?). If we start with that change here (I know I
suggested it myself above, but ...), where should we stop? Should the objects
also be de-selected when a slide is selected from the Tasks/Layouts pane? For
consistency reasons, they should.


Bottom line: I do not think the proposed changed addresses the original problem,
and I do not think that the proposal is mature enough, as it yields additional
(consistency) problems/questions. The second point would not necessarily hinder
me in implementing a change (who am I to doubt UX? :) ), the first, however,
actually does.

Playing more with it: The page pane actually *has* a focus rect, which is just
not shown when you click a slide with the mouse.

That is, try the following with a doc with 5 or so slides: Click into the page
pane, then repeatedly press TAB. You'll notice that a small dotted frame appears
around, which cycles through all available slides. Then, click into the
document, and the frame disappears.

So, there *is* a visual indication that the pane has the focus, it is just not
enabled when you focus the pane with the mouse. This should be fixed.
Also, the indication should be made somewhat more obvious, as it currently is
not discernible when painted around a selected slide.

The fact that the focus indicator (dotted frame) is only visible after moving
the focus via keyboard into the slide sorter bar is feature not a bug.  The
behavior once was different but was changed on express request by UX.

Now that's cool. A focus indicator which has been removed on UX request? Whereas
this issue here requests exactly this: a focus indicator?

/me is confused. Either we fix this issue here, which implies reverting the
reversal (no matter if we use the existing focus indicator or invent a new one).
Or this reversal was rightfully, then this issue here is not fixable.

Created attachment 64532 [details]
suggested patch

The attached patch implements the following changes:
- In FocusManager::FocusPage, a check is made whether the slide sort currently
  has the focus, and if so, ShowFocus is called (if the focus is not currently
  shown). This ensures that if the focus is in the slide sorter, and there is
  any focused page, this is also visualized.
- The SdPageObjectFocusPrimitive, responsible for rendering the focus
  primitive, is modified as follows:
  - Instead of using a 1-pixel stroke, a 3-pixel stroke is used
  - Instead of painting the stroked line black on white, it is painted
    - "menu highllight text color" on "menu highlight color" (i.e. your
      theme's colors for selected menu text is used) for selected slides
    - "window text color" on "window color" (also taken from the theme)
      for unselected slides
  This is an improvement insofar as previously, for selected slides, the focus
  stroke line was always rendered black on white, with the mentioned
  1-pixel stroke, which effectively made the focus rect invisible for a
  selected slide if the theme's "menu highlight color" (used to render the
  slide's selection frame) was sufficiently dark.
  Now, the focus rect for selected slides should always be discernible,
  otherwise chances are good that already your system's desktop theme is
  broken.

fs->af: your's to review ...

Created attachment 64533 [details]
suggested patch

oops, the first version of the patch still had a wrong color used (the focus
rect for unselected slides used the "menu selection color" instead of the
"window text color").

Created attachment 64540 [details]
yet another patch

fs->aw: The latest patch also fixes the problem that the focus rectangle was not
shown when you focused the slide sorter by means other than clicking a slide
with the mouse.

since clu asked to put a short and concise summary of the changes herein:

With the patch, the situation is as follows: If (and only if) the slide sorter
has the focus, then (exactly) one slide in the slide sorter is surrounded by a
stroke line. This stroke line (no matter whether on a selected (framed) slide or
not) is always visible, since it uses the desktop theme's colors.

Have applied the patch.

@es: Please verify.

Verified in CWS impressaccessibility3

.

Fixed and integrated => closing now..