Apache OpenOffice (AOO) Bugzilla – Issue 51656
Add resizeable margin on page preview
Last modified: 2013-08-07 15:15:24 UTC
please Add resizeable margin on page preview. so we can easily formating the documents when we need to print. look at the excel which have this feature
Created attachment 27754 [details] margin resizeable on excel
one for requirements
*** Issue 54344 has been marked as a duplicate of this issue. ***
Hello ALL, What is the situation of this new feature? Where can I have the Specification? Our team(RedOffice Team)have written a Specification and want to implement this new feature.Any one can give me some useful information?
LiuTao, Gao Zemin (of your team) announced to start with this feature. Is it the same effort? You can add the spec as an attachment to this issue, or start a wiki page.
LiuTao->nn :yes,of course.It is the same effort. I will start a wiki page ASAP.
Created attachment 44195 [details] It is the specification for the design, please take a look at it
Hi Matthias, please have a look at the attached Specification. Frank
Created attachment 44532 [details] the patch for the SC resizeable margin in Sc page preview
Please always make diffs against the revisions that you actually edited, and use some consistent indentation. Some observations: - Instead of the TWIPS_PER_PIXEL define, you should use OutputDevice's PixelToLogic method, to avoid small inaccuracies. - The column handles look quite irregular because they're not aligned to pixel boundaries. They don't take a printing scale into account (this is also true for the header size), and they don't handle hidden columns. - The should be some kind of feedback while dragging one of the lines. But, before all of this, has it been decided yet if we want something ruler-based instead?
Created attachment 50529 [details] The patch is about page margins!
The patch is for SC only or also for others ? such as writer ? I hope we can have one patch for all. Thanks
Created attachment 50753 [details] The patch file is about page margins!
Hello Niklas, Please have a look at the patch file,thanks!
The new patch looks better. There are still some problems: - Simple print scaling works now, but not "Fit print range(s) on number of pages". - ScPrintFunc::GetRange doesn't skip empty pages (the problem mentioned by yunjingtao on IRC last week). - Right-to-left sheet orientation doesn't work.
One more: Repeated columns don't work either. Maybe it's better to use ScPreviewLocationData (now used for the accessibility API) instead of re-implementing all these options in ScPrintFunc::GetRange.
Created attachment 51129 [details] The patch file is about issue51656#.
Hello Niklas, Please review the latest patch,I'm fixing that when nNewColWidth is negative.When I finished it,I will commit the other patch.thanks!
The handles look much better now. "Scale to pages" also works. If there are repeated columns, only the following columns have handles, but I think that's ok. Only right-to-left still doesn't work completely. Frank from the User Experience team agreed to the look of the feature, so if the few remaining problems are solved, we can integrate it soon.
Created attachment 51247 [details] The patch file is about i51656#.
Hello Niklas, I just have finished "Reduce/enlarge printout" problem,when dragging the page changes into several pages that also have finished,I will commit it tomorrow.
Created attachment 51302 [details] patch-i51656#(v5)
reassigning to myself
The feature is on CWS "pagemargins".
back to QA for verification
Created attachment 51472 [details] TestCaseSpecification
verified in internal version cws_pagemargins
Please find the final spec here: http://specs.openoffice.org/calc/features/Page_Margins_Specification.odt
Tested margins in m247 (Pavels Build) and found 2 issues. 1. The Word margin is not (yet) translated. 2. Changing margins don't raise the "File changed" flag.
*** Issue 11395 has been marked as a duplicate of this issue. ***
Verified in OOo310m9 on WinXP and Fedora9 Closing Li Meiying