Issue 53533 - Lost of mark for selected autofilter after ESC
Summary: Lost of mark for selected autofilter after ESC
Alias: None
Product: Calc
Classification: Application
Component: viewing (show other issues)
Version: OOo 1.1.4
Hardware: All All
: P4 Trivial (vote)
Target Milestone: ---
Assignee: frank
QA Contact: issues@sc
: 67395 83980 88353 (view as issue list)
Depends on:
Blocks: 72764
  Show dependency tree
Reported: 2005-08-19 10:38 UTC by nielsh
Modified: 2013-08-07 15:14 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Test case (6.58 KB, application/vnd.sun.xml.calc)
2005-09-05 05:12 UTC, swu
no flags Details
53533.patch (339 bytes, text/plain)
2007-09-06 03:34 UTC, gaozm
no flags Details
53533(2).patch (381 bytes, text/plain)
2007-09-07 08:58 UTC, gaozm
no flags Details
issue 53533.patch (392 bytes, text/plain)
2007-10-26 10:14 UTC, gaozm
no flags Details
issue 53533(4).patch (349 bytes, text/plain)
2007-11-01 07:25 UTC, gaozm
no flags Details
issue 53533(5).patch (824 bytes, text/plain)
2007-11-08 02:39 UTC, gaozm
no flags Details
issue 53533(6).patch (830 bytes, text/plain)
2007-11-09 05:57 UTC, gaozm
no flags Details
issue 53533(7).patch (700 bytes, text/plain)
2007-11-12 03:07 UTC, gaozm
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description nielsh 2005-08-19 10:38:47 UTC
If I set a autofilter and select a option, the dropdown-arrow in the active
autofilter is marked with a another color (default blue). Now I open the
dropdown of this filter again and press Esc. After that I lost the blue color
(default black) but the filter is still active. It´s very difficult to find this
active filter now.
Comment 1 swu 2005-09-05 05:04:11 UTC
We managed to replicate the issue on a PC using Windows XP Pro SP2, OpenOffice
Build 1.9.125 language English, and MAC OS 10.3, OpenOffice build 1.1.2 and Neo
Office /j 1.1

We managed to replicate your issue.

Test Instructions

1)	Open a new OpenOffice spreadsheet (Calc)
2)	Input “Test†into A1
3)	Input values 1-14 into A2:A15
4)	Select A1:A15
5)	From top menu select Data->Filter->AutoFilter
6)	Click on the arrow on the right side of A1 and selected top 10
7)	Rows 2-5 become hidden (this is expected behavior), the arrow on the right
side of A1 changes color to blue (implying the filter is active)
8)	Click on the arrow on the right side of A1 
9)	The arrow changes to the color black
10)	Press ESC
11)	The filter is still active
12)	The arrow stays black (which to our understanding means that the filter is
not active), when it should have changed back to blue (or never changed to black
in step 8)

Additional testing:

13)	Save the document (with the arrow as black but with filter active)
14)	Close Calc
15)	Open saved file
16)	Now the arrow is colored blue (distinguishing the filter as active)

Our additional testing showed a workaround for the problem.
Save and load the spreadsheet and the actively filtered columns will be
correctly colored.

This issue may create some confusion to the user, on whether or not the filter
is active but for all intensive purposes this issue is not critical, but should
be fixed to clarify the user interface. 

Steve Wu and Jacek Leowski
Comment 2 swu 2005-09-05 05:12:21 UTC
Created attachment 29315 [details]
Test case
Comment 3 frank 2005-09-15 12:15:34 UTC
Hi Niklas,

one for you I think.

Comment 4 nielsh 2005-10-08 18:57:02 UTC
This bug you will find in V2.0 too.
Comment 5 delorea 2006-07-16 20:32:26 UTC
*** Issue 67395 has been marked as a duplicate of this issue. ***
Comment 6 norbert2 2006-10-03 19:30:47 UTC
It would be great to have this bug targeted to OOo 2.x.
Comment 7 gaozm 2007-09-06 03:34:41 UTC
Created attachment 47997 [details]
Comment 8 niklas.nebel 2007-09-06 13:52:07 UTC
Invalidating the whole window is a bit extreme. It's unnecessary to paint so
much, and the button will still be visible black for a short while.

Either draw the button with the right state (see
ScGridWindow::HandleMouseButtonDown), or invalidate only the button area, but
then instead of drawing it directly.
Comment 9 gaozm 2007-09-07 08:58:47 UTC
Created attachment 48036 [details]
Comment 10 gaozm 2007-10-26 10:14:00 UTC
Created attachment 49174 [details]
issue 53533.patch
Comment 11 niklas.nebel 2007-10-29 18:30:59 UTC
That would add a coplete repaint to every ReleaseMouse call for any window.
That's worse than the first patch.
Comment 12 norbert2 2007-10-29 21:42:05 UTC
The following has nothing to do with this issue, but it is about the same
problem: Missing/bad indication if filter is applied: Issue 66663
Comment 13 gaozm 2007-11-01 07:25:12 UTC
Created attachment 49304 [details]
issue 53533(4).patch
Comment 14 niklas.nebel 2007-11-05 14:15:32 UTC
1. The last patch doesn't apply to recent versions (2.3 or newer).
2. Again, it introduces repaints in unrelated situations.

If Invalidate is used, it should be only in those cases where
"aComboButton.Draw( FALSE )" was called before, and only for the pixel area of
the button.
Comment 15 gaozm 2007-11-08 02:39:56 UTC
Created attachment 49512 [details]
issue 53533(5).patch
Comment 16 niklas.nebel 2007-11-08 10:15:10 UTC
Drawing the button with the right flags is good, but using the position from the
mouse event doesn't work if the mouse was moved between the button-down and
button-up event. The position should be taken from pFilterBox instead.
Comment 17 gaozm 2007-11-09 05:57:38 UTC
Created attachment 49544 [details]
issue 53533(6).patch
Comment 18 niklas.nebel 2007-11-09 09:45:51 UTC
I meant ScFilterListBox stored column and row position. GetPosPixel is always
(0,0), the position within the floating window.
Comment 19 gaozm 2007-11-12 03:07:42 UTC
Created attachment 49587 [details]
issue 53533(7).patch
Comment 20 niklas.nebel 2007-11-13 13:48:17 UTC
The last patch is good and is now in CWS "calc45" (gridwin.cxx
Comment 21 frank 2007-11-26 15:15:59 UTC
*** Issue 83980 has been marked as a duplicate of this issue. ***
Comment 22 niklas.nebel 2007-12-03 15:24:16 UTC
back to QA for verification
Comment 23 frank 2007-12-07 14:48:04 UTC
found fixed on cws calc45 using Solaris, Linux and Windows build
Comment 24 frank 2008-02-11 11:27:19 UTC
found integrated on master OOHm5 using Solaris, Linux and Windows builds
Comment 25 frank 2008-04-16 20:17:56 UTC
*** Issue 88353 has been marked as a duplicate of this issue. ***