Apache OpenOffice (AOO) Bugzilla – Issue 55394
incorrect flip if axis not vertical
Last modified: 2022-10-28 12:54:30 UTC
insert some shape (irregular, for example, lightning). enable 'flip' from 'effects' toolbar. move flipping control line slightly so that it is not vertical anymore. flip it. it is flipped incorrectly. when dotted line shows how it will be flipped, it shows the correct position. upon actual flip shape is flipped vertically in addition to requested flip.
Reproducible.
This seems to be depending on custom shapes...
sj: customshapes can be flipped horizontal/vertical only, the possibility to change the flip axis into invalid values needs to be disabled.
Are you sure you want "change the flip axis into invalid values needs to be disabled"? If you want to replace the classical rectangle with a shape rectangle (It seems to me from your comment on issue 47689, that you want this.), than the shape rectangle needs all the features a classical rectangle has and flipping is one of them. BTW the text of a shape rectangle is flipped correctly, but the shape rectangle itself is not flipped at all.
Created attachment 68111 [details] patches for NbcMirror and NbcShear
When flipping is not vertical and not horizontal, nothing special is done, but the inherited NbcMirror is used. This doesn't know anything about fObjectRotation. But such a flipping induces a rotation. I have added a part to update fObjectRotation. (The patch contains the fix for issue 101683 in addition.)
Pardon me, but what's the status on this issue? I'm following this for the fix to Issue 101683. It seems there is a patch/fix here, but I don't see it making any progress to qa or integration.
Hi Armin, the patch is still valid. It is a simple diff, not a "git format-patch", but still applies fine and solves this bug and bug 101683. So please have a look.
ALG: In principle, this is okay. Problem is that this will massively collide with aw080 (where there is no mirror and/or shear at all, only a setTransformation()). Checking how to add carefully... I am also not sure about fObjectRotation, there was something with the extra text rotation...
"alg" committed SVN revision 1420199 into trunk: #55394# Applied patch from Regina to solve mirror problem for CustomShapes
ALG: Okay, slightly adapted, made comments for aw080 and comitted. Works well.
ALG: Done.
adjusted target to version that will contain the fix
Testing AOO400m3(Build:9702) - Rev. 1502185 2013-07-11 08:22:42 (Thu, 11 Jul 2013) - Linux i686 on Fedora 17 Looks great, Effects > Flip of shape (lightning) looks correct with non-vertical axis (tried a few different angles). Thanks!