Issue 55394 - incorrect flip if axis not vertical
incorrect flip if axis not vertical
Product: Draw
Classification: Application
Component: code
PC All
: P3 Trivial (vote)
: 4.0.0
Assigned To: AOO issues mailing list
Depends on:
Blocks: 101683
  Show dependency treegraph
Reported: 2005-10-03 12:43 UTC by richlv
Modified: 2013-07-13 14:30 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

patches for NbcMirror and NbcShear (4.12 KB, text/plain)
2010-03-02 15:35 UTC, Regina Henschel
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description richlv 2005-10-03 12:43:07 UTC
insert some shape (irregular, for example, lightning). enable 'flip' from 
'effects' toolbar.
move flipping control line slightly so that it is not vertical anymore. flip it. 
it is flipped incorrectly.
when dotted line shows how it will be flipped, it shows the correct position. 
upon actual flip shape is flipped vertically in addition to requested flip.
Comment 1 wolframgarten 2005-10-04 07:50:53 UTC
Comment 2 wolframgarten 2005-10-04 07:52:17 UTC
This seems to be depending on custom shapes...
Comment 3 sven.jacobi 2006-04-03 14:54:30 UTC
sj: customshapes can be flipped horizontal/vertical only, the possibility to change 
the flip axis into invalid values needs to be disabled.
Comment 4 Regina Henschel 2009-05-13 16:12:56 UTC
Are you sure you want "change the flip axis into invalid values needs to be
disabled"? If you want to replace the classical rectangle with a shape rectangle
(It seems to me from your comment on issue 47689, that you want this.), than the
shape rectangle needs all the features a classical rectangle has and flipping is
one of them.

BTW the text of a shape rectangle is flipped correctly, but the shape rectangle
itself is not flipped at all. 
Comment 5 Regina Henschel 2010-03-02 15:35:48 UTC
Created attachment 68111 [details]
patches for NbcMirror and NbcShear
Comment 6 Regina Henschel 2010-03-02 15:41:30 UTC
When flipping is not vertical and not horizontal, nothing special is done, but
the inherited NbcMirror is used. This doesn't know anything about
fObjectRotation. But such a flipping induces a rotation. I have added a part to
update fObjectRotation.

(The patch contains the fix for issue 101683 in addition.)
Comment 7 Joe Smith 2010-06-21 20:33:09 UTC
Pardon me, but what's the status on this issue?

I'm following this for the fix to Issue 101683.

It seems there is a patch/fix here, but I don't see it making any progress to qa
or integration.
Comment 8 Regina Henschel 2012-12-09 15:51:22 UTC
Hi Armin, the patch is still valid. It is a simple diff, not a "git format-patch", but still applies fine and solves this bug and bug 101683. So please have a look.
Comment 9 Armin Le Grand 2012-12-11 14:35:03 UTC
ALG: In principle, this is okay. Problem is that this will massively collide with aw080 (where there is no mirror and/or shear at all, only a setTransformation()). Checking how to add carefully...
I am also not sure about fObjectRotation, there was something with the extra text rotation...
Comment 10 SVN Robot 2012-12-11 14:43:13 UTC
"alg" committed SVN revision 1420199 into trunk:
#55394# Applied patch from Regina to solve mirror problem for CustomShapes
Comment 11 Armin Le Grand 2012-12-11 14:43:35 UTC
ALG: Okay, slightly adapted, made comments for aw080 and comitted. Works well.
Comment 12 Armin Le Grand 2012-12-11 14:43:50 UTC
ALG: Done.
Comment 13 2013-07-10 14:57:25 UTC
adjusted target to version that will contain the fix
Comment 14 Joe Smith 2013-07-13 14:30:50 UTC
AOO400m3(Build:9702)  -  Rev. 1502185
2013-07-11 08:22:42 (Thu, 11 Jul 2013) - Linux i686
on Fedora 17

Looks great, Effects > Flip of shape (lightning) looks correct with non-vertical axis (tried a few different angles).