Issue 57209 - xml import and export implementation for custom shapes is katastrophic
Summary: xml import and export implementation for custom shapes is katastrophic
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: code (show other issues)
Version: OOo 2.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-02 14:44 UTC by clippka
Modified: 2017-05-20 10:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description clippka 2005-11-02 14:44:18 UTC 
the custom shape import and export implementation does not check namespaces on
import, it duplicates strings that should be stored in the xml tokenmap of xmloff.

Sven, please contact me for details
Comment 1 sven.jacobi 2005-11-02 18:02:15 UTC 
Can it be that you looked a little too deep into the wine glass ? I understand
many things under the meaning of the term "Katastrophic" but not that strings
are doubled and namespaces are not checked.

I do not need to tell you that we were a little under time pressure when
creating the CustomShapes, so it might be that not everything is well formed and
in-depth optimized.

Our new CustomShapes are not comparable to the other drawing objects, because
not every property is expressed within a single item and the complexity is even
higher as everything that is handled in xmloff before, in other words, the
xmloff infrastructure did not meet the requirements of a CustomShape during
implementation.

Whatever, it is not usual to put multiple defects into a single issue, this
should be corrected. Maybe the first issue could be named : "doubled strings are
used within the XML CustomShape import implementation" and the other "namespaces
are not checked by the XML CustomShape import".
Comment 2 clippka 2006-06-20 16:16:54 UTC 
changing target
Comment 3 Marcus 2017-05-20 10:55:23 UTC 
Reset assigne to the default "issues@openoffice.apache.org".