Issue 57790 - Excel import: numbers are all wrong in imported file
Summary: Excel import: numbers are all wrong in imported file
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: open-import (show other issues)
Version: OOo 2.0
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-12 16:07 UTC by ericding
Modified: 2013-08-07 15:13 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
QuickBooks-exported file containing a monthly budget report (23.50 KB, application/vnd.ms-excel)
2005-11-12 16:08 UTC, ericding
no flags Details
patch (1.37 KB, patch)
2005-11-17 11:56 UTC, daniel.rentz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description ericding 2005-11-12 16:07:49 UTC
Importing the attached file results in a document with numbers that are
virtually all incorrect (shown as zero, actually parsed by OO.o as very small
numbers). The original file was exported from QuickBooks; I've then opened it in
Excel to clean up names for submitting the file to the bug database.

Opening in Excel (or even in OO.o 1.1.x!) will show you what the numbers ought
to look like.  This is a frustrating regression.
Comment 1 ericding 2005-11-12 16:08:25 UTC
Created attachment 31416 [details]
QuickBooks-exported file containing a monthly budget report
Comment 2 frank 2005-11-13 01:09:01 UTC
Hi,

could not reproduce. There did you get your OOo2.0 from ?
What Linux distribution do you use ?

Frank
Comment 3 ericding 2005-11-13 12:34:53 UTC
I'm using OO.o 2.0 built from source on Gentoo Linux in order to get KDE
integration on the desktop.

CFLAGS="-march=athlon-xp -O2 -pipe -mmmx -msse -m3dnow"
gcc (GCC) 3.3.6 (Gentoo 3.3.6, ssp-3.3.6-1.0, pie-8.7.8)
Comment 4 ooo 2005-11-13 16:07:46 UTC
This looks like a Gentoo compilation flags problem, maybe related to
optimization. Try whether compiling sc/source/filter/excel/xltools.cxx with -O1
instead of -O2 helps. If not, try if it does compiling the entire directory
sc/source/filter/excel/ with -O1, or the entire sc module or ... If nothing
helps, use the official build downloaded from one of the OOo mirrors, that
should do.
Comment 5 ooo 2005-11-14 15:08:37 UTC
Instead of -O1 you can also try to add -fno-strict-aliasing to the compiler
flags, may be sufficient. Strict-aliasing is disabled in O1, but enabled in all
other optimizations.
Comment 6 ericding 2005-11-15 05:24:33 UTC
Thanks -- your suggestion to add -fno-strict-aliasing did the trick.  Will you
consider adding this somehow to the appropriate makefiles, or should I perhaps
open a bug with Gentoo to invite them to make sure this flag is used in builds
of OO.o from source?
Comment 7 daniel.rentz 2005-11-17 11:45:54 UTC
The attached patch should solve the problem regardless of the optimization 
settings.
Comment 8 daniel.rentz 2005-11-17 11:56:52 UTC
Created attachment 31581 [details]
patch
Comment 9 ooo 2005-11-17 16:15:02 UTC
Anyway, this is most certainly not the only problematic code place regarding
optimization. The original OOo build environment currently only uses -O1, which
is different from just disabling the strict-aliasing, so Gentoo should force -O1
too.
Comment 10 ooo 2005-11-17 16:48:10 UTC
oops.. the -O1 was some time ago.. currently, for OOo2.0 it is -Os
-fno-strict-aliasing, so this is what Gentoo should force.
Comment 11 frank 2005-12-15 10:58:22 UTC
Hi Daniel,

yours as dicussed onthe phone.

Frank
Comment 12 daniel.rentz 2005-12-21 15:17:54 UTC
started
Comment 13 daniel.rentz 2006-02-09 10:50:46 UTC
fixed in SRC680/dr46 (OOo 2.0.3)
Comment 14 daniel.rentz 2006-02-23 13:14:26 UTC
back to QA

no change of functionality, just check import of numbers in Excel files

re-open issue and reassign to oc@openoffice.org
Comment 15 daniel.rentz 2006-02-23 13:14:29 UTC
reassign to oc@openoffice.org
Comment 16 daniel.rentz 2006-02-23 13:14:38 UTC
reset resolution to FIXED
Comment 17 oc 2006-03-21 09:44:27 UTC
verified in internal build cws_dr46
Comment 18 oc 2006-05-09 12:34:57 UTC
closed because fix available in OpenOffice.org Developer Snapshot Build src680_m167