Issue 57833 - Change needed in bidi type of minus/hyphen
Summary: Change needed in bidi type of minus/hyphen
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: BiDi (show other issues)
Version: OOo 2.0
Hardware: All All
: P3 Trivial with 4 votes (vote)
Target Milestone: ---
Assignee: falko.tesch
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-13 15:49 UTC by alan
Modified: 2013-08-07 15:01 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Original has "ET", changes to "ES" (88 bytes, patch)
2005-11-13 15:51 UTC, alan 		no flags Details | Diff
Original has "ET", changes to "ES" (106 bytes, patch)
2005-11-13 15:51 UTC, alan 		no flags Details | Diff
wrong, pre-patch, display (58.22 KB, image/jpeg)
2005-11-13 15:53 UTC, alan 		no flags Details
Correct, post-patch, display (58.36 KB, image/jpeg)
2005-11-13 15:54 UTC, alan 		no flags Details
Changes icu-2.6.patch to conform with Unicode 4.01 bidi properties of hyphen-minus (5.28 KB, patch)
2007-01-29 07:56 UTC, alan 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description alan 2005-11-13 15:49:24 UTC 
There was a change in the bidirection character type of "minus/hyphen" (Unicode
002D) from Unicode 4.0 to Unicode 4.0.1. It was changed from ET ("European
Numeric Terminator") to ES ("European Numeric Separator"). I implemented this
change in my Hebrew build of OOo. This change causes the hyphen sign in RTL text
to appear in the correct place (see "dash_good.jpg" attached) rather than out of
order (see "dash_bad.jpg" attached). In order to implement these changes, I had
to change two files in icu: 

1) icu/source/data/unidata/UnicodeData.txt
2) icu/source/data/unidata/DerivedBidiClass.txt

I'm attaching the changes I made.
Comment 1 alan 2005-11-13 15:51:05 UTC 
Created attachment 31437 [details]
Original has "ET", changes to "ES"
Comment 2 alan 2005-11-13 15:51:38 UTC 
Created attachment 31438 [details]
Original has "ET", changes to "ES"
Comment 3 alan 2005-11-13 15:53:33 UTC 
Created attachment 31439 [details]
wrong, pre-patch, display
Comment 4 alan 2005-11-13 15:54:05 UTC 
Created attachment 31440 [details]
Correct, post-patch, display
Comment 5 alan 2006-08-29 15:16:54 UTC 
ayaniger->ft:
Have you looked at this yet? I've gotten complaints from Hebrew users because
this change hasn't been integrated yet.
Comment 6 alan 2007-01-29 07:56:04 UTC 
Created attachment 42548 [details]
Changes icu-2.6.patch to conform with Unicode 4.01 bidi properties of hyphen-minus
Comment 7 alan 2007-01-29 08:02:03 UTC 
ayaniger->ft:
I've attached the file 57833.patch, which integrates the diff files attached to
this issue into icu-2.6.patch, If the changes meet with your approval no further
changes to the OOo source tree should be necessary for dealing with this issue.
I would appreciate it if you review 57833.patch.
Comment 8 ooo 2007-01-29 13:43:04 UTC 
Hi Alan,

Stumbled over this issue.. 'ft' isn't with the OOo project anymore,
unfortunately there are still unresolved issues assigned to him.

Please note that as of m197 we use ICU 3.6 that supports Unicode 5.0.0 and
incorporates the changes of these patches, so they aren't needed anymore.

Please note also that patches to the icu-patch file itself are awkward and
cumbersome to handle in case the file changed in the meantime. Patches to the
original sources are much preferred.

Thanks
  Eike
Comment 9 ooo 2007-01-29 13:43:56 UTC 
Closing.