Apache OpenOffice (AOO) Bugzilla – Issue 60434
Crystal (KDE default) icons for OOo
Last modified: 2006-04-20 12:21:52 UTC
Now when the switching of icon sets is implemented and integrated (issue 36518), it would be great to have the Crystal (KDE default) icon theme in as well. What has to be done: - The icons themselves have to be accepted as an 'external' source - they are LGPL (+ an add-on explaining what is 'source' and what is 'binary' in case of icons), but just partially JCA covered. I've already followed the procedure described on http://external.openoffice.org, and sent the mail. The best location of the tarball containing the icons would be ooo_custom_images/, though I am not sure if - being an external source - it can be there. - OOo has to be patched to be aware of the Crystal icon set. I can attach a patch if necessary. I'll create a CWS 'iconswitching2' for this.
->pl: Please take care of this one. ->kendy: I guess a patch would not hurt...
Created attachment 33180 [details] Enable the Crystal icon set.
To build with the icons, http://www.go-oo.org/packages/SRC680/ooo_crystal_images-1.tar.gz must be unpacked in ooo_custom_images/ directory. If I could place the tarball to the OOo CVS, the build could make use of the patches in issue 60237 - it would be unpacked into a temporary directory while building instsetoo_native.
patch looks straightforward however ka knows about this stuff better
The patch is ok from my point of view. Kendy, do you still need any help from my side (I'll be not available on Monday and Tuesday next week) beside building the final CWS inhouse?
The patch is committed to CWS iconswitching2. Now I'm waiting for approval to commit the actual icon set tarball to ooo_custom_images/ .
approved from my side, IMO releng needs to approve this, too, correct?
once the new module "external_images" and alias exist, i'll add it to the obligatory_modules in cwscreate.pl and cwsresync.pl. @kendy: this should not be done until the according alias for this module exists. otherwise it would cause breakage on each run.
correction - might not even break but you will need the alias anyway :)
Created attachment 33731 [details] Enabling the build of the Crystal icons.
-z option for tar is fine for windows but will break with solaris tar. have a look an "solenv/inc/tg_ext.mk".
hjs: I have committed the patch anyway. Please, fix it, I have no good idea how to do it correctly for Solaris :-( <kendy> ause: May I ask you for help with 60434? I am unable to make it working well with pipes :-( Please, would it be OK for you that I committed the -xz version, and you'd fix it for Solaris? <kendy> ause: I mean, when I do ( gunzip | tar ) && touch file.flag, the file.flag is always created when the gunzip fails. No good idea how to do it right... Maybe gunzip | ( tar && touch ), but then I do not know whether it's going to work on Windows... Thank you in advance!
ause: Your change works fine, thank you! The last thing I changed was the name of configuration key - from 'SymbolsStyle' to 'SymbolStyle', to better conform the 'SymbolSet' configuration key, and to avoid conflicts with former ooo-build installations, where it had integer type (now it's a string).
VERIFIED - works fine.
.