Issue 64337 - Tools>Customize>Keyboard: Wrong "Can't" in explication for CTRL+Z, CTRL+Y
Summary: Tools>Customize>Keyboard: Wrong "Can't" in explication for CTRL+Z, CTRL+Y
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 2.0.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
Depends on:
Blocks: 84060
  Show dependency tree
Reported: 2006-04-12 15:33 UTC by raindrops
Modified: 2019-05-20 21:40 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0-dev
Developer Difficulty: Simple

Patch to update GenericCommands.xcu file (1.53 KB, patch)
2014-09-10 05:39 UTC, samalipraveena
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description raindrops 2006-04-12 15:33:08 UTC
When  we use the Tools > Customize menu, a window pops up. Switch to the
"Keyboard" tab.

There are two errors in the list that is provided, as shown below:

CTRL+Z Can't Undo
CTRL+Y Can't Restore

Remove "Can't" from both these descriptions.
Comment 1 wolframgarten 2006-04-12 15:39:45 UTC
Reproducible. Reassigned.
Comment 2 avagula 2007-11-28 20:18:15 UTC
This affects also localizations.
Comment 3 avagula 2007-11-28 20:19:59 UTC
and obviously wrong component, as this affects all applications, not only 
Comment 4 avagula 2007-11-28 20:21:44 UTC
This issue blocks ET translation issue 84060
Comment 5 carsten.driesner 2007-11-29 15:31:10 UTC
cd: We want to revise the accelerator configuration dialog for OOo 3.0. I will
take care of this issue.
Comment 6 rafaella.braconi 2007-12-06 09:57:05 UTC
Can we have these 2 strings fixed for 2.4?
Comment 7 carsten.driesner 2007-12-06 15:20:19 UTC
cd->coni: I am sorry but we already passed UI and translation freeze date.

cd->pb: Please take over. The default strings for both commands should be
changed to "Undo" and "Restore". It's an old problem that we use something like
"Can't "+command to reflect the initial state that both commands are not
enabled. I think that we should change that. Please find a solution with user
experience for OOo 3.0.
Comment 8 avagula 2007-12-06 15:38:49 UTC
vagula->cd: there is some misunderstanding.. the list in customize
dialog/keyboard seems to be static and I dont believe that strings in this
dialog are reused somehow, at least playing around with different states of
ondo/redo possibilites does not change anything in this dialog (btw, one notice
more: shortcut ctrl-shift-y has no assignment in keyboard-area, but it really
has one - Repeat)
Comment 9 pb 2008-06-03 17:35:02 UTC
pb: to busy to fix in 3.0 -> 3.x.
Comment 10 Mathias_Bauer 2009-05-07 13:06:56 UTC
Please take over
Comment 11 Rainer Bielefeld 2014-04-02 16:57:38 UTC
Still Reproducible with server installation of "AOO 4.1.0-dev – English UI / German locale - [AOO410m14(Build:9760)  -  Rev. 1583418_2014-04-02]" on German WIN7 Home Premium (64bit)", own separate user profile.
Comment 12 samalipraveena 2014-09-10 05:39:06 UTC
Created attachment 83948 [details]
Patch to update GenericCommands.xcu file

Modified GenericCommands.xcu file as mentioned in Bugzilla - removed can't from both Undo and Restore.
Comment 13 Andrea Pescetti 2014-09-23 06:46:29 UTC
Thanks, works for me in that context, but it has side-effects.

"Undo" is not an ordinary menu item, since it changes to "Can't Undo" when the undo operation is impossible (for example, immeditely after you start OpenOffice the "Edit" menu says "Can't Undo").

One would have to check where this "Undo" -> "Can't Undo" replacement is done, and see if it possible to fix the command in this context (i.e., Tools - Customize - Add - Edit) while still preserving the dynamic "Undo"/"Can't Undo" change.

Alternatively, we could drop the dynamic "Undo"/"Can't Undo" change altogether: but still this requires that we find and disable the code that dynamically changes it and that we quickly discuss and approve the change on the dev list.
Comment 14 samalipraveena 2014-09-23 19:50:20 UTC
Thank you so much for your review.
Yes, you're right. I thought the code i changed would only affect customize dialog part, but it changed the edit->Undo as well.
I too noticed that it changes the edit->Undo/can't Undo option as well, but it is disabled (pale text, not bold one) when undo can't be selected. Once the user types something, it changes to bold. So i left it as such. Even if the user selects it, nothing will happen. Will this not be enough?
Comment 15 Ariel Constenla-Haile 2014-09-23 19:57:25 UTC
The string is used in all user interface elements, that is, menu items and toolbar items.
IMHO it is a good indicator to the user that she/he cannot Undo/Redo, and I guess this is used by screenreaders and other accessibility tools where users cannot see the icons being disabled.
Comment 16 samalipraveena 2014-09-23 20:43:13 UTC
I modified can't undo to undo in two places in GenericCommands.xcu file. one in node Undo, and another in Undoaction. Maybe i'll try changing one back to Can't Undo. 
Many menuitems like cut, copy, paste are disabled when you can't do these operations. Only when you type in something do they get changed to bold again.
disabled->enabled and vice versa. Their text aren't changing to Can't cut->cut or vice versa.
Comment 17 samalipraveena 2014-09-24 03:53:47 UTC
Hi Andrea,
I think the change i did is correct. 
This .xcu file is the only place from where both edit menu (take Can't Undo) and customize dialog take the text for Undo (Can't Undo) and Can't Restore.
If you change it here, it will affect both edit menu and customize dialog.
However, the code is behaving correctly.
As you said,"One would have to check where this "Undo" -> "Can't Undo" replacement is done, and see if it possible to fix the command in this context (i.e., Tools - Customize - Add - Edit) while still preserving the dynamic "Undo"/"Can't Undo" change."
The original code behaves like this: the edit menu is not changing from "Undo" -> "Can't Undo" every time. Instead, it is disabled "Can't Undo" in the beginning because of the "Can't Undo" text in .xcu file. Then, when you type in some text, it changes to enabled Undo "typing that text". when you remove the text, it changes to disabled "Undo typing that text" enabled "Redo typing that text".
So my fix is working correctly. No need for any more code change.
Comment 18 jsc 2014-10-16 08:22:30 UTC
on the first look it seems to be ok, to simply change the xcu file. The menu entry is disabled and changed afterwards as you describe. 

But Ariel's comment is valid and very important and have to be checked before we change anything.
Comment 19 Marcus 2017-05-20 10:45:12 UTC
Reset the assignee to the default "".