adding ab as cc

proposed cws npower3

reassign to ab

change type to patch for review

Created attachment 36733 [details]
patch

added patch for review

changed milestone

.> 2.x, should become 2.0.5 as soon as availible

*** Issue 66533 has been marked as a duplicate of this issue. ***

Patch evaluation is in progress, should be integrated for next milestone
-> OOo 2.1, STARTED

Created attachment 39533 [details]
test document

Created attachment 39534 [details]
test document

Created attachment 39535 [details]
test document

Created attachment 39536 [details]
test document

Note: to QA

there are a couple of things to test here

Background
----------

A side affect of changing the offsets is that we can't save password protected
files in the new binary format ( at least not now as the current openoffice
versions can't read the new format, the intention is to allow saving of the new
image format in the next major openoffice version ) So what we do is save
password protected Libraries in the old format. However if someone tries to save
a password protected library containing a module that has a code size bigger
than that supported by the old format we need to inform the user that this is
the case. ( see
http://specs.openoffice.org/scripting_framework/BasicImageSizeIncreaseWarning.odt )

so the first part of the testing should verify that 
a) attempts to save a document containing a password protected library that has
a module that exceeds the supported legacy size pop up the warning described in
the spec
b) attempts to export libraries from the basic organiser dialog (
tools/macros/organizemacros/openoffice.org.basic, select organize libraries,
select the document and library to export )

for a) above the possible scenarios should include various "save" and "save as"
scenarios, also its possible that someone could have an Excel document open and
add a new libarary containing a large module to it and save it as an openoffice
format.

for b) its possible to also export an uno package, the same warning also applies
in this case

attached test document "test-ray-bigmodule.odt" contains such a large Module and
it can be used to test export and "save"/"save as" scenarios. 

e.g. to test b) above Open the document, open the basic organizer, select
libraries, select the document from the drop down list, select the Library Xray,
make it password protected by pressing the password button, press the export
button etc. etc.

for a) similar steps need to be taken to password protect the library followed
by file->save or file->saveas

obviously it should be possible to read a "legacy" password protected library.
attached document "test-ray-oldimagepassword.odt" is a document with a complex
set of macros saved in the legacy binary password protected format.
Openoffice.org should be able to read this "old" 16 bit based format and convert
 it to the new format

similarly the saved password protected format from openoffice.org should be in
the legacy format ( see above for rational ) attached document
test-ray-oldimagesavedfromnewoo.odt is a version of the first test document
saved by this cws version of openoffice ( imo this should be validated manualy )

also we stated earlier that the next major version of openoffice should be able
to save the new image format.  Attached document "test-ray-newimagepassword.odt"
is a document I created that is saved using the new image layout format. 
As ths feature introduces forward compatibilty to this release for the new image
layout it should to read and execute the password protected library macros
contained in the document above

Note: this document was created artificially and no current version of
openoffice can handle the new image format ( in fact it may crash any other
version of openoffice ) 

fixed

over to qa

Verified in CWS npower3.

set target to 2.2

closing ancient issues