Issue 64495 - new chart: wrong selection after arranging series
Summary: new chart: wrong selection after arranging series
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P4 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2006-04-19 10:12 UTC by pagalmes.lists
Modified: 2013-02-24 21:18 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
File to test the issue (11.67 KB, application/vnd.sun.xml.calc)
2006-04-19 10:13 UTC, pagalmes.lists 		no flags Details
patch (9.60 KB, text/plain)
2007-08-15 06:36 UTC, weiz 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pagalmes.lists 2006-04-19 10:12:45 UTC 
In the new chart module, when you select a series and re-arrange it, you lose
the "focus". For example, in the attached file below :

- double-click on the diagram and select a series for example the A series
  (you should then see small green points on the columns).
- click right and try to re-arrange the A series (arrangement > bring
backward/forward).
- The selection is then lost, and the series A is no more selected ! You have to
click back on it for the selection to appear again.
Comment 1 pagalmes.lists 2006-04-19 10:13:16 UTC 
Created attachment 35794 [details]
File to test the issue
Comment 2 bjoern.milcke 2006-04-19 10:46:22 UTC 
->IHA: As discussed to you.
Comment 3 bjoern.milcke 2006-04-19 10:53:37 UTC 
Why doesn't Issuezilla parse the comment and find out what I wanted to do ... ;-)
Comment 4 IngridvdM 2006-04-21 09:03:10 UTC 
accepted
Comment 5 IngridvdM 2006-04-22 14:28:44 UTC 
changed summary to start with 'new chart: '
Comment 6 bjoern.milcke 2006-06-23 10:02:50 UTC 
Changed target to 2.x
Comment 7 IngridvdM 2006-09-28 12:02:42 UTC 
changed prio
Comment 8 IngridvdM 2006-09-28 15:30:44 UTC 
changed summary
Comment 9 pagalmes.lists 2007-05-28 13:08:45 UTC 
Shouldn't this be solved before 2.3?
Comment 10 IngridvdM 2007-06-13 08:10:09 UTC 
hint for development: look at the method
ChartController::executeDispatch_MoveSeries:
The selection is indicated by an identifier and stored in m_aSelection.
This identifier is index based for series thus the wrong series is reselected
when the index changes. So an adapted identifier must be created and set using
the changed index. The class for handling this identifier stuff is
'ObjectIdentifier'.
Consider to use the method 'createParticleForSeries' or implement a new method
to create a series identifier for a given XDataSeries.
Comment 11 weiz 2007-08-15 06:35:22 UTC 
Hi iha & bm,

The final attached is the patch of this issue. :-)

Best regards,
Weizhao
Comment 12 weiz 2007-08-15 06:36:16 UTC 
Created attachment 47532 [details]
patch
Comment 13 bjoern.milcke 2007-08-15 17:05:01 UTC 
Taking over
Comment 14 bjoern.milcke 2007-08-15 17:07:43 UTC 
->weiz: Thanks for the excellent patch! (One nitpick: the UndoGuardWithSelection
had a "LiveUpdate" in its name although it wasn't for LiveUpdate, changed that)

I applied the patch to CWS chart11. Note: I had to adapt the undo stuff to the
new XUndoManager interface introduced in chart11.
Comment 15 bjoern.milcke 2007-08-15 17:10:08 UTC 
adapting target
Comment 16 bjoern.milcke 2007-08-16 15:11:17 UTC 
Correction of the prior note: XUndoManager was introduced already with chart07,
so it is in the m223 master.
Comment 17 bjoern.milcke 2007-09-05 15:26:37 UTC 
->kla: Please verify in CWS chart11
Comment 18 kla 2007-09-07 11:44:16 UTC 
Seen ok in CWS chart11 -> verified
Comment 19 kla 2007-11-28 12:04:14 UTC 
Seen ok in current master -> closed