Apache OpenOffice (AOO) Bugzilla – Issue 65325
Don't talk about sending crash report when it's disabled
Last modified: 2007-02-12 15:28:33 UTC
From our bugzilla: ----- 8< ----- Because of this, I've been seeing the document recovery screen pretty regularly upon (re-)start up of OO 2. On that screen, it says, "Click 'Next' to get to the Error Report Tool..." yet there is no "Next" button, so I can't get to the report. It might be stored on my hard drive somewhere and I can provide any that I might still have around to help with Bug 164897 if someone can tell me where to look. ----- 8< ----- But in fact, we have disabled the crash reporter in our builds by storing 'false' into the CrashReporter::Enabled in Recovery.xcs. I'll attach a patch that fixes that - lets OOo not to talk about crash reporter when it's disabled.
Created attachment 36421 [details] The fix.
Created attachment 36422 [details] Localization - if that's of some value.
reassigned to HRO
hro: Ping? ;-)
.
hro: This is really a trivial one - can you have a look, please? It involves translation changes and the deadline of 2.0.4 is quite close... I can do all the CWS stuff, etc.
Andreas, document recovery is your resort. Please take over.
Thanks for the patch, Andreas will have a look when he's back from vacation
The patch seams to be acceptable. But we have to update the specification acoordingly. I will do that. Please stay tuned ....
AS->kendy: I've used the idea behind the patch ... but not the patch itself. Reason: you changed the text of the first dialog page without any reason. Because there nobody is talking about error reports etcpp. Further the last dialog page was updated in case the error report is enabled ... but you forgot to update the description text in case error report is disabled .-) Anyway: I've changed the spec; our user experience team accepted it; I've made all source code changes. Next time you will have AutoRecovery without an ErrorReport realy.
as: Thanks! :-) In what CWS is it now, please?
The cws is "patch01as". The link to the changed spec is "http://specs.openoffice.org/appwide/errorreporter/error_report_2_0_ui_specification.odt".
as: (That's because I'd like to check "Because there nobody is talking about error reports etc." - I see "A report of the crash was created helping us to identify the cause why %PRODUCTNAME crashed. Click 'Next' to get to the Error Report Tool or press 'Cancel' to skip this step." in the current sources & nothing like that will be displayed with the crash reporter disabled.)
as: Looks great in the CWS, thank you again!
AS->TM: Please verify this task on the cws [patch01as]. THX. (Note: Spec on specs.openoffice.org was changed accordingly).
checked and verified in cws "patch01as" -> OK !
closed