Apache OpenOffice (AOO) Bugzilla – Issue 66013
[STAGE] Change velocity template on STAGE to publish static /index.html
Last modified: 2008-05-16 03:29:57 UTC
The current velocity template on stage.openoffice.org renders project index.html pages with full dynamic content. On production (2.6.2; what we use now) most project index pages are staticized and as a result of a bug the ~/index.html page is rendered without the project header. We like that. We would like to change the velocity template so that ~/index.html is rendered. Please also detail the consequences of this change.... Thanks louis
changing prio and issue type and summary
adding pcn # to status whiteboard and [STAGE] to summary.
from the collabnet engineer: "This can be done by overriding ProjectHome.vm by placing it in the following path : look/www/overrides/templates/org/tigris/helm/project/. I've done this now. I've commented out the axial table that contains the Summary, Categories, other details there and the Description. (http://look.stage.openoffice.org/source/browse/look/www/overrides/templates/org/tigris/helm/ project/ProjectHome.vm?r1=1.1&r2=1.2) If it can be removed from the file let me know. === If commenting out does the job, do we need to remove? I think commenting out might provide a nice trail, should we wish to undo this or should an upgrade require us to reiterate this. louis
a little hasty in resolving
Commenting out is fine with me. Please note there is still some header left: api Project home If you were registered and logged in, you could join this project.
Now that the template is in look, we can do further tweaking ourselves, so this issue can be solved/put away from support's pile Now the table is commented out in the generated HTML, I'd like to comment it out in the template, so that it is not generated at all. OK for you?
Feel free to go ahead.
I asked the engineer to remove it and to see if it is possible to clean up the rest of the template. -louis
per engineer: commented lines removed. I haven't checked, however. Louis
lous seems to have misunderstood me, but that's fine as well.. I meant "comment out the instructions that now generate the commented-out html", deleting them is fine as well. But still the following is generated: ########## <name> Project home ########## and: ########## If you were registered and logged in, you could join this project. ########## We want to get rid of it too for the main pages, so I modified PreServlet.vm accordingly. If there are pages that should show this remark, then let me know.
Cloph, I actually understood you; I was following what I understood to be Stefan's instructions, or rather, relaying them to the engineer. I'll further communicate your comments (cut and paste as before) to CollabNet. best louis
What is left is "If you were registered and logged in, you could join this project." resp. "Request project role". Any opinions whether this should be removed too?
I think it should be removed; it can be confusing. We stipulate what roles people can have elsewhere. However, we need to be clear to CollabNet what we want removed, what left in.
optimal solution: * IF not logged in remove link "register or login" * IF logged in: leave edit/request role If not possible remove the link.
Please note that the recent change http://look.stage.openoffice.org/servlets/ReadMsg?list=cvs&msgNo=811 PreServlet.vm, Rev. 1.17 removes *all* links like "Add new project role", "Start new project", ... in this position. I would strongly suggest to revert this change. The requirements are still as described by Louis - but for the project home page only!
updated pcn and underscored priority.
engineer ananda reverted the changes I'm asking to implement this change: optimal solution: * IF not logged in remove link "register or login" * IF logged in: leave edit/request role If not possible remove the link.
... minus, that is, "remove the link"....
Why not use the simple rule: Not for the project-home, show it for everything else? e.g. on the membership-pages, I'd like to have "If you were registered and logged in, you could join this project." when not logged in and "Request project membership/role" when logged in. the simple #if (!$helmR.inServlet("ProjectHome")) #parsePrefix("$servletTaskBar.resolvePath($helmR.getServletName())") #end did do that. With the latest changes, the project-homes again show the "Request project role" e.g. on http://de.stage.openoffice.org/ when logged-in, but I don't get the "i you were registered.... (when not logged-in) on http://fr.stage.openoffice.org/servlets/ProjectMemberList for example. I don't really care whether to show the "If you were registered" message when not logged-in, but I certainly don't want the "Request project role" on the project-home.
ST, would you agree with cloph's suggestion?
We (cloph and I) agreed on IRC that the suppression of the links should only affect the project home pages. Currently we miss "If you were registered and logged in, you could join this project." on project's Membership list - if not logged in. See http://ucb.stage.openoffice.org/servlets/ProjectMemberList I tried to achieve this with http://look.stage.openoffice.org/source/browse/look/www/overrides/templates/PreServlet.vm?r1=1.19&r2=1.20 which didn't restrict the change to the homepage. As said I would like to retain the "Request Role", "Edit Project" links on project home pages for logged in users - if possible.
Hello Stephan, Cloph, Your proposed change *will* be done after the site upgrade. As an upgrade manager, I have concerns with any last minute such changes; hence wanted to defer this as a post-upgrade task. That way we can "close" all activities on the stage box and have the proper branding files during the production upgrade. Also, the stage box will be available for some time after the upgrade is complete to test/verify any upgrade issues. Please let us know if that would work for you. Thanks
I would consider playing on a production site even worse than last-minute changes on a staging server. We can easily test changes and their consequences without bothering thousands of users. What concerns me more is that we so far don't have a satisfying solution.
from beril: I made this change, the site needs a restart after the indexer is complete. LSP: a quick view of api.stage.openoffice.org logged on and not indicated that the fix was as desired. Cloph or ST, would you want to look it over?
Assigning to Stefan to verify. Looks OK to me, right now.
The behaviour looks ok wrt to appearance of the links. There is an supoerfluous '#' as a first character in "#If you were registered and logged in, you could join this project."
That "#" is now removed; please verify and if it now looks ok, can this issue be closed? All the stage changes are now collected in the final branding set for OO.o production upgrade.
looks good
verified on stage
This Issue is 'Verified' and not updated in 1yr+, so Closing. A Closed Issue is a Happy Issue (TM). Regards, Andrew Cleaning-up and Closing old Issues as part of: ~ The Grand Bug Squash, pre v3 ~