Issue 67767 - gsicheck missed problem: "
Summary: gsicheck missed problem: "
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
Depends on:
Reported: 2006-07-25 18:44 UTC by pavel
Modified: 2017-05-20 11:31 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

error line (653 bytes, application/octet-stream)
2006-07-25 18:46 UTC, pavel
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2006-07-25 18:44:42 UTC

all my builds of m178 broke because I merged Bulgarian GSI with error that was
not  spotted by gsicheck.

I'll attach the two liner GSI for you to check.
Comment 1 pavel 2006-07-25 18:46:50 UTC
Created attachment 38020 [details]
error line
Comment 2 h.hristov 2006-07-25 19:39:55 UTC
Comment 3 avagula 2006-07-25 20:11:15 UTC
This may be problem rather about faulty source strings... In my opinion
character ' is in most cases not escaped and it is escaped only in following places:
- desktop	source\deployment\gui\dp_gui_dialog.src	0	fixedtext	RID_DLG_LICENSE
FT_LICENSE_BODY_1_TXT			0	en-US	Read the complete License Agreement. Use the
scroll bar or the \'Scroll Down\' button in this dialog to view the entire
license text.
- desktop	source\deployment\gui\dp_gui_dialog.src	0	fixedtext	RID_DLG_LICENSE
FT_LICENSE_BODY_2_TXT			0	en-US	Accept the License Agreement for the extension
by pressing the \'Accept\' button.
- instsetoo_native	inc_openoffice\windows\msi_languages\Nsis.ulf	0	LngText
MUI_TEXT_WELCOME_INFO_TEXT				0	en-US	The installation files must be unpacked
and copied to your hard disk in preparation for the installation. After that,
the %PRODUCTNAME installation will start automatically.\r\n\r\nClick \'Next\' to
- instsetoo_native	inc_openoffice\windows\msi_languages\Nsis.ulf	0
LngText	DirText				0	en-US	The %PRODUCTNAME %PRODUCTVERSION installation files
will be unpacked and saved in the folder shown below. If you would like to save
%PRODUCTNAME to a different folder, click \'Browse\' to select another folder.
- sw	source\ui\app\app.src	0	fixedtext	DLG_MERGE_SOURCE_UNAVAILABLE
ST_MERGE_SOURCE_UNAVAILABLE			178	en-US	The data source \'%1\' was not found.
Thus the connection to the data source could not be established.\n\nPlease check
the connections settings.

In MANY other places ' is not escaped and there is no problem, so translator can
replace this with ESCAPED ", as language rules require (using ' as quote is not
permitted in many languages).
Ivo, can you please look at it?
Comment 4 gregor.hartmann 2006-12-29 10:11:10 UTC
the problem is that when merging the localize.sdf file the escaping of the "
(double quote) is reversed. But that of the single quote is not. (it is the same
anyway if a single quote is escaped or not) So in this case the translator gets
confused, seeing an escaped qoute and escapes it too in her translation.

I agree with you vagula that is is rather a problem of the sourcestring. Maybe
it should get enforced not to escape single quotes as it is unnecessary.

so bst would be to integrate that in the ressource compiler.

These thoughts are only about src files, I am not sure about other filetypes
which have to get translated

about gsicheck: I could include a part which checks for escaped and unescaped
single and double quotes in source and translation and then checks if the same
amount of equivalent qoutes is present in both strings. 'Equivalent' would be
according to the following table:
left side is the source and right side the translation it requires

\" -> \"
' or \' or "  -> ' or \' or "

additionally the part between \" and \" could be checked for equality.

adding vagula to cc
Comment 5 gregor.hartmann 2007-01-03 08:16:34 UTC
checking the part between \" and \" would also check the problem of issue 59208 
Comment 6 gregor.hartmann 2007-01-04 13:55:02 UTC
setting to ivo as noone answers while it is my bug
Comment 7 ivo.hinkelmann 2007-01-08 15:53:40 UTC
Checking for the same amount of equal quotes would fix this build issue. What
means "permitted in many languages" ? Not allowed , not part of the font? 
Comment 8 h.hristov 2007-01-08 16:33:50 UTC
In some languages we use " instead of ' for quotation.
Comment 9 gregor.hartmann 2007-01-19 14:34:45 UTC
ccing hjs
Comment 10 Marcus 2017-05-20 11:31:18 UTC
Reset assigne to the default "".