Apache OpenOffice (AOO) Bugzilla – Issue 68590
BUILD_VER_STRING too small in Help:About
Last modified: 2019-10-13 18:32:09 UTC
The BUILD_VER_STRING display on the Help:About dialog is too small and practically unreadable, at least for me, on Windows, in case it makes any difference. (See attached screenshot.) Trivial patch that makes it as large as the other text. Alternatively, a somewhat larger size factor than 0.75 could be tried, for instance 0.85? @@ -222,11 +222,6 @@ aCopyrightText.SetControlForeground( aTextColor ); aBuildData.SetBackground( aWall ); - Font aSmallFont = rSettings.GetInfoFont(); - Size aSmaller = aNewFont.GetSize(); - aSmaller.Width() = (long) (aSmaller.Width() * 0.75); - aSmaller.Height() = (long) (aSmaller.Height() * 0.75); - aNewFont.SetSize( aSmaller ); aBuildData.SetFont( aNewFont ); aBuildData.SetBackground( aWall ); #ifdef BUILD_VER_STRING
Created attachment 38489 [details] Without font edge smoothing
Created attachment 38490 [details] With "standard" font edge smoothing
Created attachment 38491 [details] Witn ClearType smoothing
As can be seen from the above screenshots, on Windows using font smoothing helps a bit, but on the other hand it's not sure that people have font smoothing or ClearType turned on, or tuned correctly. (Personally I can't decide whether I like the effect ClearType has or not, for instance...)
invalid as OOo from www.openoffice.org doesn't have that string - i.e. it is a modification done by novell and thus has to be fixed by novell. Please file a bug-report in their bug-tracking system.
closing - that code is not in upstream OOo...
sorry, reopen issue.
there is no special build-version-string set in default builds - so that issue doesn't show-up in vanilla builds. Nevertheless, if you want to have this fixed, please file a seperate issue in novell's bugtracker. This one might as well be closed again since that version string only meant for special builds.
Peter, please take over and check the patch. In case it's OK integrate it into the next version. Otherwise please explain what might be wrong with the patch.
pb -> mmeeks: please take over. It is your code and I don't want to change it.
pb: Tor (tml) works for me, and I trust him implicitely; ergo I love his patch, whatever it is :-) Go Tor ! :-)
confirming issue
Michael, just a question: will you apply the patch as the issue is still assigned to you? Or will tor do it? AFAIK both of you have commit access and so you can integrate the fix without any further action from our side.
PING. :-)
Tor was on this I tihnk.
Tor, are you still working on this or should we discard the patch and set the type to "DEFECT"?
I'd say let's forget this until a real customer complains... maybe this is just amatter of taste. Setting to ENHANCEMENT:OOo Later. (We will continue to do it in the Novell build for Windows, though.) In any case, I guess this shouldn't be done unconditionally on all platforms, as for instance the Debian packager explicitly said he wants to have a smaller font for the build string on Debian (as it is ridiculously long for them, or something).
https://github.com/apache/openoffice/blob/trunk/main/cui/source/dialogs/about.cxx Seems to be commited