Issue 68825 - new chart: need to remove redo action for chart that got removed via undo
Summary: new chart: need to remove redo action for chart that got removed via undo
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: viewing (show other issues)
Version: 680m172
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: new_implementation
Depends on:
Blocks:
 
Reported: 2006-08-21 13:34 UTC by thomas.lange
Modified: 2013-08-07 14:42 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
sample document (7.49 KB, application/octet-stream)
2006-08-21 13:55 UTC, thomas.lange 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.lange 2006-08-21 13:34:37 UTC 
In CWS chart2mst3 if you insert a table and then insert a chart for that table a
chart gets inserted and following that the new chart wizard dialog opens.
If you press the 'Cancel' button the chart gets removed (by calling undo) but a
redo action remains. 
Since the dialog was ended via 'Cancel' this should not happen.

Thus it seems one of the following solutions are available.
1) remove the top redo action
2) may it is ok to remove all redo actions because when chart was inserted
    all prevous redo action got removed already
3) introduce some function like 'UndoWithoutRedo'

The code line where the chart was removed with undo is in Writers chartins.cxx
right after the line
  if( nDialogRet == ui::dialogs::ExecutableDialogResults::CANCEL )

TL->AMA: Please take over. Thanks!
Comment 1 thomas.lange 2006-08-21 13:35:24 UTC 
.
Comment 2 thomas.lange 2006-08-21 13:55:02 UTC 
Created attachment 38669 [details]
sample document
Comment 3 thomas.lange 2006-08-21 13:57:41 UTC 
If you use the attached document and remove all lines before the table and then
insert a chart and cancelling exit the chart-wizard via cancel then now there
won't be a redo on the stack!
Maybe this is a problem that needs to be fixed as well.

This seems to be different when you do the same with a new document though.
Comment 4 IngridvdM 2006-08-21 15:35:42 UTC 
added keyword 'new_implementation' and string 'new chart:' to summary
Comment 5 andreas.martens 2006-11-09 08:44:33 UTC 
Fixed in CWS chart2mst3
chartins.cxx 1.8.248.16
view.cxx 1.97.44.1
viewsh.hxx 1.50.72.1
viewsh.cxx 1.65.44.1
edtab.cxx 1.15.46.1
Comment 6 andreas.martens 2006-12-14 10:55:45 UTC 
Ready for QA
Comment 7 IngridvdM 2007-01-18 14:26:38 UTC 
changed target and type
Comment 8 michael.ruess 2007-03-28 14:22:46 UTC 
Verified in CWS chart2mst3.
Comment 9 michael.ruess 2007-06-21 15:52:22 UTC 
Checked in 680m214.