Issue 68902 - VBA: Needs to determine all cells have same content
Summary: VBA: Needs to determine all cells have same content
Status: CLOSED FIXED
Alias: None
Product: App Dev
Classification: Unclassified
Component: scripting (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: sled10guy
QA Contact: Unknown
URL:
Keywords:
Depends on:
Blocks: 68883
  Show dependency tree
 
Reported: 2006-08-23 17:14 UTC by noel.power
Modified: 2013-02-24 21:00 UTC (History)
4 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch file (3.35 KB, patch)
2006-08-23 17:15 UTC, noel.power
no flags Details | Diff
test document (22.50 KB, application/vnd.ms-excel)
2007-11-21 12:33 UTC, noel.power
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description noel.power 2006-08-23 17:14:23 UTC
Some attribute/properties of a Range object return as null if not all the cells
in the range contain the same value. In the Openoffice.org ScCellRange uno
object these values typically have a default value if all cells do not have the
same value.

ScCellRangesBase returns the properties based on the SfxItemSet for the range,
normally a state of SFX_ITEM_DONTCARE indicates that the value of the item in
question changed across the range. ScCellRangesBase however applies
ClearInvalidItems() to the  SfxItemSet ( which fills those values with defaults ).

This patch modifies  ScCellRangesBase so that its possible to determine whether
these values are the same across the range or not it does that by simply
maintaining a copy of the SfxItemSet ( that hasn't had ClearInvalidItems()
applied to it )
Comment 1 noel.power 2006-08-23 17:15:56 UTC
Created attachment 38739 [details]
patch file
Comment 2 noel.power 2006-08-23 17:43:57 UTC
trying->DR ( again & again )
again needed by vba api ( which uses the ScCellRangesBase object directly )
Comment 3 noel.power 2006-08-23 17:44:28 UTC
ooops
Comment 4 daniel.rentz 2006-10-17 09:19:50 UTC
target/started
Comment 5 utomo99 2007-07-04 04:57:09 UTC
utomo99
Comment 6 noel.power 2007-07-04 11:29:02 UTC
change to patch
->dr maybe npower8 would be a good place to put this in? I am happy to make the
changes if you are happy to accept/review/suggest etc..
Comment 7 noel.power 2007-07-18 15:01:23 UTC
I have added this to npower8, this is imo a pretty non intrusive patch, hope you
agress 
Comment 8 daniel.rentz 2007-07-23 14:26:17 UTC
yes, I agree, looks good
Comment 9 noel.power 2007-08-07 10:22:47 UTC
change target, reassign to me..
Comment 10 Mathias_Bauer 2007-08-27 14:22:38 UTC
changed component
Comment 11 noel.power 2007-11-07 18:32:04 UTC
fixed
Comment 12 noel.power 2007-11-21 12:04:40 UTC
->qa
Comment 13 noel.power 2007-11-21 12:32:33 UTC
attaching a document that tests the font attribute of a range, e.g. if for the
whole range the Bold attribute is the same then you get that value, if one of
the cells in the range has a different Bold attribute then
Range("a1:c2").Font.Bold will return a NULL.

Attaching a document to test that
Comment 14 noel.power 2007-11-21 12:33:24 UTC
Created attachment 49791 [details]
test document
Comment 15 noel.power 2007-11-21 12:34:43 UTC
with the vbaapi.oxt extension installed open the document and press the button,
the result should say "passed"
Comment 16 sled10guy 2007-11-29 23:23:28 UTC
Passed Regression testing on SLED10SP1 using vbaapi-patched.oxt and on Windows
using vbaapi.oxt.
Comment 17 thorsten.ziehm 2009-07-20 15:16:43 UTC
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues
Comment 18 worlbrigkibbpi 2010-11-11 01:21:09 UTC
Created attachment 74000