Apache OpenOffice (AOO) Bugzilla – Issue 69373
soffice.bin does not launch without script
Last modified: 2007-05-24 21:20:14 UTC
Since Mac OS X expects absolut paths to be passed to dlopen, one can not start soffice.bin without having DYLD_LIBRARY_PATH set to the program directory or launching it from there. The latter is due to a fallback in osl_psz_loadModule, which adds a './' to module names not having any '/'. The patch replaces this fallback by searching the library beside the executable. obr->hro: please review the patch.
Created attachment 39036 [details] Patch changes the fallback for osl_loadModule
Nice patch :) However, please add appropriate comments to the code about what it does (esp. the new "/" -related code). The old code had comments, there is no reason to make the code less documented (it's already hard as it is).
Agreed. Will probably rework the patch also in a way that always prepends the executable path for module names without path. I would even say that relative paths (foo/bar.so) should always be treated relative to executable path (instead of cwd) on all Unix platforms, even though such paths are not used in OOo AFAIK.
ericb->obr Oliver, your patch works fine! For the first time, I was able to launch native version of OpenOffice.org on Mac OS X without use the terminal. Thank you for your work !!
myself on cc
ericb->obr After some investigatons, I think something is missing with your patch because _imp_getProcessLocale () does return C when bundle is run, and fr_FR.UTF-8 when run in terminal The exact reason is libsalsystools is searched in "/" , and not in the bundle. This leads to important issues with the bundle, e.g. : 1) instant crashes in some cases (like HyperLink-> Internet -> click on folder icon ) 2) wizards are not working at all Isn't it possible to modify the patch and use some getenv( ) function like, to search first in the bundle ? Thanks in advance (and thanks to Pavel for his help)
I added the patch to aquavcl01 for easier debugging. I'm not marking this issue as fixed yet.
Created attachment 42291 [details] this patch seems to fix libsalsystools.dylib issue
This patch works for me with aqua version, and seems to fix the libsalsystools.dylib issue (and maybe we now can read preferences files, not yet tested) Can anyone do a code review ? Thanks in advance
To be more complete, I removed libsalsystools.dylib, and I have linked osxlocale.cxx object to libuno_sal.dylib This way, dlsym() seems to simply work
After some tries : /Users/ericb/Library/Application Suport/OpenOffice.org 2.1/user/macosxrc.txt works when using UpdateSettings() : I can paint the UI in whatever color, but not choose the fonts (why?) What does not work yet is : ~/Library/Application Suport/OpenOffice.org 2.1/user/macosxrc.txt (default file in preset somewhere in the Bundle has not been not tested)
I haven't checked the diff in details, but I like the patch in general: removing OSX specific stuff and moving it. Good work, Eric. Please check comments - there still are comments about loading something from dylib.
Created attachment 42305 [details] more cleanest patch ( warning about implicit function declaration fixed )
New patch fixed the premac.h / postmac.h nightmare when using system.h + some clean up about dilyb in comments ericb->pjanik Thank you :) I want to thanks Oliver too : I just ordered and implemented his hints and suggestions. ericb->tra About your comments on IRC : 1) I can't get it work without use dlsym() , maybe add public headers for functions defined in osxlocale.cxx will help ? Sorry, I need help/advices here :-/ 2) everything is protected ( #ifdef MACOSX ... etc )
ericb->obrmac As discussed on IRC, I have commited my changes in aquavcl01. This way, you can continue for a more complete cleanup
My understanding is that this has been fixed in cws aquavcl01. Marking as fixed. Reopen if I'm wrong.
see issue 73693 for further details.