Issue 69519 - WW8: multi-page table cut-off due to too many Header rows
Summary: WW8: multi-page table cut-off due to too many Header rows
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: OOo 2.0.4
Hardware: All All
: P3 Trivial with 5 votes (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
: 82431 (view as issue list)
Depends on:
Blocks:
 
Reported: 2006-09-14 08:20 UTC by tuharsky
Modified: 2013-08-07 14:42 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
The affected document (248.00 KB, application/msword)
2006-09-14 08:25 UTC, tuharsky
no flags Details
Screenshot WW; table starts at page 1 (24.52 KB, image/png)
2006-09-14 08:29 UTC, tuharsky
no flags Details
Screenshot WW; table continues to page 2 (22.81 KB, image/png)
2006-09-14 08:30 UTC, tuharsky
no flags Details
A simple fix for this issue. (679 bytes, patch)
2007-10-04 15:42 UTC, mloiseleur
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description tuharsky 2006-09-14 08:20:58 UTC
There are two tables in the document.

When opened in WW, both are displayed correctly and both take multiple pages.

Opened in OOo2.0.4rc1 or earlier, the first table is only partially displayed,
at one page, and rest of table is cut-off (invisible). The second table is
displayed correctly.
Comment 1 tuharsky 2006-09-14 08:25:04 UTC
Created attachment 39132 [details]
The affected document
Comment 2 tuharsky 2006-09-14 08:29:20 UTC
Created attachment 39133 [details]
Screenshot WW; table starts at page 1
Comment 3 tuharsky 2006-09-14 08:30:04 UTC
Created attachment 39134 [details]
Screenshot WW; table continues to page 2
Comment 4 michael.ruess 2006-09-14 08:56:43 UTC
As a workaround, set the number of repeated rows in Writer's "table properties"
to 0. 

MRU->FME: I do not know exactly what's going on here, but it looks, that MS Word
has an algorithm which prevents a situation as in W'riter with this table. All
rows in this table are decclared as "Header to be repeated on each page". That
this won't work on a table with 94 rows does not surprise anyone...
But Ms Word seems to calculate if such a number of header rows makes sense, and
if not, the header rows won't be applied to the document view.
Comment 5 avagula 2007-01-09 18:33:41 UTC
I have another good example at http://www.kmprojekt.ee/sodi/Spetsifikatsioon.doc
Here OO.o shows repeating rows count as 174 (it is total count of rows in
table). Setting this number to 1 will let OO.o display document properly.
Apparently poor Word user had all the table selected, when setting repeating
rows... Alas, Word displays this document like only one row was repeated - i.e.
as user ment. Dont understand why Word fixes invalid things by displaying but
saves the crap...
Comment 6 nickwia 2007-03-21 14:48:38 UTC
I found this bug from a question I had on the forum here:
http://www.oooforum.org/forum/viewtopic.phtml?t=54644

The following document has one repeating header row that opens fine in WW but 
not in OOo:
http://www.mytempdir.com/1262580

My suggestion for a fix would be the following: If all available rows are 
selected as header rows, then only use first row as a header row. I'm not 
certain how WW does it, but it would seem to me that if a user selected an 
entire table and made it a header row, then they obviously want a header row.

Also, just based on my observations of how font and style changes work (typing 
after a bolded character makes more bolded characters) it would seem to me that 
the entire table being saved as a header row (in WW) is likely due to creating 
the first row, making it a header row, and then continuing on with a new row, 
oblivious to the fact that it is still checked as a header row.

A check could likewise be made on the first row in the table to express a 
different font size (weight, style, etc) from the other previous rows.

Lastly, how often is more than one row needed as a header row? I haven't seen 
WW -- in any observation where all rows are specified as header rows -- default 
anything more than the first row as a header row.

Thanks to whoever takes a look into this for us.
Comment 7 mloiseleur 2007-10-04 15:42:45 UTC
Created attachment 48701 [details]
A simple fix for this issue.
Comment 8 mloiseleur 2007-10-04 15:46:40 UTC
Hi there,

   I have made a patch for this issue. It works quite well for us. It's really
simple to explain. The file made with Ms Word is incorrectly written, there's no
one on earch who wants to repeat _all_ rows of its table. So this small fix just
restore the normal human behaviour.
   It fixes the problem for my sample files and for the affected document of
this issue.
   
   Please integrate it as soon as you can,

Thanks,

Comment 9 mmeeks 2007-10-04 15:52:05 UTC
switch type to patch, update milestone etc.
Comment 10 michael.ruess 2007-10-09 11:38:21 UTC
*** Issue 82431 has been marked as a duplicate of this issue. ***
Comment 11 frank.meies 2007-10-10 11:27:32 UTC
fme->mloiseleur: Thank you for your submission. I'll have a look at your patch.
Comment 12 frank.meies 2007-10-10 11:53:35 UTC
fme->mloiseleur: Looks good. Added this issue to cws swqbf105, committed file
ww8par2.cxx rev. 1.133.30.1. Thank you for your contribution!
Comment 13 frank.meies 2007-10-22 13:55:10 UTC
FME: Ready for QA.
Comment 14 michael.ruess 2007-11-06 14:25:22 UTC
Yeah, with the patch it of course looks much better now.
Only thing is, that MS Word internally seems to use "no rows to repeat" as
fall-back in such a case. Maybe we should fine-tune this in the future, because
the patch uses "one row to repeat". If desired, we could handle this in a new
issue for a future version.
Comment 15 michael.ruess 2008-07-15 09:57:45 UTC
Checked in DEV300m24 build - but should also be available in OO3 beta / beta2.