Issue 72804 - Border dialog preview incorrect for RTL
Summary: Border dialog preview incorrect for RTL
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOo 2.0.4
Hardware: All Windows XP
: P3 Trivial with 3 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
Keywords: BIDI
Depends on:
Blocks: 114236
  Show dependency tree
Reported: 2006-12-20 14:04 UTC by alan
Modified: 2017-05-20 11:18 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Screenshot illustrating the problem (108.69 KB, image/png)
2006-12-20 14:06 UTC, alan
no flags Details
Proposed patch (1.35 KB, patch)
2006-12-20 14:06 UTC, alan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description alan 2006-12-20 14:04:47 UTC
When an RTL user defines borders in the border dialog, the table preview does
not reflect the table in the document. Changing the left border in the preview
will change the *right* border in the table and vice versa. Note in the
screenshot that removing the right border in the dialog actually removes the
left border in the document.

I'm attaching a patch to fix this. Please review.

Comment 1 alan 2006-12-20 14:06:02 UTC
Created attachment 41598 [details]
Screenshot illustrating the problem
Comment 2 alan 2006-12-20 14:06:47 UTC
Created attachment 41599 [details]
Proposed patch
Comment 3 michael.ruess 2006-12-20 16:32:52 UTC
Reassigned to OS.
The control for setting borders does not respect RTL mode in a document.
Comment 4 Mathias_Bauer 2007-04-10 10:50:05 UTC
Alan, do you need more help? Are you still interested?
Comment 5 alan 2007-04-10 13:38:40 UTC
I sent a patch in December when I first submitted the issue. Has anyone reviewed it?
Comment 6 Mathias_Bauer 2007-04-10 14:22:03 UTC
Sorry, Alan, I mis-read the comment from mru. Of course now the ball is in our
field. :-[

Thanks for your patch, my fault.

As Oliver is very busy I think Peter can take over. If the patch is fine we
should be able to integrate it into 2.3. So I changed the target accordingly.
Comment 7 alan 2007-04-11 13:17:37 UTC
My patch needs to be fixed. The patch does cause the correct border to get
changed in the document, but if the table properties dialog is reopened, the
preview shows the wrong border as modified.
Comment 8 pb 2007-04-17 08:46:42 UTC
pb: I take over.
Comment 9 pb 2007-04-25 05:32:35 UTC
pb: Sorry Alan, but I cannot reproduce this problem. With an arabic version or
an english version (and SAL_RTL_ENABLED=1) the right border is changed.
Comment 10 alan 2007-04-25 05:54:27 UTC
Setting SAL_RTL_ENABLED won't reproduce the problem. You have to set the locale
to a CTL language like Hebrew or Arabic. I just reproduced the problem on a
fresh install of the distributed 2.2 on Debian Linux.
Comment 11 pb 2007-04-25 12:24:29 UTC
pb: Sorry, yes you are right. It is necessary that the text direction is
Right-to-Left to occur this bug. So I will have a look on your patch.
Comment 12 pb 2007-05-07 10:40:13 UTC
pb: the patch only works if RTL-Layout is set and the textdirection is set to
RTL too. But it doesn't work if RTL-Layout isn't set and textdirection is set to
RTL and it fails if RTL-Layout is set and the textdirection is set to LTR. So I
have to reject your patch. Sorry.
Comment 13 alan 2007-05-07 11:59:20 UTC
Yes, I already wrote in an earlier post to this issue that my patch doesn't
work. I should have changed to issue type back to defect. I'll do that now.
Comment 14 pavel 2007-08-06 11:15:07 UTC
Move target because of inactivity and code freeze.
Comment 15 Martin Hollmichel 2008-02-12 10:36:30 UTC
move target to 3.x
Comment 16 kaplanlior 2010-08-21 17:52:24 UTC
Still happens in 3.2.1 OOO320m19 (Build:9505).

Could we get a target for this one ?
Comment 17 kaplanlior 2010-08-31 23:37:38 UTC
Reproducible in 3.3 OOO330m3.
Comment 18 yomach 2010-10-07 10:47:06 UTC
Almost exactly the same as

Only that one is in calc.
Comment 19 Marcus 2017-05-20 11:18:03 UTC
Reset assigne to the default "".