Issue 73952 - Extension Manager crashes with installed svg extension
Summary: Extension Manager crashes with installed svg extension
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 2.2
Hardware: All Windows XP
: P2 Trivial (vote)
Target Milestone: OOo 2.2
Assignee: b.osi.ooo
QA Contact: issues@framework
URL:
Keywords:
: 73167 74330 (view as issue list)
Depends on:
Blocks: 73858
  Show dependency tree
 
Reported: 2007-01-28 15:49 UTC by stadt
Modified: 2007-02-13 10:30 UTC (History)
5 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
stop craashing extension manager (974 bytes, patch)
2007-02-03 04:11 UTC, sparcmoz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description stadt 2007-01-28 15:49:41 UTC
OOo 2.2 M4 crashes when the extension manager is opened and the svg import
filter  (see http://www.ipd.uka.de/~hauma/svg-import/) is installed.

After removing the filter manually /(e.g. by deleting the complete profile) the
extension manager opens without crash
Comment 1 Olaf Felka 2007-01-29 08:52:38 UTC
Please have a look.
Comment 2 leiflodahl 2007-01-29 10:54:43 UTC
To me it seems more like crashing with ANY extension installed. Both when
upgrading from 2.1 and a 'clean' installation. If there is one or more
extensions installed, the extension manager crashes.
Comment 3 joerg.skottke 2007-01-29 11:53:34 UTC
JL: Please check this one, i currently don't have the time to do so myself
Comment 4 joachim.lingner 2007-01-29 13:56:22 UTC
I checked this on Windows XP, Linux with OO2.2 m4 and the respective StarOffice
version with the svg import filter (svg-import-r2185.uno.zip),
LanguageTool-0.8.7.zip and various other extensions but could not experience a
crash. I installed the extension as user and as shared extension, opend the
Extension Manager various times also loaded the gearflowers.svg. 

Could you provide more information so as to reproduce this crash.
Comment 5 joerg.skottke 2007-01-29 14:03:35 UTC
Hi stadt,

are we missing something? JL wasn't able to reproduce the issue in various
scenarios so there must be a difference in approach somewhere.

Setting target 2.x as long as this is unconfirmed.
Comment 6 stadt 2007-01-29 19:22:28 UTC
All I can tell is that the extension-manger crashed whole Openoffice with the
message, an unexpected error occured ... with installed svg-import-r2185.uno.zip.

After deleting the profile the extension manager (with no installed extension)
started as expected.

As soon I try to install svg-import-r2185.uno.zip again OOo crashes with an
unexpected error at the end of the installation process, and continues to crash
as soon my mouse-pointer comes only in the near of the extension manager.

I can reproduce this error as often as you want.

Maybe it's specific for my system (which works in ALL other cases and with OO
2.1 perfect, absolutely reliable, no other issues at all). So some basic about
it (which might be the cause): Processor Intel Core 2 Duo 6400 (Dual Processor)
 on Asus PB5-E (Intel P965 chipset), 1 Gb Ram, SataII Harddisk, NVidia 7600GS
Graphics with latest driver, Ralink WiFI, System WinXP Home SP2 latest fixes,
nothing special in autostart except Antivirus (AVG) and InCD DVD-RAM Driver.

OOo is always installed on drive d: (not C: !), quick starter isn't installed at
all (on my system OOo starts more than fast enough :-) even without it).

If I can do anything to catch the malfunction better plese tell.
Comment 7 stadt 2007-01-29 20:21:54 UTC
Tried now src680 m201 (build by pavel janik). Everything is okay, no crash at
all. svg filter installs flawless, also extension manger doens't crash when I
try to open it with installed svg filter.

BTW. Installed Java in both scenarios (2.2M4 and src980-m201) was always 1.6.0
build b105, language was always german
Comment 8 joerg.skottke 2007-01-30 07:38:40 UTC
Hi stadt,

this is quite possible since there have been a few fixes in this area recently.
I guess i can close/invalidate the issue then.
Comment 9 joerg.skottke 2007-01-30 07:38:58 UTC
Zu die Kuh.
Comment 10 stadt 2007-01-31 16:31:12 UTC
Sorry have to reopen it. OOo 2.2 Milestone 5 shows same behaviour as Milestone 4
= OOoCrash
Comment 11 joachim.lingner 2007-02-01 09:09:38 UTC
I still cannot reproduce this. However, I found a similar issue. When unopkg.exe
is started  and one opens the tree of shared extensions (there must be at least
one) and then presses the close button, then a crash occurrs. I experienced this
on Windows XP but I am sure this also happens on all other plattforms. Since
this is different I will open a separate issue. 

JL->JSK: As I said I cannot reproduce this on my machine. Please try to
reproduce this with the help of your colleages, that is on different machines.
Comment 12 joerg.skottke 2007-02-01 12:11:42 UTC
move target
Comment 13 joerg.skottke 2007-02-01 12:15:38 UTC
Ouch - wrong issue. Back to 2.2
BTW: A crash is P2, adjusting
Comment 14 joerg.skottke 2007-02-01 13:33:24 UTC
I've completed my quest through QA and development.

Still no success. Tried on a number of machines ranging from pII/300 up to
really fast Athlon64 w. multiple cores. No Intel Core2 duo though, we simply do
not have this sort of hardware. Multiple Dual Xeon cores, yes.

There must be something else.  I ruled out Java, path and language.

Does the crashreporter come up?
Comment 15 joerg.skottke 2007-02-01 13:59:57 UTC
Just another idea: What is your md5sum for the extension? I got

cf03671d1488dc12557e366094fa5662  svg-import-r2185.uno.zip
Comment 16 stadt 2007-02-01 19:01:11 UTC
I installed the identical OOo 2.2 M5 (build provided by Pavel Janik) on a second
hardware-different machine, a AMD Turion Notebook with integrated S3 graphics,
this time OOo lands on drive C:. OOo was (on both machines) uninstalled before
installing OOo 2.2 M5. 
Same crash happens. 
I tried to download svg-import-r2185.uno.zip a-new and to install this download
(on both machines), same crash happens again.

Not to mention that on both OOo 2.1 works fine (with installed svg-filter), also
OOo src680 m201 on the first one.

So what's in common between both (with the possibility to affect OOo) ?

1. Windows XP Home SP2 (latest fixes)(Sorry, I can't disable this ;-)
2. Java 1.6 latest official build (b105), disabling Java in OOo doesn't help.
3. AVG Antivirus 7.5, disabling AVG control Center doesn't help.
4. Rainlendar Calendar in autostart (in one case V 2.02 in the other 0.22.1) 
disabling Rainlender doesn't help.
5. OOo 2.2 M5

OOo shutdowns down, and restarts automatically showing the screen to restore the
 document (is this the crashreporter ?) telling me that an unexpected error
occured. Thats all.
Comment 17 joerg.skottke 2007-02-02 07:50:20 UTC
Hi stadt,

thanks for the large bunch of information. Unfortunately this does not help
much. However, working from home today i have a load of alternative hardware so
i'm going to retry with that.

When you restart the application you get the document recovery. After recovering
the document you should be guided to the crashreporter which asks you to provide
a description. There is a button to view the report. Please copy the content of
the report into this issue.
Comment 18 stadt 2007-02-02 08:11:14 UTC
Sorry, when recovering the document after the crash I get only the document and
no crash-reporter at all.

BTW. could it be that something with Pavel Janiks Mn-builds is wrong ? I also
miss  in M4 and and M5 the Update-option (which is in his SRC builds).

If there is anything else I can do to track down the issue please tell. 
In my work I could (next week) test the builds too on very different machines
(starting from Celeron 450Mhz up to AMD Athlons), but after my test on the
second machine I'm not so sure that it's hardware dependend.

Comment 19 Olaf Felka 2007-02-02 08:23:39 UTC
I don't wan't to blame Pavels builds but is there a chance to check this
extension on a OOo mirror build (e.g.
http://ftp.stardiv.de/pub/OpenOffice.org/developer/)? There might be a small
chance that we have a tiny difference between Pavels and OOo mirror builds?
Comment 20 leiflodahl 2007-02-02 12:00:56 UTC
I have made a check on two computers with Pavels Da-build and the SUN Da-build.
In both cases I find that on one computer the function works, and on the other
it crashes. 

The machine that has problems is my laptop Thinkpad T42 with WinXP sp2. Tried
(on both computers) with Jave JRE 1.5.09 and 1.6 with same result. Tried with
the SUN English build on both computers: Same result.

I even tried to 'clean-up' the computer for old OpenOffice.org stuff by removing
OpenOffice.org from the Program files, Documents and settings and registration
database. No change: OpenOffice is still crashing on one mashine. 

Conclusion:
It seems like a computer depending problem that will be VERY difficult to identify. 

Suggestion:
Why don't we keep it in mind and see if anything turns up in the future. If this
was a problem for many people, we would have heard about it.
Comment 21 joerg.skottke 2007-02-02 12:48:28 UTC
I'm a little confused by the fact that the crashreporter doesn't come up. It
should, and i see no way of getting to the cause of the crash without any
stacktrace.

After the documentrecovery there should be a next button that allows you to
proceed to the crashreporter...
Comment 22 stadt 2007-02-02 15:25:56 UTC
With the 'official' M5 build OOo-Dev-ODF680-M5 .... the extension manager
doesn't crash. 
Verified on both my testing machines (Intel Core 2 Duo Workstation, AMD Turion
Notebook, both with WinXP SP2).

As with this build the update-option is also available (contrary to Pavel Janiks
M 4/5 builds) my strong guess: the issue is related to Pavels builds. Curiously
his SRC680-201 build is fine. Maybe something related to M-specific variables in
his build-script. Or should the variing language ('official' builds are only
available in english, Pavel's in german and other languages too) be the cause ?

Maybe somebody informs Pavel Janik ?

In my opinion the issue could be closed. Am I allowed to do so ?
Comment 23 sparcmoz 2007-02-03 04:10:40 UTC
I can see this on mac intel with different extension, using unpatched upstream
sources
Thread 15 Crashed:
0   deploymentgui680mxi.uno.dylib 	0x0df1dddd
dp_gui::Updatability::Thread::execute() + 1447 (dp_gui_updatability.cxx:233)
1   deploymentgui680mxi.uno.dylib 	0x0df1cee9 dp_gui::Thread::run() + 25
(dp_gui_thread.cxx:79)
2   deploymentgui680mxi.uno.dylib 	0x0df4111e threadFunc + 30 (thread.hxx:197)
3   libuno_sal.dylib.3            	0x017dd77e osl_yieldThread + 550
4   libSystem.B.dylib             	0x90023d87 _pthread_body + 84

That the mix of i & j variables in line 233/234 looks suspicious, although it
appears not all compilers are upset?

for (sal_Int32 j = 0; j < ps.getLength(); ++i) {
   if (ps[i]->getUpdateInformationURLs().getLength() != 0)

This code was introduced by jl49, i70481
Suggested patch attached.

Comment 24 sparcmoz 2007-02-03 04:11:52 UTC
Created attachment 42706 [details]
stop craashing extension manager
Comment 25 sparcmoz 2007-02-03 04:22:22 UTC
*** Issue 73167 has been marked as a duplicate of this issue. ***
Comment 26 sparcmoz 2007-02-03 06:26:44 UTC
To be more certain, I got some more information with a trace:
i=0, ps.getLength()=2
i=0, ps.getLength()=2
i=1, ps.getLength()=2
i=2, ps.getLength()=2
Error: File
/Users/jim/vanilla/solver/680/unxmacxi.pro/inc/com/sun/star/uno/Sequence.hxx,
Line 200: ### illegal index of sequence!
Comment 27 pavel 2007-02-03 09:03:29 UTC
Patch helped here on Mac OS X/Intel. Without it, it crashes on line sparcmoz mentioned.
Comment 28 stadt 2007-02-03 11:13:54 UTC
Just a quick note: Extension manager in OOo 2.2 src680 m202 german build by
Pavel Janik works (on WinXP SP2)
Comment 29 joachim.lingner 2007-02-05 09:11:24 UTC
Thank you all for investigating this problem. Sparcmoz has found a bug that will
not occur in Sun builds, because there is a condition which will always be
fulfilled for SunBuilds. The condition is the availability of an update url. I
suppose Pavel's builds do not have such build-in update URL.
Comment 30 joachim.lingner 2007-02-05 09:31:31 UTC
.
Comment 31 joachim.lingner 2007-02-05 12:33:33 UTC
@jsk: The crash can be reproduced in a Sun build by removing the Update...
entries in office/program/version.ini
Comment 32 joachim.lingner 2007-02-05 12:34:21 UTC
.
Comment 33 b.osi.ooo 2007-02-05 16:59:21 UTC
Not fixed completely:
on win32, disable entrys in version.ini by putting a hash (#) in front of entry
starting OOo for the first time by calling soffice.exe
starting extension manager: Tools->Extensions
adding extension e.g. simpleLicense.oxt
unfold all, leave selection on shared extensions
-> close
-> freeze/looping OOo
only seen on win32, not reproduceable on solaris
Comment 34 b.osi.ooo 2007-02-05 16:59:55 UTC
back to developer
Comment 35 joachim.lingner 2007-02-06 14:37:41 UTC
.
Comment 36 joachim.lingner 2007-02-06 15:54:30 UTC
Thorsten please verify.
Comment 37 b.osi.ooo 2007-02-07 08:49:49 UTC
verified and working in CWS jl56 even on my system
Comment 38 joachim.lingner 2007-02-08 11:28:18 UTC
*** Issue 74330 has been marked as a duplicate of this issue. ***
Comment 39 sparcmoz 2007-02-09 04:37:24 UTC
Please note that the EIS says integrated (m5) but this cws is not in OOF680_m6
yet. So I made a diff and tested m6 plus jl56 on GNU/Linux SPARC and the
Extension Manager now works as expected, with no crashes.Tested from a running
office, from the command line and command lin gui - uno.pkg and .oxt. thanks.
Comment 40 joachim.lingner 2007-02-09 07:36:53 UTC
Thanks for confirming the fix. The cws will be integrated in  m7.
Comment 41 b.osi.ooo 2007-02-12 09:17:24 UTC
Now integrated into OOF680m7 - closing
Comment 42 leiflodahl 2007-02-13 10:30:38 UTC
Confirmed in m7. - Thanks.