Issue 74651 - Removing a graphic image does not change isModified()
Summary: Removing a graphic image does not change isModified()
Alias: None
Product: App Dev
Classification: Unclassified
Component: api (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All Windows XP
: P3 Trivial
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
: 76084 (view as issue list)
Depends on:
Reported: 2007-02-19 10:00 UTC by bmarcelly
Modified: 2017-05-20 11:27 UTC (History)
6 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Basic macro removing an image from sheet1 of the document (49.59 KB, application/vnd.oasis.opendocument.spreadsheet)
2007-02-19 10:01 UTC, bmarcelly
no flags Details
Crash if the image is already selected (49.15 KB, application/vnd.oasis.opendocument.spreadsheet)
2007-03-14 10:35 UTC, aladdin2k7
no flags Details
fix the crash issue (2.50 KB, text/plain)
2007-05-17 16:17 UTC, mloiseleur
no flags Details
The second part, which fix the original problem (1.37 KB, text/plain)
2007-05-17 20:26 UTC, mloiseleur
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description bmarcelly 2007-02-19 10:00:03 UTC
Removing with API an image from a Calc document does not change the modified state of 
the document. The user may close the document without change warning.
Next attachment is a Basic example.

Same behaviour already exists on 1.1.5.
Comment 1 bmarcelly 2007-02-19 10:01:48 UTC
Created attachment 43157 [details]
Basic macro removing an image from sheet1 of the document
Comment 2 kpalagin 2007-02-19 11:11:40 UTC
Confirming with 2.2m7 - after removing the image File\Save does not become 
available and doc can be closed without warning.
Comment 3 jsc 2007-02-28 09:58:17 UTC
jsc -> nn: seems to be one for you
Comment 4 aladdin2k7 2007-02-28 10:21:51 UTC
Moreover, if you try to execute this routine without saving the document, it 
will crash OOo (tested on OOo 2.1).

- Create new spreadsheet
- Insert image
- Execute the routine
Comment 5 aladdin2k7 2007-03-05 09:47:15 UTC
To be more precisely, it happens when you select the image (by clicking on it) 
even the document is saved or not. Then execute the macro, it will crash OOo 
2.1 .

Comment 6 aladdin2k7 2007-03-14 10:35:50 UTC
Created attachment 43696 [details]
Crash if the image is already selected
Comment 7 aladdin2k7 2007-03-21 16:23:53 UTC
Same result with OOo 2.2rc3.
Comment 8 mloiseleur 2007-05-17 16:17:07 UTC
Created attachment 45190 [details]
fix the crash issue
Comment 9 mloiseleur 2007-05-17 16:17:38 UTC

  Is there a patch to fix the crash. I don't really know where to hack for the
"isModified" thing. 
Comment 10 mloiseleur 2007-05-17 16:18:36 UTC
mloiseleur -> nn : can you give me some hint ? or better, fix it ? :). 


Comment 11 mloiseleur 2007-05-17 20:26:05 UTC
Created attachment 45197 [details]
The second part, which fix the original problem
Comment 12 mloiseleur 2007-05-17 20:27:12 UTC
Well, I have found how to make the second patch, yeah ^_^. 
I add the 'remove' action to the undo list. It fixes all sides effect and
permits to undo/redo the remove part of the macro, if needed.

I'll ask Eike/Niklas tomorrow to see if the patch is correct.

-> nn : Do I take this one ? Or do you want to add it on your cws ?

Comment 13 niklas.nebel 2007-05-25 14:42:15 UTC
This is about drawing layer, not Calc code.
Comment 14 mloiseleur 2007-05-28 06:24:26 UTC
-> aw : any news on thoses patches ?

Comment 15 Armin Le Grand 2007-05-28 12:36:42 UTC
AW: It's about UNO API implementation of the DrawingLayer
(svx/source/unodraw/unopage.cxx), that's CL. Setting to him.
AW->mloiseleur: We have public holdiay in germany today, but who cares :-)
Comment 16 clippka 2007-05-29 12:30:36 UTC
I will have a look
Comment 17 clippka 2007-06-20 12:49:31 UTC
patch looks nice, will add it to 2.3
Comment 18 mloiseleur 2007-06-20 13:09:42 UTC
Good news, thanks.
Comment 19 clippka 2007-07-04 12:26:10 UTC
I will wait one more week before I apply this patch unti the cws for the report
designer is in the master as there may be a collision with the changes that this
cws introduces...
Comment 20 clippka 2007-07-04 14:15:05 UTC
*** Issue 76084 has been marked as a duplicate of this issue. ***
Comment 21 clippka 2007-07-17 12:24:52 UTC
retarget, report designer is not done yet and it is to risky to fix an issue
like this on such a late time. Also this is no regression so behavior, even if
it can cause crashes, stays like it was for the last years.
Comment 22 jsc 2007-10-08 15:13:09 UTC
jsc (api project lead) -> cl: can you please take care of this patch and take
the appropriate action asap.
Comment 23 clippka 2007-11-28 17:04:15 UTC
as expected this patch clashes with the changes from the report designer cws.
I have to discuss this with OJ
Comment 24 clippka 2008-01-11 13:20:28 UTC
discussion with oj didn't give any hints how to gracefully resolve this. I wish
I had time to work on api and undo problems but I have to shift it to 3.0
Comment 25 cno 2008-02-05 13:27:35 UTC
Related: same when you change a property (for example Print) of a graphic in
Writer by API 
Comment 26 clippka 2008-06-18 13:06:58 UTC
currently makes no sense to just fix the given case, that will never be stable.
We have to fix the underlying issue that some api generates undo and some none
Comment 27 ooo 2009-04-29 13:28:02 UTC
KA=>CL: any news regarding setting the final target for this task? It seems to
be more work to be done than initially expected.
Comment 28 clippka 2009-06-04 13:59:16 UTC
currently no updates. we have a general problem with api not creating undo in
all cases. This has to be cleaned up sooner or later. Unfortunately this is to
much for my current schedule
Comment 29 Rob Weir 2013-03-11 15:00:39 UTC
I'm adding this comment to all open issues with Issue Type == PATCH.  We have 220 such issues, many of them quite old.  I apologize for that.  

We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0.

If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know.

On the other hand, if the patch is no longer relevant, please let us know that as well.

If you have any general questions or want to discuss this further, please send a note to our dev mailing list:


Comment 30 Marcus 2017-05-20 11:27:47 UTC
Reset assigne to the default "".