Apache OpenOffice (AOO) Bugzilla – Issue 74651
Removing a graphic image does not change isModified()
Last modified: 2017-05-20 11:27:47 UTC
Removing with API an image from a Calc document does not change the modified state of the document. The user may close the document without change warning. Next attachment is a Basic example. Same behaviour already exists on 1.1.5.
Created attachment 43157 [details] Basic macro removing an image from sheet1 of the document
Confirming with 2.2m7 - after removing the image File\Save does not become available and doc can be closed without warning.
jsc -> nn: seems to be one for you
Moreover, if you try to execute this routine without saving the document, it will crash OOo (tested on OOo 2.1). - Create new spreadsheet - Insert image - Execute the routine
To be more precisely, it happens when you select the image (by clicking on it) even the document is saved or not. Then execute the macro, it will crash OOo 2.1 .
Created attachment 43696 [details] Crash if the image is already selected
Same result with OOo 2.2rc3.
Created attachment 45190 [details] fix the crash issue
Hello, Is there a patch to fix the crash. I don't really know where to hack for the "isModified" thing.
mloiseleur -> nn : can you give me some hint ? or better, fix it ? :). Thanks,
Created attachment 45197 [details] The second part, which fix the original problem
Well, I have found how to make the second patch, yeah ^_^. I add the 'remove' action to the undo list. It fixes all sides effect and permits to undo/redo the remove part of the macro, if needed. I'll ask Eike/Niklas tomorrow to see if the patch is correct. -> nn : Do I take this one ? Or do you want to add it on your cws ?
This is about drawing layer, not Calc code.
-> aw : any news on thoses patches ?
AW: It's about UNO API implementation of the DrawingLayer (svx/source/unodraw/unopage.cxx), that's CL. Setting to him. AW->mloiseleur: We have public holdiay in germany today, but who cares :-)
I will have a look
patch looks nice, will add it to 2.3
Good news, thanks.
I will wait one more week before I apply this patch unti the cws for the report designer is in the master as there may be a collision with the changes that this cws introduces...
*** Issue 76084 has been marked as a duplicate of this issue. ***
retarget, report designer is not done yet and it is to risky to fix an issue like this on such a late time. Also this is no regression so behavior, even if it can cause crashes, stays like it was for the last years.
jsc (api project lead) -> cl: can you please take care of this patch and take the appropriate action asap.
as expected this patch clashes with the changes from the report designer cws. I have to discuss this with OJ
discussion with oj didn't give any hints how to gracefully resolve this. I wish I had time to work on api and undo problems but I have to shift it to 3.0
Related: same when you change a property (for example Print) of a graphic in Writer by API
currently makes no sense to just fix the given case, that will never be stable. We have to fix the underlying issue that some api generates undo and some none
KA=>CL: any news regarding setting the final target for this task? It seems to be more work to be done than initially expected.
currently no updates. we have a general problem with api not creating undo in all cases. This has to be cleaned up sooner or later. Unfortunately this is to much for my current schedule
I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob
Reset assigne to the default "issues@openoffice.apache.org".