Issue 75194 - Automatic Position and Size get lost after save and reload
Summary: Automatic Position and Size get lost after save and reload
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 72764
  Show dependency tree
 
Reported: 2007-03-07 10:02 UTC by kla
Modified: 2013-02-24 21:22 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch_080714 (5.33 KB, text/plain)
2008-07-14 04:34 UTC, weiz 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kla 2007-03-07 10:02:28 UTC 
Autmatic Position and Size get lost after save and reload.
Comment 1 bjoern.milcke 2007-03-07 10:04:27 UTC 
setting keyword, accepting
Comment 2 bjoern.milcke 2007-03-07 10:05:22 UTC 
*** Issue 75192 has been marked as a duplicate of this issue. ***
Comment 3 bjoern.milcke 2007-03-07 10:12:13 UTC 
*** Issue 75193 has been marked as a duplicate of this issue. ***
Comment 4 bjoern.milcke 2007-03-07 12:13:42 UTC 
This fix requires an ODF file format change that will hopefully be available in
ODF 1.2.
Comment 5 bjoern.milcke 2007-03-07 12:33:17 UTC 
Changed subject, as this also happens in the old chart, so this is no regression
in the new implementation.

In the old chart, however, there is some magic that sometimes is successful in
determining automatic positions and sizes, so sometimes it may work, but most of
the times it doesn't. (And at least theoretically, it might also happen that a
manual size/position may be interpreted as automatic on error).
Comment 6 Martin Hollmichel 2007-09-12 13:13:39 UTC 
move to target 3.x according http://wiki.services.openoffice.org/wiki/Target_3x
Comment 7 IngridvdM 2008-07-03 11:39:59 UTC 
change owner
Comment 8 IngridvdM 2008-07-10 20:55:18 UTC 
@weiz: We need a new boolean property 'AutomaticPosition' at the TitleWrapper,
LegendWrapper and DiagramWrapper. This should be mapped to a new boolean token
'auto-position' in xmloff. Furthermore we need a property 'AutomaticSize' at the
DiagramWrapper. It should be mapped to a new token 'auto-size' in xmloff.
Comment 9 weiz 2008-07-14 04:33:05 UTC 
@iha: the patch is finished.
I think it's too complicated if we add the new property for the TitleWrapper,
LegendWrapper and DiagramWrapper separately, so I created two new 
files "WrappedAutomaticPositionProperties.hxx" 
and "WrappedAutomaticPositionProperties.cxx" to do this work. 
Please let me know your suggestions about the patch. Thank a lot!
Comment 10 weiz 2008-07-14 04:34:19 UTC 
Created attachment 55097 [details]
patch_080714
Comment 11 IngridvdM 2008-07-16 12:16:34 UTC 
@weiz, thanks for the patch! Some changes: I added a missing entry in the
makefile and added the new properties to the according idl files to document
them. There was an additional change necessary in xmloff, to avoid that an
explicit size and position are set at the diagram after AutomaticPosition and
AutomaticSize were set to true (look at SchXMLPlotAreaContext.cxx, v1.47.38.1).
Comment 12 IngridvdM 2008-07-16 13:04:06 UTC 
Fixed in CWS chart30. For testing:
-Create a chart with sub title and legend on top
-save, reload and insert a main title
-> subtitle, legend and diagram should move automatically to make room for the
new title.

-No move the sub title the legend and the diagram a bit
-save, reload and remove the main title
-> subtitle, legend and diagram should not move as they are not positioned
automatically anymore.
Comment 13 IngridvdM 2008-09-10 16:30:12 UTC 
@KLA, please verify in CWS chart30.
Comment 14 kla 2008-09-16 07:39:53 UTC 
Seen ok in CWS chart30 -> verified
Comment 15 kla 2008-10-08 15:21:36 UTC 
seen ok in current master -> closed