Apache OpenOffice (AOO) Bugzilla – Issue 75889
aquavcl01: Extended tooltips text truncated
Last modified: 2007-07-09 22:43:05 UTC
m202 plus the first patch from issue 74392 (29March) Activate the Extended Tooltips. When a tooltip is displayed it will be seen the tooltips text is truncated. Possibly only the first line of text is displayed.
Issue confirmed. Probably a sallayout issue. Sébastien ?
Created attachment 44057 [details] Extended tooltips -> only the first line does appear ( vcl API)
ericb->sparcmoz just wondering ... maybe mikesic simplified too much the list of events managed by help windows ?
Created attachment 44059 [details] same extended tooltip using native API
sparcmoz->ericb2: no, I just checked and the issue is already there in the unpatched m202. Mike's patch provides the stability needed to allow these issues to be observed properly and reported.
here is the console output from both patched and unpatched m202. The full text is reported here but not in the tooltip. -->LayoutText - mnTextOfs:46 in 171 : Click to open a toolbar where you can click a background color for a paragraph. The color is applied to the background of the current paragraph or the selected paragraphs.
fails to draw the second line of the tooltip in ATSLayout::DrawText line 419 theErr = ATSUDrawText( maATSULayout, mnTextOfs, mnTextLen,Long2Fix(aPos.X()), Long2Fix(aPos.Y())); with theErr= -8792 which means ( http://developer.apple.com/documentation/Carbon/Reference/ATSUI_Reference/Reference/reference.html#//apple_ref/doc/uid/TP30000309-CH5g-RCM0008 ) The text range extends beyond the limits of the text layout object’s text range.
A change in salatslayout.cxx line 264 seems to fix this: - theErr = ATSUSetTextPointerLocation(maATSULayout, rArgs.mpStr, 0, runLength, runLength); + theErr = ATSUSetTextPointerLocation(maATSULayout, rArgs.mpStr, runFrom, runLength, runLength); so far no side effects observed. Patch to follow.
Created attachment 44258 [details] proposed patch
This patch may cause problem in displaying multiline text, please testit with the licence agreement screen. Tht fact to force the runFrom to Zero is ok for all texts tha tare layouted in one pass, for long text it will not work.
With the patch attached the licence text (in the first start wizard) looks normal to the user, and the tooltips display correctly. I also tested with HELP_DEBUG=true and the slotID are displayed. I notice in the console log that the text is processed in small chunks. I have chopped the lines to fit here, but the full text is displayed in the log, and displays correctly in the wizard. -->AdjustLayout -->FillDXArray --->~ATSLayout -->LayoutText - mnTextOfs:392 in 412 : This license, the Lesser General Public -->InitGIA Fin InitGIA -->AdjustLayout -->FillDXArray --->~ATSLayout -->LayoutText - mnTextOfs:0 in 431 : When we speak of free software, we are -->InitGIA Fin InitGIA -->AdjustLayout
I did display the license text as suggested, and I found no issue with the display of text. (Intel MacBook)
The last patch fixes much more than tooltips ;-) E.g. in First Start wizard, multiline texts are displayed. Please commit it.
last patch committed
Added issue to aquavcl01 cws
Verified in aquavcl01. Tooltips are now shown correctly.
Change target milestone to 2.3.
Extended tips are OK in SRC680_m220. Closing.
Works on with SRC680_m220 Closing