Issue 75927 - RNG: invalid attribute enable-numbering
Summary: RNG: invalid attribute enable-numbering
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: save-export (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: christian.guenther
QA Contact: issues@graphics
URL:
Keywords:
: 92442 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-03-30 16:29 UTC by clippka
Modified: 2009-02-17 13:31 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description clippka 2007-03-30 16:29:06 UTC
Cloned task for *** Issue 36217 *** with target milestone: OOo 2.2.1
Comment 1 clippka 2007-03-30 16:31:37 UTC
currently impress and draw write out the attribute enable-numbering which is not
part of the ODF format.

In issue 36217 I already addressed that documents without this attribute are
imported correctly.
Comment 2 clippka 2007-07-09 09:19:31 UTC
export is now corrected if the save backward compatible configuration entry is set
Comment 3 clippka 2007-07-09 12:59:34 UTC
I had to remove this fix and also removed the import fix from issue 36217.
Turns out we also exported list-items for paragraphs with enable-numbering =
false :-(
Comment 4 clippka 2008-05-28 10:37:11 UTC
I did the following core changes

Outliner API

- The depth is now always from -1 to 9 for each type of shape.
A depth of -1 means that the paragraph is not numbered, therefore
the indents of the bullet is not used and no bullet is painted.
For a paragraph with depth >= 0, the bullet is painted and the
indents from the bullet are added to the lr space item.

- The type for the paragraph depth was changed from USHORT to sal_Int16,
also the SfxItem EE_PARA_OUTLLEVEL changed to SfxInt16Item.

- The SfxItem EE_PARA_BULLETSTATE changed to a SfxBoolItem and also changed
the meaning exclude the paragraph from the numbering. Meaning the indends of
the bullet format for the current paragraph depth is used and space for a
bullet is put before the text but the actual bullet is not painted and for a
numbering this paragraph is not counted. This is now an item that is only
valid for paragraphs, not for styles.

- added numbering start value like in writer
+ virtual sal_Int16 GetNumberingStartValue( sal_uInt16 nPara );
+ virtual void SetNumberingStartValue( sal_uInt16 nPara, sal_Int16
nNumberingStartValue );
This sets the start value for the given paragraph that is used if the paragraph
is a numeration.
The value -1 means that the paragraph is counted as usual

- added numbering restart like in writer
+ virtual sal_Bool IsParaIsNumberingRestart( sal_uInt16 nPara );
+ virtual void SetParaIsNumberingRestart( sal_uInt16 nPara, sal_Bool
bParaIsNumberingRestart );
This bool forces a numbering for this paragraph to restart if it is true.

UNO API

- The property "EnableNumbering" was removed
- The property "NumberingIsNumber" was added and has the same meaning as in writer
- The property "ParaIsNumberingRestart" was added and has the same meaning as in
writer
- The property "NumberingStartValue" was added and has the same meaning as in writer
Comment 5 clippka 2008-05-29 13:58:15 UTC
tasks not doable for OOo 3.0 because of user interface freeze will be handled in
OOo 3.1 with issue 90113
Comment 6 clippka 2008-05-30 16:38:00 UTC
changes to the bullet handling for the user

- it is now possible to have a before text indent and first line indent that is
independend of the position settings for active numberings and bullets
- switching of numbering and bullets now disables the use of the numbering and
bullets position completly
- it is now possible to use the numbering style "None" in the "Customize" tab
page of the "Bullets and Numbering" dialog
- it is possible to remove the bullet from a paragraph by pressing the
"backspace" key when the cursor is right behind the bullet. Such paragraphs act
like in the writer, the bullet is not painted and the paragraph is not counted
for numberings.
- Numberings now count correct, meaning paragraphs with no numbering or
different numberings are not counted.

file format changes that affect the user

since the bullets and numbering are now exported odf conform and the previous
format written by impress&draw was not odf conform, documents created with
versions containing this fix will be imported wrongly by older versions.
Namingly OOo 3.0 beta 1 and OOo 2.x/1.x. The same is true for StarOffice 9 beta
and and StarOffice 8&9.

A version with this fix try to convert documents saved by older versions. A 1:1
representation is not always possible but most times the differences are hard to
spot.  
Comment 7 clippka 2008-05-30 17:03:37 UTC
send to qa
Comment 8 christian.guenther 2008-06-03 14:53:28 UTC
CGU: Verified in cws impressodf12
Comment 9 michael.brauer 2008-08-05 07:38:59 UTC
*** Issue 92442 has been marked as a duplicate of this issue. ***
Comment 10 wolframgarten 2009-02-17 13:31:55 UTC
Closed.