Issue 77572 - Remove deprecated gdi functions
Summary: Remove deprecated gdi functions
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m211
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: ericb
QA Contact: issues@porting
URL:
Keywords: aqua
Depends on:
Blocks:
 
Reported: 2007-05-19 03:55 UTC by msicotte
Modified: 2007-07-09 22:09 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description msicotte 2007-05-19 03:55:05 UTC 
Context 3 : gdi / Color + Pixmaps    
file : vcl/aqua/source/gdi/salcolorutils.cxx  
deprecated functions : GetGDevice / MakeITable / GetCTSeed / GetPixDepth
/GetCTable / 


Context3 4: gdi / Geometry + Pixmaps

file : vcl/aqua/source/gdi/salpixmaputils.cxx
deprecated functions : SetRect / GetGDevice (dupe) / NewPixMap / GetPixelsState
/ SetPixelsState / LockPixels / DisposePixMap
Comment 1 msicotte 2007-05-19 03:55:25 UTC 
keyword
Comment 2 eric.bachard 2007-05-19 08:23:09 UTC 
This issue is IMHO fixed ( Mox deleted everything), but I wonder if some missing
function can cause the recurrent crash caused by getPixelSize() ... 

ericb->pl

What do you think ?
Comment 3 philipp.lohmann 2007-05-21 09:38:12 UTC 
? There does not seem to be any getPixelSize() in vcl ?
Comment 4 eric.bachard 2007-05-21 16:05:14 UTC 
ericb->pl


Sorry GetPixelSize(). the crash is very easy to produce. 

Empty writer document ->click on spellcheck


The log ( Mac OS X10.4.8 Intel ):

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_PROTECTION_FAILURE (0x0002) at 0x00000008

Thread 0 Crashed:
0   libvcl680mxi.dylib             	0x011b2ba7 Window::GetSizePixel() const + 23
1   libcui680mxi.dylib             	0x1dfe9709 CreateDialogFactory + 1540113
Comment 5 pavel 2007-06-20 13:30:36 UTC 
no warnings -> verified.

File new issue for new stuff, please.
Comment 6 pavel 2007-06-28 11:07:58 UTC 
Set target to 2.3.
Comment 7 pavel 2007-07-09 22:09:56 UTC 
VCL is still WaE clean on SRC680_220.

Closing.