Issue 79522 - Make chart2 warning-free on Solaris
Summary: Make chart2 warning-free on Solaris
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: chart (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: bjoern.milcke
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-12 10:20 UTC by bjoern.milcke
Modified: 2013-02-24 21:18 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjoern.milcke 2007-07-12 10:20:23 UTC 
Remove existing warnings when compiling chart2 on Solaris. If all warnings are
removed, remove chart2 from the MODULES_WITH_WARNINGS list in unxsols4.mk and
unxsoli4.mk files in solenv/inc.

This is a predecessor task to Issue 69281

For details on warning removal see
<http://wiki.services.openoffice.org/wiki/Writing_warning-free_code>
Comment 1 bjoern.milcke 2007-07-12 10:23:43 UTC 
Of course this one is a successor task to Issue 69281 (not a predecessor) :-)
Comment 2 Stephan Bergmann 2007-07-13 08:12:09 UTC 
@bm:  Is this targeting OOo 2.4?
Comment 3 bjoern.milcke 2007-07-13 08:17:41 UTC 
@sb: Is that a question? ;-) Well, we will do that probably shortly after 2.3
release, so yes. I change it.
Comment 4 bjoern.milcke 2007-08-01 07:27:33 UTC 
Done in CWS chart11. Adapted unxsols4.mk and unxsoli4.mk in solenv/inc. build
debug=t also works without warnings.
Comment 5 bjoern.milcke 2007-08-01 11:39:44 UTC 
Also tested non-pro with "debug=t".
Comment 6 bjoern.milcke 2007-09-05 15:15:25 UTC 
solenv/inc/unxsols4.mk has this list of modules with warnings on the CWS:

MODULES_WITH_WARNINGS := \
    extensions \
    soldep \
    sw

And chart2 compiles there, so it works.
Comment 7 bjoern.milcke 2007-09-26 14:13:28 UTC 
The list for warning-projects is the same as posted before in m230 (also for
unxsoli4.mk), and the Solaris build was successful, so: verified on master
SRC680.m230 -> closing