Issue 79808 - Don't show cell validation message when title and message are empty
Summary: Don't show cell validation message when title and message are empty
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: 680m213
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: frank
QA Contact: issues@sc
URL:
Keywords: ms_interoperability
Depends on:
Blocks:
 
Reported: 2007-07-19 23:59 UTC by kyoshida
Modified: 2013-08-07 15:14 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
proposed patch (834 bytes, patch)
2007-07-19 23:59 UTC, kyoshida 		no flags Details | Diff
revised patch (806 bytes, patch)
2007-07-20 14:54 UTC, kyoshida 		no flags Details | Diff
even more revised patch (706 bytes, patch)
2007-07-20 16:41 UTC, kyoshida 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kyoshida 2007-07-19 23:59:07 UTC 
This simple patch disables displaying input/error validation messages when both
the title and the message are empty.  This is useful especially for Excel
documents imported to Calc that contains cell validation, because Excel seems to
leave the "show input message" on by default, even when the user doesn't set it
explicitly.
Comment 1 kyoshida 2007-07-19 23:59:42 UTC 
Created attachment 46929 [details]
proposed patch
Comment 2 kyoshida 2007-07-20 00:02:30 UTC 
setting the ms_interoperability keyword....
Comment 3 kyoshida 2007-07-20 06:08:52 UTC 
Actually, Excel (2007) does not display the input validation message unless both
the title and the message are non-empty.
Comment 4 kyoshida 2007-07-20 06:12:20 UTC 
Sorry, my earlier observation was incorrect.  In Excel, it only depends on the
empty/non-empty state of the message.
Comment 5 kyoshida 2007-07-20 14:54:32 UTC 
Created attachment 46941 [details]
revised patch
Comment 6 kyoshida 2007-07-20 16:41:00 UTC 
Created attachment 46945 [details]
even more revised patch
Comment 7 kyoshida 2007-07-20 16:42:57 UTC 
Actually the first two patches would alter the state of "show input/error
messages", which is not desirable for round-trip fidelity with Excel.

This new patch will preserve the state, but simply not show when the message is
empty.
Comment 8 kyoshida 2007-09-15 00:55:13 UTC 
nn: any comment on this?
Comment 9 niklas.nebel 2007-10-05 18:16:44 UTC 
This means that someone who previously entered a title only won't see it
anymore. But for interoperability's sake, I guess we can accept that. So it's
now on CWS "calc45": Input help is shown only if the "Input help" text isn't empty.
Comment 10 niklas.nebel 2007-12-03 15:59:57 UTC 
reassigning to QA for verification
Comment 11 frank 2007-12-07 15:19:19 UTC 
found fixed on cws calc45 using Solaris, Linux and Windows build
Comment 12 frank 2008-02-14 11:40:01 UTC 
found integrated on master OOHm5 using Solaris, Linux and Windows build