Issue 7983 - Undo does not know about page format changes
Summary: Undo does not know about page format changes
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.1 RC2
Hardware: All All
: P5 (lowest) Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords:
: 22335 22368 23540 26627 (view as issue list)
Depends on:
Blocks:
 
Reported: 2002-09-30 21:20 UTC by bobharvey
Modified: 2013-08-07 14:41 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description bobharvey 2002-09-30 21:20:01 UTC
I have confirmed this on Win32 & Linux versions of 1.0.1

To demonstrate:
1.  Open new document (it happens on old ones too)
2.  Type "Jock"<CR>
3.  Type "Mary"
4.  Select format, page, page (or right-click, or use stylist)
5.  Change portrait to landscape.  Page changes.
6.  Hit "undo"

What I would expect:    Page to go back to portrait
What actually happens:  Page stays Landscape, "Mary" vanishes.
Comment 1 jack.warchold 2003-08-06 18:07:49 UTC
jw: change owner to jw
sorry for the late reply.
i will ask for the standard behaviour of undoing page formats
change owner to jw
change status to confirmed -> new
Comment 2 jack.warchold 2003-08-07 09:47:38 UTC
jw: changed owner to ama
set prio to P5
set platform to all
set version to OOo1.1
Comment 3 jack.warchold 2003-08-07 09:56:46 UTC
.
Comment 4 jack.warchold 2003-08-07 09:57:45 UTC
.
Comment 5 andreas.martens 2003-08-07 17:08:20 UTC
For OOo1.1 we don't have an Undo functionality for style changes like
page styles. We'll get this for OOo2.0.
Comment 6 openoffice 2003-09-25 10:42:40 UTC
.
Comment 7 openoffice 2003-09-25 10:43:47 UTC
It is an enhancement.
Comment 8 bobharvey 2003-09-25 11:25:03 UTC
Interesting.
I have followed the "politics" and "cultural conventions" of the 
comments I have raised, but this one has me puzzled.  

I don't know why the resolution of unexpected behaviour is regarded as 
an "enhancement".  Something about that suggests that the original 
behaviour was unquestionable, and that my suggestion is complicating 
something that was already perfectly acceptable.

That's not the way it feels when you use it.  It feels like a bug, and 
I reported it because It felt like a bug.  It was something that did 
not do what I expected, and working on the principle of least 
astonishment, that makes it in my view something incorrect.  That's 
why I called it a Defect.

There is an air of grudgingness to describe it as an "Enhancement", 
which were I a more emotional person might make me reluctant to make 
further reports.

Look on this as feedback on the feedback process, if you like.
Comment 9 openoffice 2003-11-11 13:25:41 UTC
Sorry, I did not intend to be offending.

The description of issue types states:

Defect	        an issue in existing feature/functionality
Enhancement	Improvement to existing feature

The undo for page styles was left out intentionally due to technical
reasons. Thus following the definition above this is an enhancement. :-) 
Comment 10 openoffice 2003-11-12 09:24:50 UTC
*** Issue 22335 has been marked as a duplicate of this issue. ***
Comment 11 lohmaier 2003-12-12 16:56:19 UTC
*** Issue 22368 has been marked as a duplicate of this issue. ***
Comment 12 lohmaier 2003-12-14 18:08:33 UTC
*** Issue 23540 has been marked as a duplicate of this issue. ***
Comment 13 lohmaier 2003-12-14 18:09:28 UTC
*** Issue 23540 has been marked as a duplicate of this issue. ***
Comment 14 openoffice 2004-01-07 09:54:01 UTC
fixed, changed files:
sw/sw/inc/SwUndoPageDesc.hxx 	1.1.2.1 	
sw/sw/inc/doc.hxx 	1.46.30.5 	
sw/sw/inc/pagedesc.hxx 	1.5.160.2 	
sw/sw/inc/swundo.hxx 	1.5.292.4 	
sw/sw/source/core/doc/docdesc.cxx 	1.17.126.2 	
sw/sw/source/core/doc/doclay.cxx 	1.13.30.1 	
sw/sw/source/core/layout/atrfrm.cxx 	1.39.38.1 	
sw/sw/source/core/layout/pagedesc.cxx 	1.4.126.1 	
sw/sw/source/core/undo/SwUndoPageDesc.cxx 	1.1.2.1 	
sw/sw/source/core/undo/makefile.mk 	1.3.126.2 	
sw/sw/source/core/undo/undo.hrc 	1.1.2.3 	
sw/sw/source/core/undo/undo.src 	1.1.2.3 	
sw/sw/source/ui/app/docstyle.cxx 	1.9.126.2 	
sw/sw/source/ui/shells/textsh1.cxx 	1.32.46.1 	
Comment 15 openoffice 2004-01-12 12:34:10 UTC
ready for QA
Comment 16 openoffice 2004-02-03 14:56:46 UTC
new parent
Comment 17 openoffice 2004-03-17 13:47:33 UTC
*** Issue 26627 has been marked as a duplicate of this issue. ***
Comment 18 stefan.baltzer 2004-03-24 13:48:01 UTC
*** Issue 22335 has been marked as a duplicate of this issue. ***
Comment 19 stefan.baltzer 2004-04-18 09:11:34 UTC
SBA: Reassigned to ES.
Comment 20 eric.savary 2004-05-05 15:56:15 UTC
fixed
Comment 21 eric.savary 2004-05-05 15:56:43 UTC
ES: verified in cws swundo01
Comment 22 eric.savary 2004-06-07 13:05:06 UTC
Ok in src680m40
Comment 23 auberger 2004-06-12 23:20:59 UTC
Seems to work in 680m41 but menu item "Edit - Undo:" does not contain any
further text so you don't know what you're going to undo. Whereas after the undo
the redo menu item has some additional text "Redo: Change Page Style: <Name of
Page Style>"
Comment 24 bobharvey 2004-06-12 23:39:40 UTC
Crikey!  you lot don't half rattle on with it.  680m41 indeed!  I only downloaded 680m38 a few hours 
ago.  In that the menu contained "undo direct page break"

I do like OOo