Issue 79885 - Macro Security not changeable in Aqua port m221+aquavcl02
Summary: Macro Security not changeable in Aqua port m221+aquavcl02
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m221
Hardware: Mac Mac OS X, all
: P2 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: ericb
QA Contact: issues@porting
URL:
Keywords: aqua
: 79347 (view as issue list)
Depends on:
Blocks: 79304
  Show dependency tree
 
Reported: 2007-07-23 02:16 UTC by jjmckenzie
Modified: 2007-09-12 05:14 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Error screen from Testtool (153.33 KB, image/png)
2007-07-23 02:20 UTC, jjmckenzie
no flags Details
OpenOffice AQUA screenshot with Macro Security selected (95.41 KB, image/png)
2007-07-23 02:21 UTC, jjmckenzie
no flags Details
SChanged macro security (182.24 KB, image/png)
2007-07-24 07:55 UTC, pavel
no flags Details
Crash Log from OpenOffice.org AQUA m225 + macosxcarbonfixes on load of 10ertest_680 test file (29.96 KB, text/rtf)
2007-08-22 04:53 UTC, jjmckenzie
no flags Details
patch to allow macros to work on Aqua ( Mac OS X ) (1.07 KB, patch)
2007-09-11 13:38 UTC, eric.bachard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description jjmckenzie 2007-07-23 02:16:09 UTC
Running the AQUA testtool with the topten test generates an error when the Macro
Security check is conducted.  
A manual check of the program reveals that this function does not appear to be
implemented with the Aqua build.
attached are two screen shots that show the error and the screen where the error
occurs.  This error is masked in the X11 testtool and refers to another issue.
Comment 1 jjmckenzie 2007-07-23 02:20:27 UTC
Created attachment 46981 [details]
Error screen from Testtool
Comment 2 jjmckenzie 2007-07-23 02:21:29 UTC
Created attachment 46982 [details]
OpenOffice AQUA screenshot with Macro Security selected
Comment 3 jogi 2007-07-24 06:52:12 UTC
Confirmed. It's an issue for the port not for the test.
Tools / Options / OOo / Security / -> Click Macro Security button 
BUG; The Macro Security isn't changeable.
Comment 4 jogi 2007-07-24 06:53:44 UTC
jsi->pl: Could have a look at it?
Comment 5 pavel 2007-07-24 07:54:17 UTC
Interesting.

It works here in hacked-together-build SRC680_m222 + aquavcl01, language cs. Screenshot attached.
Comment 6 pavel 2007-07-24 07:55:29 UTC
Created attachment 47016 [details]
SChanged macro security
Comment 7 eric.bachard 2007-07-24 08:05:26 UTC
ericb->pjanik

indeed, SRC680_m222 + aquavcl01 is really a hack  ... maybe you meant aquavcl02 ?

If so, this is normal : the changes to make the testool wortk are in aquavcl02 cws


Comment 8 pavel 2007-07-24 08:21:13 UTC
*** Issue 79347 has been marked as a duplicate of this issue. ***
Comment 9 philipp.lohmann 2007-07-24 09:51:56 UTC
This is not a testtool error. You can reproduce this easily; the reason is that
the macro security dialog is implemented by the
com.sun.star.security.DocumentDigitalSignatures service which does not seem to
exist on mac.
Comment 10 jogi 2007-07-24 10:19:25 UTC
we haven't said that this is a TT error...
Comment 11 philipp.lohmann 2007-08-10 14:22:52 UTC
The problem here seems to be no xmlsecurity module. That contains the dialog to
enable macros. But xmlsecuritry has mozilla as dependency, which is disabled in
our current builds -> no xmlsecurity. The problem wasn't so visible before
because the default was that macros would be executed after confirmation by the
user. This default now seems to be changed to not excute at all and cannot be
changed without the missing xmlsecurity service.

Or perhaps I'm totally wrong :-)
Comment 12 bjoern.milcke 2007-08-20 20:27:15 UTC
As a workaround, you can set the macro security level to medium (that's where you get the prompt 
whether to execute them or not), by modifygin the file ~/Library/Application Support/OpenOffice.org-
aqua/2/user/registry/data/org/openoffice/Office/Common.xcu

Just add the following, e.g. at the end - 1 line:

 <node oor:name="Security">
  <node oor:name="Scripting">
   <prop oor:name="MacroSecurityLevel" oor:type="xs:int">
    <value>1</value>
   </prop>
  </node>
 </node>

(A value of 0 is unwise :-), ok it is level "low")
Comment 13 jjmckenzie 2007-08-22 04:47:15 UTC
@bm:
A level of zero '0' is used for automated testing so that 10ertest.sxw will run
the complete test.  However, loading this file causes OpenOffice.org AQUA to
immediately terminate.  I will attach the crashlog to this issue.
James
Comment 14 jjmckenzie 2007-08-22 04:53:09 UTC
Created attachment 47708 [details]
Crash Log from OpenOffice.org AQUA m225 + macosxcarbonfixes on load of 10ertest_680 test file
Comment 15 eric.bachard 2007-08-22 07:45:59 UTC
ericb)->jjmckenzie

macosxcarbonfixes is not the best version for the test

Can you try with m225 vanilla. There is one here:  http://ftp.cusoo.org/MacOSX/INTEL/snapshots_aqua/
august_17/en-US/ 

Note; this link will disappear soon, when new versions will be available.

Comment 16 philipp.lohmann 2007-09-03 13:49:13 UTC
building with mozilla indeed solves the problem of the absent macro security.
Also building mozilla in the moz modules worked straightforward for me (I needed
to install gtk+2-dev and its dependencies with fink).  So unless you want to
investigate on this crash issue i think we can close this one.
Comment 17 jjmckenzie 2007-09-03 19:48:16 UTC
@pl:
Can you provide the configure line?
I have Fink installed as well as GTK+2.0-dev.
James
Comment 18 philipp.lohmann 2007-09-04 09:41:24 UTC
simply do not add --disable-mozab and --disable-mozilla; and you'll need the
mozilla 1.7.5 source tarball in moz/download. FWIW this is my configure line

 ./configure \
 --enable-dbgutil \
 --with-lang="en-US" \
 --with-jdk-home=/Library/Java/Home/ \
 --with-epm=internal \
 --disable-odk \
 --disable-pasf \
 --disable-gtk \
 --with-build-version=$OOVERSION-`date +%d-%m-%y` \
 --disable-fontconfig \
 --disable-neon \
 --without-nas

for a normal product build you'll want to remove --enable-dbgutil
Comment 19 eric.bachard 2007-09-04 09:47:20 UTC
ericb->pl

yes, but this means fink( or darwin ports), gtk+2 and co have to be installed on Aqua build ?

IMHO install everything just to make macro work, is a bit hack, no ?

More simple, I'd suggest to first test if just use new zipped mozilla archives could be a workaround 
( avoiding everything fink/ darwin ports ..etc to be installed ).

A long time change would be to remove all those dependencies, or at least simplify them

Comment 20 philipp.lohmann 2007-09-04 10:16:58 UTC
fink has to be installed anyway (if not, somebody should long have since updated
the mac os build instructions). For the dialog dependency discuss this with jl,
see issue 81230.
Comment 21 eric.bachard 2007-09-11 13:07:58 UTC
I got a patch tested working with m227 + aquavclcarbonfixes 

1) with it, gtk and security API are decoupled for true.

2) I have choosen to only enable security on Aqua version, but the fix is
trivial for all MACOSX versions.

Comment 22 eric.bachard 2007-09-11 13:30:30 UTC
issue fixed in aquavclcarbonfixes for _Aqua_ONLY_

@james : we need more time for X11 version. Please file a new issue for it
Comment 23 eric.bachard 2007-09-11 13:38:05 UTC
Created attachment 48179 [details]
patch to allow macros to work on Aqua ( Mac OS X )
Comment 24 eric.bachard 2007-09-11 14:36:45 UTC
Please forgot my patch : it does nothing, and just pass --disable-build-mozilla
+ put the moz zipped archive at th right place and everything will work fine.

Changes removed from aquavclcarbonfixes. 

Can we kee this issue as fixed ?
Comment 25 philipp.lohmann 2007-09-11 14:44:54 UTC
I consider this verified then.
Comment 26 jjmckenzie 2007-09-12 05:14:41 UTC
@ericb:  Thanks for the fix can we put the proper configure line here so that it
can serve as a reference?  I will close this issue.
Thank you.
James