Issue 80090 - to-be-SRC680_m223: deliver sallayout.hxx and change the path?
Summary: to-be-SRC680_m223: deliver sallayout.hxx and change the path?
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: 680m222
Hardware: All All
: P1 (highest) Trivial (vote)
Target Milestone: ---
Assignee: rt
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-27 04:07 UTC by pavel
Modified: 2007-07-28 06:48 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Deliver sallayout and use it correctly (1.22 KB, patch)
2007-07-27 04:08 UTC, pavel
no flags Details | Diff
patch for vcl (3.86 KB, patch)
2007-07-27 10:44 UTC, philipp.lohmann
no flags Details | Diff
patch for svx (592 bytes, patch)
2007-07-27 10:46 UTC, philipp.lohmann
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2007-07-27 04:07:42 UTC
svx breaks because vcl/plug/vcl/sallayout.hxx was not delivered.

Philipp: Should it be and thus is the attached patch correct?
Comment 1 pavel 2007-07-27 04:08:43 UTC
Created attachment 47131 [details]
Deliver sallayout and use it correctly
Comment 2 eric.bachard 2007-07-27 07:47:07 UTC
Add me on CC
Comment 3 pavel 2007-07-27 08:56:04 UTC
vcl's deliver cleanup:

-mkdir: %_DEST%\inc%_EXT%\vcl\plug
-mkdir: %_DEST%\inc%_EXT%\vcl\plug\vcl
Comment 4 philipp.lohmann 2007-07-27 09:44:32 UTC
The question must be which god damned idiot included sallyout.hxx in svx.  He
should be staked and burned.
Comment 5 philipp.lohmann 2007-07-27 10:44:21 UTC
Created attachment 47134 [details]
patch for vcl
Comment 6 philipp.lohmann 2007-07-27 10:46:38 UTC
Created attachment 47135 [details]
patch for svx
Comment 7 philipp.lohmann 2007-07-27 10:48:26 UTC
pl->rt: I don't like do expose the whole SalLayout class to the mercy of the
applications. One of the big advantages of mergesvp was that this header was NOT
delivered anymore.

So please apply the last two attached patches.
Comment 8 rt 2007-07-27 11:20:02 UTC
Patches applied as masterfix.
Comment 9 pavel 2007-07-28 06:48:56 UTC
Verified. Closing.