Created attachment 47276 [details]
keyword text file transferred from Issue 77996.

adding timar to CC.

adding keyword.

Note that including non-ASCII characters needs some changes. A static const
sal_Char table, String::CreateFromAscii() to insert to the map, and
String::ToUpperAscii() before calls won't do anymore. CharClass::toUpper()
should be used instead (see unotools/charclass.hxx), accessible via
ScGlobal::pCharClass, and the table been kept as sal_Unicode in UCS2 encoding.

Created attachment 47998 [details]
test document

Work is ongoing in the celltrans02 CWS.

@KAMI or timar

Could one of you take the test document I have attached, save it as xls, and
open it in the Hungarian version of Excel?

I want to make sure that those localized keywords *do* work in the Hungarian
version of Excel.

Thanks
Kohei

The implementation is complete in celltrans02 CWS.  The patch has been comitted
to ooo-build trunk first.

I'm going to resolve this issue as FIXED.

@kami_, timar

Please reopen this if there is any issues.

reopening it for qa.

re-assigning it to fst for qa.

Hi Kohei,

I need at least two installation sets to proceed with the QA work for this CWS.
Preferedare Windows and Solaris. At least Windows and Linux are a must have.

Please provide me such Installationsets.

Frank

Hi Kohei,

Thanks for your work. I found one issue in the test document:
FILENAME parameter of CELL should be FILENÉV not FÃJLNÉV (btw. Hungarian Excel
Help is buggy in this regard). The rest of the translations work well - even
those that you left out from the test file (LAP, KOORD, TÃPUS, FORMA, ZÃRÓJELEK).

I volunteer to create Windows and Linux builds for this CWS.

Thanks,
Andras

Andras,

Thanks for testing this, and thank you very much for volunteering to build the
Windows and Linux builds! :-)  You made my day.

Let me put the fix to address the FILENÉV keyword issue, and I'll let you know
when it's done.

Created attachment 48654 [details]
revised test document

Andras,

The CWS is ready.  So, please go ahead with the build.  Again, thank you very
much for your help!

Frank, please expect the builds from Andras.

en-US builds are ready to download from here:
ftp://ftp.fsf.hu/OpenOffice.org_hu/devel/SRC680_m231+cws_celltrans02/

Kohei, may I ask you a question. There can be 14 parameters of CELL function.
Why did you implement only 9? Translation of COORD, FORMAT, PARENTHESES, SHEET
and TYPE are missing. 

Hi Andras,

>There can be 14 parameters of CELL function.  Why did you implement only 9?
Translation of COORD, FORMAT, PARENTHESES, SHEET and TYPE are missing.

The reason is that Calc doesn't offer functionality for those keywords even in
English, so there is no point in translating them (you'll get Error result anyway).

In future if Calc decides to implement these missing parameters, then it'll make
sense to translate them at that point.

Created attachment 48679 [details]
Are you sure? COORD, FORMAT, PARENTHESES, SHEET and TYPE seem to work...

@timar

Yes, you're right!  How did I miss that!

Let me add those translations that you provided.  Sorry about this....

Kohei

Created attachment 48686 [details]
revised test document to incorporate the missing Hungarian keywords.

Ok.  I've just committed into celltrans02 CWS the additional Hungarian keywords
that Andras pointed out as missing.  Thanks for pointing it out!

When rebuilding, you need to touch sc/source/core/tool/cellkeytranslator.cxx for
the keyword change to take effect.  This is because the keywords are encoded in
sc/source/core/tool/cellkeywords.inl which is autogenerated by a script. 
Because this file is not in makefile.mk, a change in this file will not be
noticed by the build system.  So you need to touch cellkeytranslator.cxx to
force it to be re-compiled.

Kohei

Looks good now, thanks. Builds have been updated at
ftp://ftp.fsf.hu/OpenOffice.org_hu/devel/SRC680_m231+cws_celltrans02/

Hi all,

sorry for the delay, had a tight schedule.

@timar

Thanks for building the packages. Will test them soon.

Frank

@kohei:
> When rebuilding, you need to touch sc/source/core/tool/cellkeytranslator.cxx

That's awkward. The #include "cellkeywords.inl" isn't caught by the dependency
generator? e.g. sc/unxlngi6.pro/misc/all_tool.dpslo doesn't have a
../../../unxlngi6.pro/slo/cellkeytranslator.obj entry for it? Not even after a
dmake depend=true
in sc/source/core/tool and another subsequent dmake?

  Eike

@er: yes, it's awkward.  Do you have any idea how to make it less awkward? :-)

If the dependency isn't generated from the include statement it sounds like a
bug of makedepend to me. Cc'ing Ause 'hjs' for this.

Having fiddled around with it a bit it seems that makedepend ignores includes
that don't start at the very first column, e.g.
#include "lala.inl"
works fine and generates a dependency, while
  #include "lala.inl"
doesn't.

For the records: issue 82442.

Hi kohei, timar,

a lot of the required autotests have been failed due to the fact that the binary
file filters are broken or not present. Please check that the fix itself does
not corrupt the binary file filters. I don't expect a problem here but to be
sure, you know.

Timar could you please check this and build new installation sets ? I've used
Windows and Linux build. Both do show this problem. Without a proper fixing I
can't pass this CWS over to RE for integration as we could not be sure what
caused this problem.

Thanks.

Frank

The code doesn't even remotely touch the filter code.  The major portion of the
code change is well isolated, and it only affects two built-in functions.

So, corrupting the binary filter code is not likely caused by this change.  At
least I don't think so.

Kohei

I compiled with --disable-binfilter to save compilation time. Please re-confirm
if you still need new builds.

Hi Timar,

yes, I need new Installationssets with binfilter compiled because if we do not
run the autotests completly, we can not be sure that nothing is broken. This is
a must for cws handling and the cws gatekeeper will reject this cws if we do not
proceed as described.

Thanks for building the inst sets.

Frank

I uploaded builds with binfilter to
ftp://ftp.fsf.hu/OpenOffice.org_hu/devel/SRC680_m231+cws_celltrans02

thanks a lot

Created attachment 48998 [details]
Testdocument

found fixed on cws celltrans02

found integrated on master m239 using Linux, Solaris and Windows build