Issue 80997 - track and fix some potential crashes on Aqua version
Summary: track and fix some potential crashes on Aqua version
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m225
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: ericb
QA Contact: issues@porting
URL:
Keywords: aqua
Depends on:
Blocks:
 
Reported: 2007-08-24 10:20 UTC by eric.bachard
Modified: 2007-10-23 17:52 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
first patch for potential leaks (5.54 KB, patch)
2007-08-24 10:27 UTC, eric.bachard 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description eric.bachard 2007-08-24 10:20:15 UTC 
Fix potential memory leaks and crashes in the Aqua version.

A first patch will be atteched
Comment 1 eric.bachard 2007-08-24 10:20:59 UTC 
Set keyword and target
Comment 2 eric.bachard 2007-08-24 10:27:15 UTC 
Created attachment 47774 [details]
first patch for potential leaks
Comment 3 eric.bachard 2007-08-24 10:27:36 UTC 
fixed in aquavclcarbonfixes
Comment 4 eric.bachard 2007-08-24 18:57:42 UTC 
typo
Comment 5 eric.bachard 2007-08-25 11:10:42 UTC 
Reopening. 

I think I found other problems in dtrans. If possible, NSCFArray and the string
""  leaks will have to be fixed in this issue. ( no idea what "XTUM" means  -
probably question of MUTX issue )

Two logs: 

ordinateur-de-eric-b:~/Desktop/SRC680_m225/vcl ericb$ leaks soffice.bin
Process 12454: 37073 nodes malloced for 23237 KB
Process 12454: 8 leaks for 1328 total leaked bytes.
Leak: 0x078acc00  size=1024     string ''
Leak: 0x072a3d20  size=64
        0x064ecc48 0x00000001 0x1130dda8 0x071ee16c     H.N.......0.l...
        0x00000000 0x072a3d60 0x00000000 0x072a3d34     ....`=*.....4=*.
        0x00000000 0x00000000 0x00000000 0x00000000     ................
        0x00000000 0x00000000 0x00000000 0x00000000     ................
Leak: 0x072a3d60  size=64       string 'XTUM'
Leak: 0x07204a80  size=48       string 'XTUM'
Leak: 0x07204950  size=48       string 'XTUM'
Leak: 0x072046f0  size=48       string 'XTUM'
Leak: 0x1b7c5f20  size=16       instance of 'NSCFArray'
        0x07201730 0x00010486 0x00000008 0x1b7c6630     0. .........0f|.
Leak: 0x1b7c6b20  size=16       instance of 'NSCFArray'
        0x07201730 0x00010486 0x00000008 0x1b7c6d00     0. ..........m|.

And more precisely, using export MallocStackLogging=1 *before* tu run gdb, gives: 

Leak: 0x1f7d0b00  size=16       instance of 'NSCFArray'
        0x07201730 0x00010486 0x00000005 0x1f7d0ca0     0. ...........}.
        Call stack: [thread 0]: | 0x2 | start | start | main | SVMain() |
ImplSVMainHook(unsigned char*) | RunApplicationEventLoop | _AcquireNextEvent |
ReceiveNextEventCommon | RunCurrentEventLoopInMode | CFRunLoopRunInMode |
CFRunLoopRunSpecific | TimerVector |
MainRunLoopForThreadedApps(__EventLoopTimer*, void*) | ImplSVMain() |
desktop::Desktop::Main() | Application::Execute() | Application::Yield(bool) |
AquaSalInstance::Yield(bool, bool) | SendEventToEventTarget |
SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*,
HandlerCallRec*) | DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*,
HandlerCallRec*) | ToolboxEventDispatcherHandler(OpaqueEventHandlerCallRef*,
OpaqueEventRef*, void*) | SendEventToEventTargetWithOptions |
SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*,
HandlerCallRec*) | DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*,
HandlerCallRec*) | HandleOOoSalTimerEvent(OpaqueEventHandlerCallRef*,
OpaqueEventRef*, void*) | SalTimer::CallCallback() |
Timer::ImplTimerCallbackProc() | Timer::Timeout() | Link::Call(void*) const |
component_writeInfo | component_writeInfo |
svt::ToolboxController::bindListener() |
SvxSearchItem::QueryValue(com::sun::star::uno::Any&, unsigned char) const |
SfxDispatcher::QueryState(unsigned short, com::sun::star::uno::Any&) |
SfxShell::GetSlotState(unsigned short, SfxInterface const*, SfxItemSet*) |
SwRedlineAcceptDlg::SwRedlineAcceptDlg[not-in-charge](Dialog*, unsigned char) |
SwView::IsPasteAllowed() |
TransferableDataHelper::CreateFromSystemClipboard(Window*) |
aqua::AquaClipboard::getContents() |
OSXTransferable::OSXTransferable[in-charge](com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory>,
com::sun::star::uno::Reference<com::sun::star::datatransfer::XMimeContentTypeFactory>,
boost::shared_ptr<DataFlavorMapper>) | OSXTransferable::initClipboardItemList()
| OSXTransferable::addClipboardItemFlavors(void*) | PasteboardCopyItemFlavors |
CoreGetCachedItemFlavorsAndTranslations(OpaquePasteboardRef*, void*, __CFArray
const**, __CFDictionary const**) | __CFArrayInit | _CFRuntimeCreateInstance

I'll attach patch when possible
Comment 6 eric.bachard 2007-08-25 12:01:59 UTC 
More clear:  keep this issue fixed, and open a new one about leaks

Sorry for the noise
Comment 7 philipp.lohmann 2007-10-23 17:51:55 UTC 
verified
Comment 8 philipp.lohmann 2007-10-23 17:52:10 UTC 
closing