Apache OpenOffice (AOO) Bugzilla – Issue 81127
Get rid of -fsigned-char?
Last modified: 2017-05-20 09:13:55 UTC
Our (SUSE's) PPC team fixed signed/unsigned stuff in OOo, see: http://www.openoffice.org/issues/buglist.cgi?issue_id=81120+81121+81123+81125 What do you think about to removing -fsigned-char?
Created attachment 47850 [details] This patch removes the -fsigned-char flag for ppc builds.
reassign to hr for review.
@pmladek: I think we should apply this patch. Since I can't test PPC/Linux it wouldn't be that helpful if I apply this one to one of my CWSs. Can you create a CWS? Pavel can you QA this change? Reassign to pmladek: please proceed if the PPC/Linux community approves.
cc'ing Pavel.
.
Is this still an issue ? Is the patch still valid ?
Created attachment 74722 [details] Last version of the patch
We still use the change. I have attached the last version of the patch that is based on some Caolan's clean up. I am sorry, I do not have time to create the CWS => reassigning to the owner of the component for further tracking.
since nobody raised substantial objections to this in 3 years, i guess it's time to commit it in any old CWS that happens to be lying around :) thanks for the patch, pmladek. fixed in CWS sw34bf03 http://hg.services.openoffice.org/hg/cws/sw34bf03/rev/381c9e18914d
@pmladek: please verify oh, and btw: the new gbuild stuff will of course not build with any arch specific cflags (because it only supports x86 and x86_64 right now). so with this change all modules should be built with same char signedness on linux/ppc.
well, let's just assume it works :)