Issue 81407 - Adding more than one color in one session, causes OOo to crash
Summary: Adding more than one color in one session, causes OOo to crash
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 2.3.0 RC1
Hardware: All Windows XP
: P2 Trivial (vote)
Target Milestone: OOo 2.3.1
Assignee: christian.guenther
QA Contact: issues@framework
URL:
Keywords:
: 82835 82960 83114 83909 84345 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-09-09 11:06 UTC by cno
Modified: 2007-12-07 21:01 UTC (History)
8 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description cno 2007-09-09 11:06:51 UTC
Using the Dutch version, build 9215.

How to reproduce:
Tools|Options|OpenOffice,org >Colors
Edit , choose color, Click OK
Give name, click Add

Again:
Edit , choose color, Click OK
Give name, click Add
Click OK > Crash

Other scenario:
Tools|Options|OpenOffice,org >Colors
Edit , choose color, Click OK
Give name, click Add
Click OK > Ok

Again:
Tools|Options|OpenOffice,org >Colors
Edit , choose color, Click OK
Give name, click Add
Click OK > Crash

Adding only one color is no problem, the secons crashes OOo
Comment 1 cno 2007-09-09 11:08:36 UTC
Two (of the three, four) related error reports:
- rhtj9n
- rytj9n
Comment 2 mike_hall 2007-09-09 17:53:16 UTC
Crashes with en-us version in same circumstances under win XP - 2.3.0 RC2

Error report rvrp9n
Comment 3 Olaf Felka 2007-09-10 14:54:55 UTC
@ cgu: Please have a look.
Comment 4 christian.guenther 2007-09-18 10:22:54 UTC
I can reproduce the bug.
everything works correct, when I change the whole name of the color
the crash occurs when I onky add a letter to the 'old' name and click on add
afterwards.
e.g.
 name of the first color aaa name of the second color aaab
Please have a look.
Comment 5 clippka 2007-09-18 14:22:00 UTC
fixed in
svx/source/dialog/tpcolor.cxx (r. 1.29.114.1)

changed

ResMgr rMgr = DIALOG_MGR();

to

ResMgr& rMgr = DIALOG_MGR();
Comment 6 clippka 2007-10-19 09:19:14 UTC
verified in cws, back to qa
Comment 7 crxssi 2007-10-19 15:20:24 UTC
I know this is "fixed" for later releases, but I want to verify it also does
this on Linux OO 2.3.0.  I can add two colors; as soon as I add the third color,
WHAM:

/oa/openoffice.org2.3.0/program/soffice: line 251: 29215 Segmentation fault    
 "$sd_prog/$sd_binary" "$@"
Comment 8 crxssi 2007-10-19 15:36:02 UTC
I meant to also add that the problem is pretty severe and it isn't just that you
can add one color at a time.  It simply is not possible to add more than one new
color, EVER.  Even if I exit out of options and go back in, I still can't add
another color.  Even if I save and exit out of OpenOffice completely, go back in
to options and try to add more more color, it crashes.  It also crashes the same
way when you try to add colors through Area, rather than through Tools->Options.

The ONLY way I could get my 7 custom colors into OpenOffice was to replace
(modify) existing "Chart X" colors.  Hopefully this won't cause a problem with
the new charting functions...

This is a critical flaw.  Since it was reported on RC1, it should NOT have made
its way into the live/final/released 2.3.0 :(   Without a workaround for the
released version, many of us are stuck with a very bad problem.
Comment 9 cno 2007-10-19 15:52:20 UTC
@ crxssi
I just tested and indeed with the third new color (all completely different
names) > freeze.
Did this test on the lasted milistone (M7) but the fixt won't be integrated in that.
So wait for next build and test than.
Comment 10 Mechtilde 2007-10-22 22:18:28 UTC
In which CWS should be the fix
Comment 11 p9w.vu.31122010 2007-10-22 22:41:34 UTC
I must reopen this issue because there is some unclarity concerning the
behaviour in m234.

The office keeps crashing when adding new Colors (at least three times; see
issue  82835)

Thus I had a look at svx/source/dialog/tpcolor.cxx and found that all
ResMgr-Occurances have been replaced by ResMgr& except the one in "Add" approx
line 516. After changing that one everything works perfectly.

@cl: Do you have that one changed in your CWS as well?

Comment 12 p9w.vu.31122010 2007-10-22 22:42:09 UTC
*** Issue 82835 has been marked as a duplicate of this issue. ***
Comment 13 clippka 2007-10-23 15:48:35 UTC
cl->simon: yes
Comment 14 Olaf Felka 2007-10-25 09:57:54 UTC
*** Issue 82960 has been marked as a duplicate of this issue. ***
Comment 15 christian.guenther 2007-10-25 14:18:06 UTC
CGU: Verified in cws impress131
Comment 16 christian.guenther 2007-10-30 10:56:56 UTC
*** Issue 83114 has been marked as a duplicate of this issue. ***
Comment 17 christian.guenther 2007-11-21 15:26:44 UTC
CGU: integrated in src680m236 and oog680m9
Comment 18 christian.guenther 2007-12-03 12:34:36 UTC
*** Issue 83909 has been marked as a duplicate of this issue. ***
Comment 19 Regina Henschel 2007-12-07 21:01:31 UTC
*** Issue 84345 has been marked as a duplicate of this issue. ***